已合并
test: ut for swap muon and pp layout #3857
test: ut for swap muon and pp layout #3857
已合并
m0_50947149创建于 8月8日
m0_50947149
m0_50947149
8月8日

What this PR does / why we need it?

This PR improves UT coverage and execution efficiency for Pipeline Model Parallel Layout and Swap-Muon.

  • Adds a parameterized CPU UT for Pipeline Layout, covering valid layouts, PP/VPP mapping, MTP, and invalid configurations.
  • Adds a two-NPU checkpoint round-trip UT for Swap-Muon.
  • Fixes stale optimizer-state references after loading a Swap-Muon checkpoint.
  • Reduces the default Swap Optimizer UT to a two-NPU small-model workload. The original eight-NPU topology cases are retained as slow tests.

https://gitcode.com/Ascend/MindSpeed/issues/156
https://gitcode.com/Ascend/MindSpeed/issues/241

Does this PR introduce any user-facing change?

No public API or usage change is introduced. Swap-Muon checkpoint restoration is corrected without changing the existing workflow.

How was this patch tested?

  • Pipeline Layout UT: 10 parameterized CPU cases passed.
  • Swap-Muon checkpoint UT: run with two Ascend NPUs.
  • Full topology tests can be run with eight NPUs and --run-all.
  • Python syntax and pre-commit checks passed.
likedislike
Pull Request已成功合入, 合并人@ascend-robot
(感谢 m0_50947149 的贡献)
m0_50947149m0_50947149
8月8日 创建了 pull request,commit 5ce38389
ascend-robotascend-robot成员
8月8日 添加了label:ascend-cla/no
ascend-robot
ascend-robot成员
8月8日 评论:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.


PR Approval Progress

✅ Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
repo-Ascend/MindSpeed ✅ 郭鹏, wuweiqiang24 (2/2) ✅ 郭鹏 (1/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)

CLA Signature Pass

m0_50947149, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
ascend-robot
ascend-robot成员
8月8日 评论:

ascend docs pipeline is running...

likedislike
此处折叠了56条消息 查看更多
ascend-robotascend-robot成员
8月28日 添加了label:lgtm
ascend-robot
ascend-robot成员
8月28日 评论:

The MR can not be merged, because of CodeReview discussion not resolved

If you want to solve this problem, you can click here to do it in the FAQs.

likedislike
LLiz成员
8月28日 解决了最后一个问题
ascend-robotascend-robot成员
8月28日 合入了pull request
ascend-robot
ascend-robot成员
8月28日 评论:

Pull Request 已合并或已关闭。

If you want to solve this problem, you can click here to do it in the FAQs.

likedislike