已合并
[fix]Removing unused macro definitions which cause ninja build to fail. #89
一只食醉狗创建于 4月21日
[fix]Removing unused macro definitions which cause ninja build to fail. #89
已合并
一只食醉狗创建于 4月21日
4月21日

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug
/kind task
/kind feature

What does this PR do / why do we need it:
两处ninja不支持语法。删除一个未使用宏定义。一个修改为ninja支持语法。

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewers:

验证
改后:lnhtest file = third_party/Tensorpipe/tensorpipe/core/context.cc
改前:lnhtest file = build/third_party/Tensorpipe/tensorpipe/CMakeFiles/tensorpipe.dir/compiler_depend.ts

likedislike
Pull Request已成功合入, 合并人@ascend-robot
(感谢 一只食醉狗 的贡献)
一只食醉狗
4月21日 创建了 pull request,commit 67a3733d
ascend-robot
ascend-robot成员
4月21日 评论:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here
You can get sig-info at here


PR Approval Progress

Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
repo-Ascend/Tensorpipe 李伟, 吴环宇 (2/2) 李伟 (1/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)

CLA Signature Pass

LiNuohang, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
ascend-robotascend-robot成员
4月21日 添加了label:ascend-cla/yes
一只食醉狗
4月21日 评论:

compile

likedislike
ascend-robotascend-robot成员
4月21日 添加了label:ci-pipeline-running
此处折叠了45条消息 查看更多
一只食醉狗
4月21日 修改了pull request 的描述
liwei386成员
4月21日 评论:

/approve

likedislike
ascend-robotascend-robot成员
4月21日 添加了label:approvedlgtm
ascend-robot
ascend-robot成员
4月21日 评论:

Review Guide

This pull-request passes review.
Committers who wrote a comment of /approve are: 李伟.
Reviewers who wrote a comment of /lgtm are: 李伟, 吴环宇.

likedislike
ascend-robotascend-robot成员
4月21日 合入了pull request