Merged
fix(torchair): collect multiple FX token groups #835
binistAdd on Jun 26
fix(torchair): collect multiple FX token groups #835
Merged
Pull Request has been successfully merged by ascend-robot.
(Thank you for binist's contribution.)ascend-robot
Jun 26 Comments:
Jun 26 Comments:
Jun 26 Added label: ascend-cla/yes
ascend-robot
Jun 26 Comments:
Jun 26 Comments:
Thanks for your pull-request.
The full list of commands accepted by me can be found at here。
You can get sig-info at here
PR Approval Progress
✅ Congratulations! All modules have met the lgtm and approve requirements.
Module Approval Details
| module | lgtm status | approve status |
|---|---|---|
| repo-Ascend/msprobe | ✅ zderry, Jian_Daobao, Tjh-UKN (3/2) | ✅ zderry (1/1) |
💡 Tip:
- Committer can comment
/approveor/lgtm- Commenting
/approveimplies both code review (lgtm) and intent to merge (approve)
CLA Signature Pass
binist, thanks for your pull request. All authors of the commits have signed the CLA. 👍


ascend-robot
Jun 26 Comments:
Jun 26 Comments:
Ascend docs pipeline is running...


73 messages are collapsed here。 See more
Jul 23 Added label: approved
ascend-robot
Jul 23 Comments:
Jul 23 Comments:
The MR can not be merged, because of CodeReview discussion not resolved
If you want to solve this problem, you can click here to do it in the FAQs.


Jul 23 Resolved final issue
Jul 23 Merged pull request
ascend-robot
Jul 23 Comments:
Jul 23 Comments:
Pull Request 已合并或已关闭。
If you want to solve this problem, you can click here to do it in the FAQs.


关联 Issue: https://gitcode.com/Ascend/msprobe/issues/25
修改内容
修复 torchair compare 在 FX dump 多图场景下只处理第一张图的问题。
当前逻辑在扫描到第一组 token 目录后直接停止,导致后续图片的 token dump 目录不会进入比对流程。本次改动将 FX token 目录扫描调整为收集所有 token 目录组,并逐组生成比对数据。
实现说明
gather_data_with_token_id_fx不再在找到第一组 token 目录后提前退出;验证
py_compile: 通过git diff --check: 通过