main

GGitHubFix clang warning about printf format (#3814)

ad9dfe97创建于 2024年10月25日历史提交

文件	最后提交记录	最后更新时间
CMakeLists.txt	Re-organize project structure to separate PyTorch dependencies from core project. (#2542) This is a first step towards the structure we discussed here: https://gist.github.com/stellaraccident/931b068aaf7fa56f34069426740ebf20 There are two primary goals: 1. Separate the core project (C++ dialects and conversions) from the hard PyTorch dependencies. We move all such things into projects/pt1 as a starting point since they are presently entangled with PT1-era APIs. Additional work can be done to disentangle components from that (specifically LTC is identified as likely ultimately living in a projects/ltc). 2. Create space for native PyTorch2 Dynamo-based infra to be upstreamed without needing to co-exist with the original TorchScript path. Very little changes in this path with respect to build layering or options. These can be updated in a followup without commingling directory structure changes. This also takes steps toward a couple of other layering enhancements: * Removes the llvm-external-projects/torch-mlir-dialects sub-project, collapsing it into the main tree. * Audits and fixes up the core C++ build to account for issues found while moving things. This is just an opportunistic pass through but roughly ~halves the number of build actions for the project from the high 4000's to the low 2000's. It deviates from the discussed plan by having a projects/ tree instead of compat/. As I was thinking about it, this will better accommodate the follow-on code movement. Once things are roughly in place and the CI passing, followups will focus on more in-situ fixes and cleanups.	2 年前
lit.local.cfg	[NFC reformat] Run pre-commit on all files and format misc. This is part 1 of ~3, formatting all miscellaneous text files and CPP files matched by a first run of pre-commit. These tend to be low change-traffic and are likely not disruptive. Subsequent patches will format Python files and remaining CPP files.	2 年前
torch.c	Fix clang warning about printf format (#3814) Compiling with clang 16.0 on macOS I have warnings about incorrect printf format (see below). Values to be printed are int64_t, but they are printed with %zu and %ld, which are not portable way to print this type. <...>/torch-mlir/test/CAPI/torch.c:52:3: warning: format specifies type 'size_t' (aka 'unsigned long') but the argument has type 'int64_t' (aka 'long long') [-Wformat] 52 | DEFINE_CHECK(NonValueTensor) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ <...>/torch-mlir/test/CAPI/torch.c:37:13: note: expanded from macro 'DEFINE_CHECK' 36 | fprintf(stderr, #TTT "Type %s rank: %zu\n", testName, \ | ~~~ 37 | torchMlirTorch##TTT##TypeGetRank(TTT##Type)); \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ <scratch space>:78:1: note: expanded from here 78 | torchMlirTorchNonValueTensorTypeGetRank | ^ <...>/torch-mlir/test/CAPI/torch.c:52:3: warning: format specifies type 'long' but the argument has type 'int64_t' (aka 'long long') [-Wformat] 52 | DEFINE_CHECK(NonValueTensor) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ <...>/torch-mlir/test/CAPI/torch.c:42:15: note: expanded from macro 'DEFINE_CHECK' 41 | fprintf(stderr, #TTT "Type %s pos %d size: %ld\n", testName, i, \ | ~~~ 42 | TTT##Sizes[i]); \ | ^~~~~~~~~~~~~ <scratch space>:85:1: note: expanded from here 85 | NonValueTensorSizes | ^ <...>/torch-mlir/test/CAPI/torch.c:53:3: warning: format specifies type 'size_t' (aka 'unsigned long') but the argument has type 'int64_t' (aka 'long long') [-Wformat] 53 | DEFINE_CHECK(ValueTensor) | ^~~~~~~~~~~~~~~~~~~~~~~~~ <...>/torch-mlir/test/CAPI/torch.c:37:13: note: expanded from macro 'DEFINE_CHECK' 36 | fprintf(stderr, #TTT "Type %s rank: %zu\n", testName, \ | ~~~ 37 | torchMlirTorch##TTT##TypeGetRank(TTT##Type)); \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ <scratch space>:112:1: note: expanded from here 112 | torchMlirTorchValueTensorTypeGetRank | ^ <...>/torch-mlir/test/CAPI/torch.c:53:3: warning: format specifies type 'long' but the argument has type 'int64_t' (aka 'long long') [-Wformat] 53 | DEFINE_CHECK(ValueTensor) | ^~~~~~~~~~~~~~~~~~~~~~~~~ <...>/torch-mlir/test/CAPI/torch.c:42:15: note: expanded from macro 'DEFINE_CHECK' 41 | fprintf(stderr, #TTT "Type %s pos %d size: %ld\n", testName, i, \ | ~~~ 42 | TTT##Sizes[i]); \ | ^~~~~~~~~~~~~ <scratch space>:119:1: note: expanded from here 119 | ValueTensorSizes | ^ 4 warnings generated.	1 年前