Closed
[Bug-Report|缺陷反馈]: cumsum Sklansky 尾块 AddFactor 循环边界存在整型提升隐式转换(addFactorCircleLoop - 1 经 uint16_t→int 提升后与循环变量比较) #4459
wangweidongAdd on 13 days agoClosed at 11 days ago
13 days ago Added label: bug-report
wangweidong
13 days ago Comments:
13 days ago Comments:
/assign @gcw_YBIAEfqJ


13 days ago Assign gcw_YBIAEfqJ as responsible person
11 days ago Close issue
11 days ago Added label: resolved
Describe the current behavior / 问题描述
math/cumsum/op_kernel/arch35/cumsum_base/cumsum_core_sklansky.h:481(CumsumCoreSklansky::DoAddTailN,浮点 Sklansky 路径尾块 AddFactor 累加)主循环边界addFactorCircleLoop - 1存在整型提升隐式转换:addFactorCircleLoop为uint16_t(:468,CeilDiv(addLoop, addFactorCircleCount_)结果),- 1运算经 C++ 整型提升为int,再与uint16_t循环变量i比较时再次隐式转换——类型流转全程不显式。addFactorCircleLoop >= 1,尾块必有数据,关联 PR 声明纯类型修饰、无逻辑变化),但命中-Wsign-conversion/-Wconversion类编译告警与静态检查,违反显式转换编码规范;类型演化时存在语义漂移隐患,并造成 review 噪音。Environment / 环境信息
Steps to reproduce the issue / 重现步骤
cumsum_core_sklansky.hDoAddTailN:481:for (uint16_t i = 0; i < addFactorCircleLoop - 1; i++)。-Wsign-conversion/-Wconversion)或静态检查工具扫描该编译单元 → 该行命中隐式转换告警。Describe the expected behavior / 预期结果
主循环边界显式转换:
for (uint16_t i = 0; i < static_cast<uint16_t>(addFactorCircleLoop - 1); i++),消除隐式转换、意图清晰;纯类型修饰、无逻辑变化,仅影响上述 tilingKey 的尾块 AddFactor 累加循环。Related log / screenshot / 日志 / 截图
cumsum_core_sklansky.h:481循环边界addFactorCircleLoop - 1(uint16_t→int 提升后比较);:468addFactorCircleLoop声明为uint16_t。Special notes for this issue/备注
关联 PR:https://gitcode.com/cann/ops-math/merge_requests/7108