WWebRTC LUCI CQFormat /modules
c018bae8创建于 2023年4月20日历史提交
文件最后提交记录最后更新时间
Fix chromium roll: remove variables that are written but not accessed Bug: b/228208976 Change-Id: Iee4df1249f9bc4aa2fa840c0a039543e8560c7c6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258122 Reviewed-by: Björn Terelius <terelius@google.com> Reviewed-by: Ivo Creusen <ivoc@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36459} 4 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
[Cleanup] Add missing #include. Remove useless ones. This CL is the result of running include-what-you-use tool on part of the code base (audio target and dependencies) plus manual fixes. bug: webrtc:8311 Change-Id: I277d281ce943c3ecc1bd45fd8d83055931743604 Reviewed-on: https://webrtc-review.googlesource.com/c/106280 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25311}7 年前
Remove RTC_DISALLOW_COPY_AND_ASSIGN from modules/ Bug: webrtc:13555, webrtc:13082 Change-Id: I2c2cbcbd918f0cfa970c1a964893220ba11d4b41 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247960 Reviewed-by: Artem Titov <titovartem@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: (Daniel.L) Byoungchan Lee <daniel.l@hpcnt.com> Cr-Commit-Position: refs/heads/main@{#35771} 4 年前
Introduce RTC_CHECK_NOTREACHED(), an always-checking RTC_NOTREACHED() And use it in a few places that were using RTC_CHECK(false) or FATAL() to do the exact same job. There should be no change in behavior. Bug: none Change-Id: I36d5e6bcf35fd41534e08a8c879fa0811b4f1967 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/191963 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32567} 5 年前
Remove RTC_DISALLOW_COPY_AND_ASSIGN from modules/ Bug: webrtc:13555, webrtc:13082 Change-Id: I2c2cbcbd918f0cfa970c1a964893220ba11d4b41 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247960 Reviewed-by: Artem Titov <titovartem@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: (Daniel.L) Byoungchan Lee <daniel.l@hpcnt.com> Cr-Commit-Position: refs/heads/main@{#35771} 4 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
"Fix" signed integer overflow in old code It's safe to ignore this overflow since it only affects audio data, not indices or anything like that. Bug: chromium:835637 Change-Id: I60162e4627b08d5e3ba3a21fdae8087f098c7e46 Reviewed-on: https://webrtc-review.googlesource.com/72701 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23030}7 年前
Replace RTC_WARN_UNUSED_RESULT with ABSL_MUST_USE_RESULT in audio_coding Bug: webrtc:12336 Change-Id: Icae229b957c2bfcc410788179a504c576cfde151 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/201736 Reviewed-by: Ivo Creusen <ivoc@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32995} 5 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE. This CL introduced 2 new macros that affect the WebRTC OBJC API symbols: - RTC_OBJC_TYPE_PREFIX: Macro used to prepend a prefix to the API types that are exported with RTC_OBJC_EXPORT. Clients can patch the definition of this macro locally and build WebRTC.framework with their own prefix in case symbol clashing is a problem. This macro must only be defined by changing the value in sdk/objc/base/RTCMacros.h and not on via compiler flag to ensure it has a unique value. - RCT_OBJC_TYPE: Macro used internally to reference API types. Declaring an API type without using this macro will not include the declared type in the set of types that will be affected by the configurable RTC_OBJC_TYPE_PREFIX. Manual changes: https://webrtc-review.googlesource.com/c/src/+/173781/5..10 The auto-generated changes in PS#5 have been done with: https://webrtc-review.googlesource.com/c/src/+/174061. Bug: None Change-Id: I0d54ca94db764fb3b6cb4365873f79e14cd879b8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173781 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31153} 5 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Use backticks not vertical bars to denote variables in comments for /modules/audio_coding Bug: webrtc:12338 Change-Id: I02613d9fca45d00e2477f334b7a0416e7912e26b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227037 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34621} 4 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Replace RTC_WARN_UNUSED_RESULT with ABSL_MUST_USE_RESULT in audio_coding Bug: webrtc:12336 Change-Id: Icae229b957c2bfcc410788179a504c576cfde151 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/201736 Reviewed-by: Ivo Creusen <ivoc@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32995} 5 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Replace RTC_WARN_UNUSED_RESULT with ABSL_MUST_USE_RESULT in audio_coding Bug: webrtc:12336 Change-Id: Icae229b957c2bfcc410788179a504c576cfde151 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/201736 Reviewed-by: Ivo Creusen <ivoc@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32995} 5 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Using fully qualified #include paths in ilbc code. WebRTC internal code should always use include paths that start from the root of the project and that clearly identify the header file. This allows 'gn check' to actually keep dependencies under control because 'gn check' cannot enforce anything if the include path is not fully qualified (starting from the root of the project). Bug: webrtc:8815 Change-Id: I36f01784fa5f5b77eefc02db479b1f7f6ee1a8c3 Reviewed-on: https://webrtc-review.googlesource.com/46263 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21871}8 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Implement a Neon optimized function to find the argmax element in an array. Finding the array element with the largest argmax is a fairly common operation, so it makes sense to have a Neon optimized version. The implementation is done by first finding both the min and max value, and then returning whichever has the largest argmax. Bug: chromium:12355 Change-Id: I088bd4f7d469b2424a7265de10fffb42764567a1 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/201622 Commit-Queue: Ivo Creusen <ivoc@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33052} 5 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Use backticks not vertical bars to denote variables in comments for /modules/audio_coding Bug: webrtc:12338 Change-Id: I02613d9fca45d00e2477f334b7a0416e7912e26b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227037 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34621} 4 年前
Replace RTC_WARN_UNUSED_RESULT with ABSL_MUST_USE_RESULT in audio_coding Bug: webrtc:12336 Change-Id: Icae229b957c2bfcc410788179a504c576cfde151 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/201736 Reviewed-by: Ivo Creusen <ivoc@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32995} 5 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Delete root header file typedef.h. Usage replaced with stdint.h, rtc_base/system/arch.h and rtc_base/system/unused.h, as appropriate. Bug: webrtc:6854 Change-Id: I97225465d14b969903d92979e2df3c3c05d35f18 Reviewed-on: https://webrtc-review.googlesource.com/90249 Reviewed-by: Niklas Enbom <niklas.enbom@webrtc.org> Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24100}7 年前
Stop using Googletest legacy APIs. Googletest recently started replacing the term Test Case by Test Suite. From now on, the preferred API is TestSuite*; the older TestCase* API will be slowly deprecated. This CL moves WebRTC to the new set of APIs. More info in [1]. This CL has been generated with this script: declare -A items items[TYPED_TEST_CASE]=TYPED_TEST_SUITE items[TYPED_TEST_CASE_P]=TYPED_TEST_SUITE_P items[REGISTER_TYPED_TEST_CASE_P]=REGISTER_TYPED_TEST_SUITE_P items[INSTANTIATE_TYPED_TEST_CASE_P]=INSTANTIATE_TYPED_TEST_SUITE_P items[INSTANTIATE_TEST_CASE_P]=INSTANTIATE_TEST_SUITE_P for i in "${!items[@]}" do git ls-files | xargs sed -i "s/\b$i\b/${items[$i]}/g" done git cl format [1] - https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature Bug: None Change-Id: I5ae191e3046caf347aeee01554d5743548ab0e3f Reviewed-on: https://webrtc-review.googlesource.com/c/118701 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26494}7 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Organize iLBC headers as per style guide Prior to this commit, most .c files in modules/audio_coding/codecs/ilbc don't include their corresponding headers, nor do they order #includes as per the Google Style Guide [1]. The former is especially harmful, since in C it can silently allow the function signature to diverge from its prototype, thus causing disaster at runtime. This CL fixes both issues. In effect, this allows the common_audio and modules/audio_coding:ilbc targets to be compiled with Clang's -Wmissing-prototypes, though this CL does not add that change. [1]: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: webrtc:12314 Change-Id: I8299968ed3cc86ff35d9de045072b846298043af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198362 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#32896} 5 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前