文件最后提交记录最后更新时间
PipeWire capturer: make restore tokens re-usable more than one time Do not automatically remove all tokens once we attempt to use them. This mitigates an issue with Google Meet where an additional instance of a DesktopCapturer is created and destroyed right away, taking away the token we would use otherwise. Also save the token under same SourceId once we get a new (but could be same) token from the restored session. Bug: webrtc:15544 Change-Id: I565b22f5bf6a4d8a3b7d6d757f9c1046c7a0557d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322621 Commit-Queue: Jan Grulich <grulja@gmail.com> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#40892} 2 年前
Revert "mac: Work around an inccorect availability annotation in the 13.3 SDK" This reverts commit 0f87b3853554ee5d4e92e487a5165b57771b6742. This is not needed with the macOS 14 SDK, which has the fix, and which was landed in https://crrev.com/c/4875713. Bug: chromium:1484363, chromium:1431897 Change-Id: I1e019ce71b90333d5d1333a3cf8bb510a3dbd212 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/320820 Reviewed-by: Tomas Gunnarsson <tommi@google.com> Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#40777} 2 年前
Reduces rate at which TryGetNextFrame returns NULL for WGC This CL is a follow-up of work done in https://webrtc-review.googlesource.com/c/src/+/323882 where the goal was to reduce the amount of FrameDropped error logs in WebRTC.DesktopCapture.Win.WgcCaptureSessionGetFrameResult. The previous work avoids FrameDropped logs for a minimized window being captured with WGC but we still se a large amount of these error (or rather warning) logs. See [1] which comes from Canary. This CL does two different things to improve the situation: 1) It adds kFramePoolEmpty to the existing GetFrameResult::kFrameDropped enum to point out that the warning comes from the frame pool not being able to return a valid new frame. It also makes it more clear that it does not cause an outer/final error as WgcCapturerResult::kFrameDropped. We still keep the inner GetFrameResult::kFrameDropped but it is only produced when the frame pool returns NULL and our external queue is empty. Hence, a real frame-drop error. Note that, it is still easy to provoke kFramePoolEmpty simply by asking for a high resolution at a high rate. The example in [2] comes from a 4K screen @30fps. Hence, we have not fixed anything yet. 2) It also increases the size of the internal frame pool from 1 to 2. This does lead to an almost zero rate of kFramePoolEmpt warnings at the expense of a slightly reduced max capture rate. BUT, with 1 as size, we can "see" a higher max capture rate but it is not a true rate since it comes with a high rate of kFramePoolEmpty errors. Hence, we "emulate" a high capture rate by simply feeding copies of the last frame that we had stored in the external queue. Using 2 leads to a more "true" rate of what we actually can capture in terms of *new* frames and also a substantially lower rate of kFramePoolEmpty. In addition, with 1 as size, if we ask at a too high rate and provide a copy of the last frame, our CPU adaptation will not reduce its rate since we think that things are OK when it is actually not. Also, the samples in [3] and [4] both use 2 as numberOfBuffers as well. Let me also mention that with this small change, I a have not been able to provoke any kFramePoolEmpty error messages. Finally, geDisplayMedia can be called called with constraints where min and max framerate is defined. The mechanism which maintains the min rate is implemented via the RequestRefreshFrame API and it can be sent to the source (DesktopCaptureDevice) back to back with a previous timer interrupt for a capture request. Without this change, these RRFs were also a source of a large amount of kFramePoolEmpty error logs. With 2 buffers instead; this is no longer the case. [1] https://screenshot.googleplex.com/7sfv6HdGXLwyxdj [2] https://paste.googleplex.com/4795680001359872 [3] https://github.com/robmikh/Win32CaptureSample/blob/master/Win32CaptureSample/SimpleCapture.cpp [4] https://learn.microsoft.com/en-us/windows/uwp/audio-video-camera/screen-capture#add-the-screen-capture-capability (cherry picked from commit 4be5927dc788b814dff2a6ca46175254dce59232) Bug: chromium:1314868 Change-Id: I73b823b31a993fd2cd6e007b212826dfe1a80012 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/325521 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#41079} Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/326960 Commit-Queue: Henrik Andreassson <henrika@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Cr-Commit-Position: refs/branch-heads/6099@{#1} Cr-Branched-From: 507f1cc3270d0577f79882acbd78e63e66008f3d-refs/heads/main@{#41042} 2 年前
Make DesktopFrame::CreateFromCGImage() accessible for external targets The build target that CreateFromCGImage() belongs to, desktop_capture_obj is not visible externally. A utility header is created to make it accessible. Bug: chromium:1471931 Change-Id: Ie40f39114d277dc4b62fe2ce95a6b0c7b61a3943 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/318123 Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Johannes Kron <kron@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#40659} 2 年前
Revert "Split out generic portal / pipewire code" This reverts commit e6ec81a89ca904f1816b76456426babc28a9d767. Reason for revert: Assert on line 14, modules/portal/BUILD.gn breaks in downstream build. Reverting until it has been investigated. Original change's description: > Split out generic portal / pipewire code > > It will be reused by the video capture portal / pipewire backend. > > Bug: webrtc:13177 > Change-Id: Ia1a77f1c6e289149cd8a1d54b550754bf192e62e > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/263721 > Reviewed-by: Mark Foltz <mfoltz@chromium.org> > Commit-Queue: Alexander Cooper <alcooper@chromium.org> > Reviewed-by: Erik Språng <sprang@webrtc.org> > Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> > Reviewed-by: Salman Malik <salmanmalik@google.com> > Cr-Commit-Position: refs/heads/main@{#38487} Bug: webrtc:13177 Change-Id: I18deb5c78a54261f77693e7e31dba6f98f5eeb5d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/280947 Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Björn Terelius <terelius@webrtc.org> Auto-Submit: Björn Terelius <terelius@webrtc.org> Commit-Queue: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38496} 3 年前
Replace desktop_capture OWNERS alcooper@ and mfoltz@ are taking ownership of desktop_capture; while joedow@ and jamiewalch@ are no longer working in this area. Bug: chromium:1268590 Change-Id: Ie28f10ad1ef19aa428e22a6fa537a98b82c42233 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/237542 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Joe Downing <joedow@google.com> Reviewed-by: Joe Downing <joedow@chromium.org> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/main@{#35327} 4 年前
webrtc: Blank desktop capturer regards empty frame as a blank frame There is a AV where GDI capturer sends empty frame to the blank detector. It is fine operation from the GDI capturer to pass an empty to the next handler. So, blank capturer filter it and send it as blank frame to next handler. Bug: webrtc:14265 Change-Id: Ifc90a210703e14fa6d0dc7fb2ae2942ae4e8125f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268444 Reviewed-by: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#37513} 3 年前
getDisplayMedia shows black window on Youtube PiP in Windows. getDisplayMedia capture the view of the screens and windows in the capture dialog, but the issue is that captured view of the Youtube somehow is blank. It repros only in certain circumstances, for example, Canary channel. If user reinstall the Canary as fresh new, we observed that it doesn't repro. Cause: We aren't sure what's cause of this one yet. Solution: We decided to provide fallback WGC capturer when the main capturer (GDI) shows blank. WGC could show yellow outline in prior Win11 OS, but yellow outline looks better than blank. The blank detector and fallback capturer are what screen capturer already supported. So, the solution will follow similar pattern in the window capturer. Bug: webrtc:13726 Change-Id: I620c817d259d7bb5c295adab11c4444349ab1c6c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252625 Reviewed-by: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#36224} 4 年前
Fully qualify googletest symbols. Semi-automatically created with: git grep -l " testing::" | xargs sed -i "s/ testing::/ ::testing::/g" git grep -l "(testing::" | xargs sed -i "s/(testing::/(::testing::/g" git cl format After this, two .cc files failed to compile and I have fixed them manually. Bug: webrtc:10523 Change-Id: I4741d3bcedc831b6c5fdc04485678617eb4ce031 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132018 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27526}7 年前
Remove RTC_DISALLOW_COPY_AND_ASSIGN from modules/ Bug: webrtc:13555, webrtc:13082 Change-Id: I2c2cbcbd918f0cfa970c1a964893220ba11d4b41 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247960 Reviewed-by: Artem Titov <titovartem@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: (Daniel.L) Byoungchan Lee <daniel.l@hpcnt.com> Cr-Commit-Position: refs/heads/main@{#35771} 4 年前
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture Bug: webrtc:12338 Change-Id: I300ba78fc4423db7030e555d7e51d2cb2246e9a4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227162 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34678} 4 年前
Make CroppedWindowCapturer more resilient Bug: chromium:1245272 Change-Id: I276c98ad0aea3dd0e614b935b9a7566c77d5026a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233720 Reviewed-by: Joe Downing <joedow@chromium.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35132} 4 年前
Make CroppedWindowCapturer more resilient Bug: chromium:1245272 Change-Id: I276c98ad0aea3dd0e614b935b9a7566c77d5026a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233720 Reviewed-by: Joe Downing <joedow@chromium.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35132} 4 年前
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture Bug: webrtc:12338 Change-Id: I300ba78fc4423db7030e555d7e51d2cb2246e9a4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227162 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34678} 4 年前
Fix WebRTC.Screenshare.DesktopCapturerFullscreenDetector logging issue The histogram WebRTC.Screenshare.DesktopCapturerFullscreenDetector incorrectly counted every time a presentation application was shared instead of only counting sessions where the presentation was presented in fullscreen. This bug affected Windows, macOS works as intended. Bug: chromium:1348011 Change-Id: I9e84e9d1f4310703ba94e2af2e35a52d74a25842 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/293461 Commit-Queue: Johannes Kron <kron@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39314} 3 年前
Add Observer for delegated source list events Adds an Observer class to the DelegatedSourceListController so that we can expose user-driven events from the delegated source list. This will allow embedders to update their UI in response to changes to the state from the delegated source list. Currently these events are: selection, cancelled, and error. Bug: chromium:1351576, chromium:1351577 Change-Id: I248bdb1c4410147ca1a0663eafda40b6b9345801 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/272622 Reviewed-by: Mark Foltz <mfoltz@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#37986} 3 年前
Adds debug logs which warns about cursor flickering Main issue is https://chromium-review.googlesource.com/c/chromium/src/+/4507078 Bug: chromium:1421656 Change-Id: I61c6df59176e10bc29356ea924a4e483270db75f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304284 Reviewed-by: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Henrik Andreassson <henrika@webrtc.org> Cr-Commit-Position: refs/heads/main@{#40038} 2 年前
base_capturer_pipewire: Send frames via callback Earlier, we were relying on CRD to periodically do frame captures. This is however not needed since Wayland captures are event based and once the compositor has send the event/frame to us, we can just handover the frame to a registered callback. This ensures that we have a single frame clock that (i.e. one present in the compositor). Without this change, there is a chance that CRD capture clock is run out of sync with the compositor's clock and cause unnecessary frame delays. See the following ideal scenario, for example, where '+' indicates when a frame is sent by the compositor and when CRD tries to capture it. This assumes that the same clock cycle for both CRD and the compositor, each cycle length is enclosed within | .... |). Compositor Frame Ready | +... | | +... | CRD Frame Capture | .+.. | | .+.. | In this case, when both the clocks are in sync, CRD is able to capture frame right after it is generated by the compositor. But if they are completely out of sync, then CRD can always see a stale frame (delayed by one cycle and it can cause users to feel stutter). Compositor Frame Ready | .+.. | | .+.. | CRD Frame Capture | +... | | +... | This stutter can become worse if the compositor is delayed in generating the frames for some reason (e.g. load on the system). Bug: chromium:1291247 Change-Id: I7c10c724fbbd87dc523d474e7ece8e8aa146fd7b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291080 Reviewed-by: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Salman Malik <salmanmalik@chromium.org> Cr-Commit-Position: refs/heads/main@{#39218} 3 年前
Fix clearing of mouse cursor if display uses a scale factor When a display uses a scale factor (different than 1.0) the previous cursor position is not properly cleared during a CRD connection on ChromeOS (see b/235191365). The issue was that the fix for crbug.com/1323241 does not take device scaling into account, so that fix would incorrectly not mark the previous location of the mouse cursor as modified. Adding proper boundary checks is hard and risky though, as the way the position of the mouse cursor is reported seems to be platform dependent (ChromeOS vs Linux vs ...). So because crbug.com/1323241 only solves a theoretical crash that is rarely if ever hit in the field, I decided to for now undo the fix for crbug.com/1323241. A proper boundary check can then later be introduced without any pressure from a looming release Bug: chromium:1323241 Bug: b/235191365 Fixed: b/235191365 Test: Manually deployed Change-Id: Ib09b6cc5e396bd52538332edfc4395ed80c6786e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265391 Reviewed-by: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Joe Downing <joedow@google.com> Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/main@{#37274} 3 年前
Reland "Split out generic portal / pipewire code" This is a reland of commit e6ec81a89ca904f1816b76456426babc28a9d767 Updated to ensure that the portal code can be built with is_chromeos. Original change's description: > Split out generic portal / pipewire code > > It will be reused by the video capture portal / pipewire backend. > > Bug: webrtc:13177 > Change-Id: Ia1a77f1c6e289149cd8a1d54b550754bf192e62e > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/263721 > Reviewed-by: Mark Foltz <mfoltz@chromium.org> > Commit-Queue: Alexander Cooper <alcooper@chromium.org> > Reviewed-by: Erik Språng <sprang@webrtc.org> > Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> > Reviewed-by: Salman Malik <salmanmalik@google.com> > Cr-Commit-Position: refs/heads/main@{#38487} Bug: webrtc:13177 Change-Id: I2c890c83c86ad60fa30f63dcf6fa90510d46009e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/281661 Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#38620} 3 年前
Removes usage of the Magnifier API on Windows This CL removes the usage of the Magnifier screen capture API on Windows. The idea is to remove the actual source in a second step once this change lands. Bug: chromium:1428341 Change-Id: Id2cb25632c7edbea2cf527959b14b27ee00b0e56 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301164 Commit-Queue: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#39856} 3 年前
Add telemetry to measure usage, perf, and errors in Desktop Capturers. As part of adding the new WgcCapturerWin implementation of the DesktopCapturer interface, we should ensure that we can measure the health and success of this new code. In order to quantify that, I've added telemetry to measure the usage of each capturer implementation, the time taken to capture a frame, and any errors that are encountered in the new implementation. I've also set the capturer id property of frames so that we can measure error rates and performance of each implementation in Chromium as well. This CL must be completed after this Chromium CL lands: 2806094: Add histograms to record new WebRTC DesktopCapturer telemetry | https://chromium-review.googlesource.com/c/chromium/src/+/2806094 Bug: webrtc:9273 Change-Id: I33b0a008568a4df4f95e705271badc3313872f17 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214060 Commit-Queue: Austin Orion <auorion@microsoft.com> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#33716} 5 年前
Move rtc::make_ref_counted to api/ Bug: webrtc:12701 Change-Id: If49095b101c1a1763c2a44a0284c0d670cce953f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265390 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37219} 3 年前
Removes AllowWgcDesktopCapturer feature flag This flag is no longer used in Chrome and can now be removed. Bug: chromium:1314868 Change-Id: Id91b3352dc7ec0543d54894cc206a6e0c7667e9e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/309960 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#40337} 2 年前
Desktop capture: introduce capturer requesting both screen and windows When PipeWire and xdg-desktop-portals are used, we can actually combine both source types into one request. Make this part of the API for those who want to use it this way, e.g. Firefox or Electron, otherwise they will end up making two simultaneous requests, resulting into two dialogs at the same time asking, while they can be combined into just one. Bug: webrtc:15363 Change-Id: Ib6e1e47f66cb01d5c65096aec378b44c3af5f387 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/311549 Reviewed-by: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Jan Grulich <grulja@gmail.com> Cr-Commit-Position: refs/heads/main@{#40425} 2 年前
Desktop capture: introduce capturer requesting both screen and windows When PipeWire and xdg-desktop-portals are used, we can actually combine both source types into one request. Make this part of the API for those who want to use it this way, e.g. Firefox or Electron, otherwise they will end up making two simultaneous requests, resulting into two dialogs at the same time asking, while they can be combined into just one. Bug: webrtc:15363 Change-Id: Ib6e1e47f66cb01d5c65096aec378b44c3af5f387 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/311549 Reviewed-by: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Jan Grulich <grulja@gmail.com> Cr-Commit-Position: refs/heads/main@{#40425} 2 年前
Desktop capture: introduce capturer requesting both screen and windows When PipeWire and xdg-desktop-portals are used, we can actually combine both source types into one request. Make this part of the API for those who want to use it this way, e.g. Firefox or Electron, otherwise they will end up making two simultaneous requests, resulting into two dialogs at the same time asking, while they can be combined into just one. Bug: webrtc:15363 Change-Id: Ib6e1e47f66cb01d5c65096aec378b44c3af5f387 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/311549 Reviewed-by: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Jan Grulich <grulja@gmail.com> Cr-Commit-Position: refs/heads/main@{#40425} 2 年前
wayland: Add a common interface for screencast and remote desktop portal Change adapts the base_capturer_pipewire so that a portal can be injected in the capturer. This allows the remoting to inject its own portal for the purpose of capturing desktop stream as long as the injected portal provides implementation of the new interface that is added as part of this change. Additionally, a method has been exposed on the capturer to get details about the portal session so that the remoting implementation can use the same underlying session for controlling inputs on the remote host. Finally, desktop capturer interface is extended with a generic method GetMetadata that is used to retrieve session related information by CRD and relay it over to its input injector. Clients provide override for the method and it eventually invokes the underlying GetSessionDetails method on the portal instance. Bug: chromium:1291247 Change-Id: I0dbd154eb16d4149f967c4a818eea51e7e6eb9a9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257000 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Salman Malik <salmanmalik@google.com> Cr-Commit-Position: refs/heads/main@{#36399} 4 年前
wayland: Add a common interface for screencast and remote desktop portal Change adapts the base_capturer_pipewire so that a portal can be injected in the capturer. This allows the remoting to inject its own portal for the purpose of capturing desktop stream as long as the injected portal provides implementation of the new interface that is added as part of this change. Additionally, a method has been exposed on the capturer to get details about the portal session so that the remoting implementation can use the same underlying session for controlling inputs on the remote host. Finally, desktop capturer interface is extended with a generic method GetMetadata that is used to retrieve session related information by CRD and relay it over to its input injector. Clients provide override for the method and it eventually invokes the underlying GetSessionDetails method on the portal instance. Bug: chromium:1291247 Change-Id: I0dbd154eb16d4149f967c4a818eea51e7e6eb9a9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257000 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Salman Malik <salmanmalik@google.com> Cr-Commit-Position: refs/heads/main@{#36399} 4 年前
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture Bug: webrtc:12338 Change-Id: I300ba78fc4423db7030e555d7e51d2cb2246e9a4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227162 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34678} 4 年前
Implement DesktopCapturerWrapper and CaptureResultDesktopCapturerWrapper Wrapper pattern is widely used in DesktopCapturer implementations. So this change adds DesktopCapturerWrapper and CaptureResultDesktopCapturerWrapper as the base classes of other wrappers. Implementing a new wrapper should become easy, the implementation does not need to care about the uninteresting overrides. Bug: chromium:764258 Change-Id: If91c1b5e778805906f7f77854ea5600aa61bf64a Reviewed-on: https://webrtc-review.googlesource.com/1420 Commit-Queue: Zijie He <zijiehe@google.com> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#19868}8 年前
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2. This is a follow-up to https://webrtc-review.googlesource.com/c/src/+/106280. This time the whole code base is covered. Some files may have not been fixed though, whenever the IWYU tool was breaking the build. Bug: webrtc:8311 Change-Id: I2c31f552a87e887d33931d46e87b6208b1e483ef Reviewed-on: https://webrtc-review.googlesource.com/c/111965 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25830}7 年前
DXGI now consumes may_contain_cursor Before: No attempt was made to figure out of the cursor was embedded into the captured video frame when using DXGI on Windows as screen capturer. Instead the cursor is superimposed on the frame by an external mouse and cursor composer. After: We now check if the display adapter supports embedding the mouse cursor and if so use it as is and thereby avoid adding it independently. Bug: chromium:1421656 Change-Id: Ie07fe13e1c8f9583769961328bb41fbc689cd8e0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/299241 Reviewed-by: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Henrik Andreassson <henrika@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39742} 3 年前
Adds SetFrameDataToBlack() and FrameDataIsBlack() to DesktopFrame Bug: None Change-Id: I558b2398de409b0b44f331520e3d4692e45b9315 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/296884 Reviewed-by: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Henrik Andreassson <henrika@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39537} 3 年前
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture Bug: webrtc:12338 Change-Id: I300ba78fc4423db7030e555d7e51d2cb2246e9a4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227162 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34678} 4 年前
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture Bug: webrtc:12338 Change-Id: I300ba78fc4423db7030e555d7e51d2cb2246e9a4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227162 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34678} 4 年前
Prepare to rename RTC_NOTREACHED to RTC_DCHECK_NOTREACHED Add implementation of RTC_DCHECK_NOTREACHED equal to the RTC_NOTREACHED. The new macros will replace the old one when old one's usage will be removed. The idea of the renaming to provide a clear signal that this is debug build only macros and will be stripped in the production build. Bug: webrtc:9065 Change-Id: I4c35d8b03e74a4b3fd1ae75dba2f9c05643101db Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/237802 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35348} 4 年前
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture Bug: webrtc:12338 Change-Id: I300ba78fc4423db7030e555d7e51d2cb2246e9a4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227162 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34678} 4 年前
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2. This is a follow-up to https://webrtc-review.googlesource.com/c/src/+/106280. This time the whole code base is covered. Some files may have not been fixed though, whenever the IWYU tool was breaking the build. Bug: webrtc:8311 Change-Id: I2c31f552a87e887d33931d46e87b6208b1e483ef Reviewed-on: https://webrtc-review.googlesource.com/c/111965 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25830}7 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Handle SharedMemory allocation failures CreateSharedMemory is allowed to return nullptr if memory can't be allocated but DesktopFrameWin didn't check to ensure was allocated before accessing it. This CL just adds a null check, logs a warning, and returns nullptr which is already done lower in the function and the error is correctly handled in the screen and window capturers which call DesktopFrameWin::Create(). Bug: chromium:1251651 Change-Id: Ie9231f03ba9c7a96823af986b9df38f97fcb682c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232663 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/main@{#35072} 4 年前
Reland "Remove RTC_DISALLOW_COPY_AND_ASSIGN usages completely" This reverts commit 3f87250a4f0e6c69002fbcdfb995b0dfcd7bf710. Reason for revert: Downstream is fixed Original change's description: > Revert "Remove RTC_DISALLOW_COPY_AND_ASSIGN usages completely" > > This reverts commit 5f0eb93d2a44cec2102fc8c3757d5bb814bd145f. > > Reason for revert: Breaks downstream project. I'm going to fix that one and create a reland of this CL after. > > Original change's description: > > Remove RTC_DISALLOW_COPY_AND_ASSIGN usages completely > > > > Bug: webrtc:13555, webrtc:13082 > > Change-Id: Iff2cda6f516739419e97e975e03f77a98f74be03 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249260 > > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > > Reviewed-by: Artem Titov <titovartem@webrtc.org> > > Commit-Queue: (Daniel.L) Byoungchan Lee <daniel.l@hpcnt.com> > > Cr-Commit-Position: refs/heads/main@{#35805} > > TBR=hta@webrtc.org,titovartem@webrtc.org,daniel.l@hpcnt.com,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: I33d497f1132adfe6d151023195a388d9b7d548f9 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:13555, webrtc:13082 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249364 > Reviewed-by: Artem Titov <titovartem@webrtc.org> > Owners-Override: Artem Titov <titovartem@webrtc.org> > Reviewed-by: Andrey Logvin <landrey@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Commit-Queue: Artem Titov <titovartem@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#35807} # Not skipping CQ checks because this is a reland. Bug: webrtc:13555, webrtc:13082 Change-Id: I7ef1ef3b6e3c41b1a96014aa75f003c0fcf33949 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249365 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35814} 4 年前
Include menus & dialogs in frames captured by WindowCapturerWin This change adds logic to WindowCapturerWin to capture overlapping owned/pop-up windows (e.g. menus, dialogs, tooltips). This makes window capture behavior more consistent regardless of whether CroppingWindowCapturerWin is used & its conditions for using crop-from- screen capture are met (in ShouldUseScreenCapturer). (I.e. regardless of OS version, window shape / translucency, occlusion by another potentially top-most window, or whether the capturing app has opted in to using the cropping capturer). Owned/pop-up windows associated with the selected window are enumerated then captured individually, with their contents composited into the final frame. This change also: - Crops out the top window border (which exposed a bit of the background when using the cropping capturer, and resulted in an inconsistent appearance compared to the side & bottom borders being cropped out). Bug: chromium:980864 Change-Id: I81c504848a0c0e6bf122aeff437b400e44944718 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148302 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#28922} 6 年前
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture Bug: webrtc:12338 Change-Id: I300ba78fc4423db7030e555d7e51d2cb2246e9a4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227162 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34678} 4 年前
Fixing WebRTC after moving from src/webrtc to src/ In https://webrtc-review.googlesource.com/c/src/+/1560 we moved WebRTC from src/webrtc to src/ (in order to preserve an healthy git history). This CL takes care of fixing header guards, #include paths, etc... NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=tommi@webrtc.org Bug: chromium:611808 Change-Id: Iea91618212bee0af16aa3f05071eab8f93706578 Reviewed-on: https://webrtc-review.googlesource.com/1561 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19846}8 年前
Use backticks not vertical bars to denote variables in comments Bug: webrtc:12338 Change-Id: I89c8b3a328d04203177522cbdfd9e606fd4bce4c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228246 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34696} 4 年前
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture Bug: webrtc:12338 Change-Id: I300ba78fc4423db7030e555d7e51d2cb2246e9a4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227162 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34678} 4 年前
Format almost everything. This CL was generated by running git ls-files | grep -P "(\.h|\.cc)$" | grep -v 'sdk/' | grep -v 'rtc_base/ssl_' | \ grep -v 'fake_rtc_certificate_generator.h' | grep -v 'modules/audio_device/win/' | \ grep -v 'system_wrappers/source/clock.cc' | grep -v 'rtc_base/trace_event.h' | \ grep -v 'modules/audio_coding/codecs/ilbc/' | grep -v 'screen_capturer_mac.h' | \ grep -v 'spl_inl_mips.h' | grep -v 'data_size_unittest.cc' | grep -v 'timestamp_unittest.cc' \ | xargs clang-format -i ; git cl format Most of these changes are clang-format grouping and reordering includes differently. Bug: webrtc:9340 Change-Id: Ic83ddbc169bfacd21883e381b5181c3dd4fe8a63 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144051 Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28505} 6 年前
Conditionally include differ_vector_sse2.h only when on x86 platforms. Bug: None Change-Id: Ie2890c23e764a06109a706e07f4cba4da5e36cd2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273820 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#37983} 3 年前
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture Bug: webrtc:12338 Change-Id: I300ba78fc4423db7030e555d7e51d2cb2246e9a4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227162 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34678} 4 年前
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2. This is a follow-up to https://webrtc-review.googlesource.com/c/src/+/106280. This time the whole code base is covered. Some files may have not been fixed though, whenever the IWYU tool was breaking the build. Bug: webrtc:8311 Change-Id: I2c31f552a87e887d33931d46e87b6208b1e483ef Reviewed-on: https://webrtc-review.googlesource.com/c/111965 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25830}7 年前
Reformat the WebRTC code base Running clang-format with chromium's style guide. The goal is n-fold: * providing consistency and readability (that's what code guidelines are for) * preventing noise with presubmit checks and git cl format * building on the previous point: making it easier to automatically fix format issues * you name it Please consider using git-hyper-blame to ignore this commit. Bug: webrtc:9340 Change-Id: I694567c4cdf8cee2860958cfe82bfaf25848bb87 Reviewed-on: https://webrtc-review.googlesource.com/81185 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23660}7 年前
Fixing WebRTC after moving from src/webrtc to src/ In https://webrtc-review.googlesource.com/c/src/+/1560 we moved WebRTC from src/webrtc to src/ (in order to preserve an healthy git history). This CL takes care of fixing header guards, #include paths, etc... NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=tommi@webrtc.org Bug: chromium:611808 Change-Id: Iea91618212bee0af16aa3f05071eab8f93706578 Reviewed-on: https://webrtc-review.googlesource.com/1561 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19846}8 年前
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture Bug: webrtc:12338 Change-Id: I300ba78fc4423db7030e555d7e51d2cb2246e9a4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227162 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34678} 4 年前
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture Bug: webrtc:12338 Change-Id: I300ba78fc4423db7030e555d7e51d2cb2246e9a4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227162 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34678} 4 年前
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture Bug: webrtc:12338 Change-Id: I300ba78fc4423db7030e555d7e51d2cb2246e9a4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227162 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34678} 4 年前
Revert "Desktop capturer: Add OnDisplayChanged callback" This reverts commit d1208c26b1cdb536fdec942207033711101d5d26. Reason for revert: This cl causes the crashing issue as in chromium:916961 at starting desktop capture on Windows. Original change's description: > Desktop capturer: Add OnDisplayChanged callback > > This adds support for a new DesktopCapturer::Callback method > OnDisplayChanged that is sent at the start of a desktop capture > session and whenever the display geometry changes. > > This cl adds the basic structure to call this api at the start > of the capture session. Currently Windows only. > > A follow-up cl will add support to call this whenever the display > geometry changes. > > Bug: webrtc:10122, chromium:915411 > Change-Id: Ie7283be5992454180daab1a60f58a3b2efdfed56 > Reviewed-on: https://webrtc-review.googlesource.com/c/114020 > Commit-Queue: Gary Kacmarcik <garykac@chromium.org> > Reviewed-by: Brave Yao <braveyao@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#26053} TBR=jamiewalch@chromium.org,braveyao@webrtc.org,braveyao@chromium.org,garykac@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:10122, chromium:915411, chromium:916961 Change-Id: Id0471e01bb90bb5accdf58262ae2b130cf343ecd Reviewed-on: https://webrtc-review.googlesource.com/c/115433 Commit-Queue: Brave Yao <braveyao@webrtc.org> Reviewed-by: Brave Yao <braveyao@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26095}7 年前
Format almost everything. This CL was generated by running git ls-files | grep -P "(\.h|\.cc)$" | grep -v 'sdk/' | grep -v 'rtc_base/ssl_' | \ grep -v 'fake_rtc_certificate_generator.h' | grep -v 'modules/audio_device/win/' | \ grep -v 'system_wrappers/source/clock.cc' | grep -v 'rtc_base/trace_event.h' | \ grep -v 'modules/audio_coding/codecs/ilbc/' | grep -v 'screen_capturer_mac.h' | \ grep -v 'spl_inl_mips.h' | grep -v 'data_size_unittest.cc' | grep -v 'timestamp_unittest.cc' \ | xargs clang-format -i ; git cl format Most of these changes are clang-format grouping and reordering includes differently. Bug: webrtc:9340 Change-Id: Ic83ddbc169bfacd21883e381b5181c3dd4fe8a63 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144051 Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28505} 6 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Remove RTC_DISALLOW_COPY_AND_ASSIGN from modules/ Bug: webrtc:13555, webrtc:13082 Change-Id: I2c2cbcbd918f0cfa970c1a964893220ba11d4b41 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247960 Reviewed-by: Artem Titov <titovartem@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: (Daniel.L) Byoungchan Lee <daniel.l@hpcnt.com> Cr-Commit-Position: refs/heads/main@{#35771} 4 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Remove RTC_DISALLOW_COPY_AND_ASSIGN from modules/ Bug: webrtc:13555, webrtc:13082 Change-Id: I2c2cbcbd918f0cfa970c1a964893220ba11d4b41 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247960 Reviewed-by: Artem Titov <titovartem@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: (Daniel.L) Byoungchan Lee <daniel.l@hpcnt.com> Cr-Commit-Position: refs/heads/main@{#35771} 4 年前
Fixing WebRTC after moving from src/webrtc to src/ In https://webrtc-review.googlesource.com/c/src/+/1560 we moved WebRTC from src/webrtc to src/ (in order to preserve an healthy git history). This CL takes care of fixing header guards, #include paths, etc... NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=tommi@webrtc.org Bug: chromium:611808 Change-Id: Iea91618212bee0af16aa3f05071eab8f93706578 Reviewed-on: https://webrtc-review.googlesource.com/1561 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19846}8 年前
Remove RTC_DISALLOW_COPY_AND_ASSIGN from modules/ Bug: webrtc:13555, webrtc:13082 Change-Id: I2c2cbcbd918f0cfa970c1a964893220ba11d4b41 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247960 Reviewed-by: Artem Titov <titovartem@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: (Daniel.L) Byoungchan Lee <daniel.l@hpcnt.com> Cr-Commit-Position: refs/heads/main@{#35771} 4 年前
Replace assert() with RTC_DCHECK(). CL partially auto-generated with: git grep -l "\bassert(" | grep "\.[c|h]" | \ xargs sed -i 's/\bassert(/RTC_DCHECK(/g' And with: git grep -l "RTC_DCHECK(false)" | \ xargs sed -i 's/RTC_DCHECK(false)/RTC_NOTREACHED()/g' With some manual changes to include "rtc_base/checks.h" where needed. A follow-up CL will remove assert() from Obj-C code as well and remove the #include of <assert.h>. The choice to replace with RTC_DCHECK is because assert() is because RTC_DCHECK has similar behavior as assert() based on NDEBUG. This CL also contains manual changes to switch from basic RTC_DCHECK to other (preferred) versions like RTC_DCHECK_GT (and similar). Bug: webrtc:6779 Change-Id: I00bed8886e03d685a2f42324e34aef2c9b7a63b0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/224846 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34442} 4 年前
Remove RTC_DISALLOW_COPY_AND_ASSIGN from modules/ Bug: webrtc:13555, webrtc:13082 Change-Id: I2c2cbcbd918f0cfa970c1a964893220ba11d4b41 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247960 Reviewed-by: Artem Titov <titovartem@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: (Daniel.L) Byoungchan Lee <daniel.l@hpcnt.com> Cr-Commit-Position: refs/heads/main@{#35771} 4 年前
mouse_cursor_monitor: Annotate a method with RTC_EXPORT This is used by CRD and export is required for component builds to work properly. Bug: chromium:1291247 Change-Id: I281e490b7d00cbd074b96eac905976af38400f8b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291200 Reviewed-by: Alexander Cooper <alcooper@chromium.org> Auto-Submit: Salman Malik <salmanmalik@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Salman Malik <salmanmalik@chromium.org> Cr-Commit-Position: refs/heads/main@{#39143} 3 年前
Implement MouseCursorMonitorPipeWire to track cursor changes separately Current implementation has mouse cursor as part of the screen itself which means that everytime a cursor changes location, we have to update whole screen content, which brings unnecessary load overhead. Using our own mouse cursor monitor implementation allows us to track only mouse cursor changes and update them separately for much better performance. Bug: webrtc:13429 Change-Id: I224e9145f0bc7e45eafe4490de160f2ad4c8b545 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244507 Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Mark Foltz <mfoltz@chromium.org> Commit-Queue: Mark Foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/main@{#36011} 4 年前
Initialize last_cursor_ This ensures that last_cursor_ is intialized before it is checked. This code is in the Firefox repo with the original review here: https://phabricator.services.mozilla.com/D113833 Bug: webrtc:13481 Change-Id: I806009cba1aba193ab12bb86e39f98c56043000f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239725 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Commit-Queue: Stefan Holmer <stefan@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35509} 4 年前
Format almost everything. This CL was generated by running git ls-files | grep -P "(\.h|\.cc)$" | grep -v 'sdk/' | grep -v 'rtc_base/ssl_' | \ grep -v 'fake_rtc_certificate_generator.h' | grep -v 'modules/audio_device/win/' | \ grep -v 'system_wrappers/source/clock.cc' | grep -v 'rtc_base/trace_event.h' | \ grep -v 'modules/audio_coding/codecs/ilbc/' | grep -v 'screen_capturer_mac.h' | \ grep -v 'spl_inl_mips.h' | grep -v 'data_size_unittest.cc' | grep -v 'timestamp_unittest.cc' \ | xargs clang-format -i ; git cl format Most of these changes are clang-format grouping and reordering includes differently. Bug: webrtc:9340 Change-Id: Ic83ddbc169bfacd21883e381b5181c3dd4fe8a63 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144051 Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28505} 6 年前
Remove all #include <assert.h>/<cassert> and usage in Obj-C code. This CL completes the removal of assert() and relative headers from the codebase (excluded //examples/objc/AppRTCMobile/third_party/SocketRocket which is in a third_party sub-directory). Bug: webrtc:6779 Change-Id: I93ed57168d2c0e011626873d66529488c5f484f2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/225546 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34528} 4 年前
Fixing WebRTC after moving from src/webrtc to src/ In https://webrtc-review.googlesource.com/c/src/+/1560 we moved WebRTC from src/webrtc to src/ (in order to preserve an healthy git history). This CL takes care of fixing header guards, #include paths, etc... NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=tommi@webrtc.org Bug: chromium:611808 Change-Id: Iea91618212bee0af16aa3f05071eab8f93706578 Reviewed-on: https://webrtc-review.googlesource.com/1561 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19846}8 年前
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture Bug: webrtc:12338 Change-Id: I300ba78fc4423db7030e555d7e51d2cb2246e9a4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227162 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34678} 4 年前
Format almost everything. This CL was generated by running git ls-files | grep -P "(\.h|\.cc)$" | grep -v 'sdk/' | grep -v 'rtc_base/ssl_' | \ grep -v 'fake_rtc_certificate_generator.h' | grep -v 'modules/audio_device/win/' | \ grep -v 'system_wrappers/source/clock.cc' | grep -v 'rtc_base/trace_event.h' | \ grep -v 'modules/audio_coding/codecs/ilbc/' | grep -v 'screen_capturer_mac.h' | \ grep -v 'spl_inl_mips.h' | grep -v 'data_size_unittest.cc' | grep -v 'timestamp_unittest.cc' \ | xargs clang-format -i ; git cl format Most of these changes are clang-format grouping and reordering includes differently. Bug: webrtc:9340 Change-Id: Ic83ddbc169bfacd21883e381b5181c3dd4fe8a63 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144051 Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28505} 6 年前
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture Bug: webrtc:12338 Change-Id: I300ba78fc4423db7030e555d7e51d2cb2246e9a4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227162 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34678} 4 年前
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2. This is a follow-up to https://webrtc-review.googlesource.com/c/src/+/106280. This time the whole code base is covered. Some files may have not been fixed though, whenever the IWYU tool was breaking the build. Bug: webrtc:8311 Change-Id: I2c31f552a87e887d33931d46e87b6208b1e483ef Reviewed-on: https://webrtc-review.googlesource.com/c/111965 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25830}7 年前
Remove unused headers ScreenCaptureFrameQueue I've added the proper headers to the only file in Chromium which includes screen_capture_frame_queue.h (see https://chromium-review.googlesource.com/c/chromium/src/+/3836317). I've also built the remoting host and Chrome on Windows and Linux with this change and did not see any build errors. The only build error I encountered was in shared_screencast_stream when building webrtc so I added the required header there. Bug: webrtc:14378 Change-Id: Ie88e606dfa52f18514a87b87e5904424543d7df3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271922 Commit-Queue: Joe Downing <joedow@google.com> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#37811} 3 年前
Can use the given IOSurfaceRef to reach higher capture framerate on Mac The given IOSurfaceRef was ignored until now. Wrap it into the new DesktopFrameIOSurface. The new DesktopFrameProvider object is there to manage them as it has to be done per display id. From initial measurement this speed-up the frame capture by 2. Disabled by default for now but it can be enabled by calling options.set_use_iosurface. This CL will allow to do some advanced tests. Bug: webrtc:8652 Change-Id: Ia9ac0b69b30098774941cb378804b45cb1710119 Reviewed-on: https://webrtc-review.googlesource.com/33014 Commit-Queue: Zijie He <zijiehe@chromium.org> Reviewed-by: Zijie He <zijiehe@chromium.org> Cr-Commit-Position: refs/heads/master@{#22801}7 年前
Reland "[fuchsia] remove Scenic/UseFlatland dependency in DesktopCapturer" This reverts commit 726992d7a4722b8a283d797d04432d0c6335ca96. Reason for revert: Relanding with original errors fixed (tested by building the patch locally against Chromium) This change no longer attempts to migrate the display size protocol from fuchsia.ui.scenic.Scenic/GetDisplayInfo to fuchsia.ui.display.singleton.Info/GetMetrics because the latter API was introduced in Fuchsia API 12, which is not yet supported in Chrome (hence some of the build errors causing the revert). Original change's description: > Revert "[fuchsia] remove Scenic and GFX dependencies in DesktopCapturer" > > This reverts commit fe5be2eb4ff8dccd96257fb8cbf32500c636c358. > > Reason for revert: This breaks the WebRTC roll into Chromium: > > - https://chromium-review.googlesource.com/c/chromium/src/+/4688561 > - https://ci.chromium.org/ui/p/chromium/builders/try/fuchsia-binary-size/399140/overview > > Error: > > [4273/4389] CXX obj/third_party/webrtc/modules/desktop_capture/desktop_capture/screen_capturer_fuchsia.o > FAILED: obj/third_party/webrtc/modules/desktop_capture/desktop_capture/screen_capturer_fuchsia.o > ../../buildtools/reclient/rewrapper -cfg=../../buildtools/reclient_cfgs/chromium-browser-clang/rewra...(too long) > ../../third_party/webrtc/modules/desktop_capture/screen_capturer_fuchsia.cc:59:10: error: use of undeclared identifier 'capturer' > 59 | return capturer(new ScreenCapturerFuchsia()); > | ^ > ../../third_party/webrtc/modules/desktop_capture/screen_capturer_fuchsia.cc:199:36: error: no type named 'InfoSyncPtr' in namespace 'fuchsia::ui::display::singleton' > > Original change's description: > > [fuchsia] remove Scenic and GFX dependencies in DesktopCapturer > > > > We previously used: > > - fuchsia.ui.scenic.Scenic/UsesFlatland to determine whether to use > > Flatland; from now on it should always be the case, so this check is > > no longer necessary. > > - fuchsia.ui.scenic.Scenic/GetDisplayInfo to get > > fuchsia.ui.gfx.DisplayInfo. This has been migrated to > > fuchsia.ui.display.singleton.Info/GetMetrics and > > fuchsia.ui.display.singleton.Metrics. > > > > Bug: fuchsia:100303 > > Change-Id: I147da9ffdf0ca49e1c5bde5d188e434fc660becc > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/311860 > > Reviewed-by: Emircan Uysaler <emircan@google.com> > > Reviewed-by: Alexander Cooper <alcooper@chromium.org> > > Commit-Queue: Caroline Liu <carolineliu@google.com> > > Cr-Commit-Position: refs/heads/main@{#40432} > > Bug: fuchsia:100303, b/291393959 > Change-Id: Iae70e568a8c9819e40e48069af8cea0d4ef2b6c5 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/311801 > Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#40436} Bug: fuchsia:100303, b/291393959 Change-Id: Icb7074ac86c1804ab2bdf809ea1496539ee2bf80 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/312000 Commit-Queue: Caroline Liu <carolineliu@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#40452} 2 年前
Reland "[fuchsia] remove Scenic/UseFlatland dependency in DesktopCapturer" This reverts commit 726992d7a4722b8a283d797d04432d0c6335ca96. Reason for revert: Relanding with original errors fixed (tested by building the patch locally against Chromium) This change no longer attempts to migrate the display size protocol from fuchsia.ui.scenic.Scenic/GetDisplayInfo to fuchsia.ui.display.singleton.Info/GetMetrics because the latter API was introduced in Fuchsia API 12, which is not yet supported in Chrome (hence some of the build errors causing the revert). Original change's description: > Revert "[fuchsia] remove Scenic and GFX dependencies in DesktopCapturer" > > This reverts commit fe5be2eb4ff8dccd96257fb8cbf32500c636c358. > > Reason for revert: This breaks the WebRTC roll into Chromium: > > - https://chromium-review.googlesource.com/c/chromium/src/+/4688561 > - https://ci.chromium.org/ui/p/chromium/builders/try/fuchsia-binary-size/399140/overview > > Error: > > [4273/4389] CXX obj/third_party/webrtc/modules/desktop_capture/desktop_capture/screen_capturer_fuchsia.o > FAILED: obj/third_party/webrtc/modules/desktop_capture/desktop_capture/screen_capturer_fuchsia.o > ../../buildtools/reclient/rewrapper -cfg=../../buildtools/reclient_cfgs/chromium-browser-clang/rewra...(too long) > ../../third_party/webrtc/modules/desktop_capture/screen_capturer_fuchsia.cc:59:10: error: use of undeclared identifier 'capturer' > 59 | return capturer(new ScreenCapturerFuchsia()); > | ^ > ../../third_party/webrtc/modules/desktop_capture/screen_capturer_fuchsia.cc:199:36: error: no type named 'InfoSyncPtr' in namespace 'fuchsia::ui::display::singleton' > > Original change's description: > > [fuchsia] remove Scenic and GFX dependencies in DesktopCapturer > > > > We previously used: > > - fuchsia.ui.scenic.Scenic/UsesFlatland to determine whether to use > > Flatland; from now on it should always be the case, so this check is > > no longer necessary. > > - fuchsia.ui.scenic.Scenic/GetDisplayInfo to get > > fuchsia.ui.gfx.DisplayInfo. This has been migrated to > > fuchsia.ui.display.singleton.Info/GetMetrics and > > fuchsia.ui.display.singleton.Metrics. > > > > Bug: fuchsia:100303 > > Change-Id: I147da9ffdf0ca49e1c5bde5d188e434fc660becc > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/311860 > > Reviewed-by: Emircan Uysaler <emircan@google.com> > > Reviewed-by: Alexander Cooper <alcooper@chromium.org> > > Commit-Queue: Caroline Liu <carolineliu@google.com> > > Cr-Commit-Position: refs/heads/main@{#40432} > > Bug: fuchsia:100303, b/291393959 > Change-Id: Iae70e568a8c9819e40e48069af8cea0d4ef2b6c5 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/311801 > Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#40436} Bug: fuchsia:100303, b/291393959 Change-Id: Icb7074ac86c1804ab2bdf809ea1496539ee2bf80 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/312000 Commit-Queue: Caroline Liu <carolineliu@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#40452} 2 年前
Format /modules git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jared Siskin <jtsiskin@meta.com> Cr-Commit-Position: refs/heads/main@{#39901} 3 年前
Remove RTC_DISALLOW_COPY_AND_ASSIGN from modules/ Bug: webrtc:13555, webrtc:13082 Change-Id: I2c2cbcbd918f0cfa970c1a964893220ba11d4b41 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247960 Reviewed-by: Artem Titov <titovartem@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: (Daniel.L) Byoungchan Lee <daniel.l@hpcnt.com> Cr-Commit-Position: refs/heads/main@{#35771} 4 年前
Fully qualify googletest symbols. Semi-automatically created with: git grep -l " testing::" | xargs sed -i "s/ testing::/ ::testing::/g" git grep -l "(testing::" | xargs sed -i "s/(testing::/(::testing::/g" git cl format After this, two .cc files failed to compile and I have fixed them manually. Bug: webrtc:10523 Change-Id: I4741d3bcedc831b6c5fdc04485678617eb4ce031 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132018 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27526}7 年前
Removes usage of the Magnifier API on Windows This CL removes the usage of the Magnifier screen capture API on Windows. The idea is to remove the actual source in a second step once this change lands. Bug: chromium:1428341 Change-Id: Id2cb25632c7edbea2cf527959b14b27ee00b0e56 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301164 Commit-Queue: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#39856} 3 年前
Improve Capturer Selection on Wayland It doesn't really make sense to try to create the X11 capturer if we are running under Wayland; nor does it make sense to create the PipeWire capturer if we are going to fail to actually start a stream with it. This change addresses both of these issues by exposing an IsSupported method on BaseCapturerPipeWire and checking that we are not running under Wayland before creating the X11 capturer. Bug: chromium:1374436 Change-Id: Ieb291307376010e084824124ea8fde065545337c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/279163 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Mark Foltz <mfoltz@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#38474} 3 年前
Fully qualify googletest symbols. Semi-automatically created with: git grep -l " testing::" | xargs sed -i "s/ testing::/ ::testing::/g" git grep -l "(testing::" | xargs sed -i "s/(testing::/(::testing::/g" git cl format After this, two .cc files failed to compile and I have fixed them manually. Bug: webrtc:10523 Change-Id: I4741d3bcedc831b6c5fdc04485678617eb4ce031 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132018 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27526}7 年前
Fixing WebRTC after moving from src/webrtc to src/ In https://webrtc-review.googlesource.com/c/src/+/1560 we moved WebRTC from src/webrtc to src/ (in order to preserve an healthy git history). This CL takes care of fixing header guards, #include paths, etc... NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=tommi@webrtc.org Bug: chromium:611808 Change-Id: Iea91618212bee0af16aa3f05071eab8f93706578 Reviewed-on: https://webrtc-review.googlesource.com/1561 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19846}8 年前
Removes usage of the Magnifier API on Windows This CL removes the usage of the Magnifier screen capture API on Windows. The idea is to remove the actual source in a second step once this change lands. Bug: chromium:1428341 Change-Id: Id2cb25632c7edbea2cf527959b14b27ee00b0e56 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301164 Commit-Queue: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#39856} 3 年前
Removes usage of the Magnifier API on Windows This CL removes the usage of the Magnifier screen capture API on Windows. The idea is to remove the actual source in a second step once this change lands. Bug: chromium:1428341 Change-Id: Id2cb25632c7edbea2cf527959b14b27ee00b0e56 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301164 Commit-Queue: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#39856} 3 年前
Fixing WebRTC after moving from src/webrtc to src/ In https://webrtc-review.googlesource.com/c/src/+/1560 we moved WebRTC from src/webrtc to src/ (in order to preserve an healthy git history). This CL takes care of fixing header guards, #include paths, etc... NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=tommi@webrtc.org Bug: chromium:611808 Change-Id: Iea91618212bee0af16aa3f05071eab8f93706578 Reviewed-on: https://webrtc-review.googlesource.com/1561 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19846}8 年前
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture Bug: webrtc:12338 Change-Id: I300ba78fc4423db7030e555d7e51d2cb2246e9a4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227162 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34678} 4 年前
Reland "Linux capturers: organize X11 and Wayland implementations into separate folders" Bug: webrtc:13429 Change-Id: Ibc7488cde807f859ee82a60fe47a7e21c148764e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/240460 Reviewed-by: Mark Foltz <mfoltz@chromium.org> Commit-Queue: Mark Foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/main@{#35527} 4 年前
Adopt absl::string_view in modules/desktop_capture/ Bug: webrtc:13579 Change-Id: I9fbc3d6df2dedb7eac908e1af38300d2b42142c8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/272000 Commit-Queue: Ali Tofigh <alito@webrtc.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#37817} 3 年前
Adopt absl::string_view in modules/desktop_capture/ Bug: webrtc:13579 Change-Id: I9fbc3d6df2dedb7eac908e1af38300d2b42142c8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/272000 Commit-Queue: Ali Tofigh <alito@webrtc.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#37817} 3 年前
Use std::make_unique instead of absl::make_unique. WebRTC is now using C++14 so there is no need to use the Abseil version of std::make_unique. This CL has been created with the following steps: git grep -l absl::make_unique | sort | uniq > /tmp/make_unique.txt git grep -l absl::WrapUnique | sort | uniq > /tmp/wrap_unique.txt git grep -l "#include <memory>" | sort | uniq > /tmp/memory.txt diff --new-line-format="" --unchanged-line-format="" \ /tmp/make_unique.txt /tmp/wrap_unique.txt | sort | \ uniq > /tmp/only_make_unique.txt diff --new-line-format="" --unchanged-line-format="" \ /tmp/only_make_unique.txt /tmp/memory.txt | \ xargs grep -l "absl/memory" > /tmp/add-memory.txt git grep -l "\babsl::make_unique\b" | \ xargs sed -i "s/\babsl::make_unique\b/std::make_unique/g" git checkout PRESUBMIT.py abseil-in-webrtc.md cat /tmp/add-memory.txt | \ xargs sed -i \ 's/#include "absl\/memory\/memory.h"/#include <memory>/g' git cl format # Manual fix order of the new inserted #include <memory> cat /tmp/only_make_unique | xargs grep -l "#include <memory>" | \ xargs sed -i '/#include "absl\/memory\/memory.h"/d' git ls-files | grep BUILD.gn | \ xargs sed -i '/\/\/third_party\/abseil-cpp\/absl\/memory/d' python tools_webrtc/gn_check_autofix.py \ -m tryserver.webrtc -b linux_rel # Repead the gn_check_autofix step for other platforms git ls-files | grep BUILD.gn | \ xargs sed -i 's/absl\/memory:memory/absl\/memory/g' git cl format Bug: webrtc:10945 Change-Id: I3fe28ea80f4dd3ba3cf28effd151d5e1f19aff89 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153221 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29209} 6 年前
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture Bug: webrtc:12338 Change-Id: I300ba78fc4423db7030e555d7e51d2cb2246e9a4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227162 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34678} 4 年前
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture Bug: webrtc:12338 Change-Id: I300ba78fc4423db7030e555d7e51d2cb2246e9a4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227162 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34678} 4 年前
Prepare for deleting implicit conversion from raw pointer to scoped_refptr. Updates all webrtc code, to have a small followup cl to just add the "explicit" keyword. Patchset #24 passed all webrtc tests, with explicit. Bug: webrtc:13464 Change-Id: I39863d3752f73209b531120f66916dc9177bf63a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/242363 Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35718} 4 年前
Remove RTC_DISALLOW_COPY_AND_ASSIGN from modules/ Bug: webrtc:13555, webrtc:13082 Change-Id: I2c2cbcbd918f0cfa970c1a964893220ba11d4b41 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247960 Reviewed-by: Artem Titov <titovartem@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: (Daniel.L) Byoungchan Lee <daniel.l@hpcnt.com> Cr-Commit-Position: refs/heads/main@{#35771} 4 年前
Reformat the WebRTC code base Running clang-format with chromium's style guide. The goal is n-fold: * providing consistency and readability (that's what code guidelines are for) * preventing noise with presubmit checks and git cl format * building on the previous point: making it easier to automatically fix format issues * you name it Please consider using git-hyper-blame to ignore this commit. Bug: webrtc:9340 Change-Id: I694567c4cdf8cee2860958cfe82bfaf25848bb87 Reviewed-on: https://webrtc-review.googlesource.com/81185 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23660}7 年前