文件最后提交记录最后更新时间
Fix several UBsan issues with memcpy Most of the changes are trivial. Bug: webrtc:14432 Change-Id: I0444527bf57c72c8d65f69754b4a4a1c1d7b2e92 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/275340 Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Victor Boivie <boivie@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38074} 3 年前
Replace virtual RtcpPacket::SetSenderSsrc with base member to slightly improve binary size. Bug: None Change-Id: I894c7d67a72f4a8077963d2ba0a7bb471a2e7e4d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156300 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29428} 6 年前
Replace virtual RtcpPacket::SetSenderSsrc with base member to slightly improve binary size. Bug: None Change-Id: I894c7d67a72f4a8077963d2ba0a7bb471a2e7e4d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156300 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29428} 6 年前
Adopt absl::string_view in modules/rtp_rtcp Bug: webrtc:13579 Change-Id: Ic4e1431bedc69492358cb2e3749b50a941306f44 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262250 Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Ali Tofigh <alito@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36887} 3 年前
Adopt absl::string_view in modules/rtp_rtcp Bug: webrtc:13579 Change-Id: Ic4e1431bedc69492358cb2e3749b50a941306f44 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262250 Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Ali Tofigh <alito@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36887} 3 年前
Fully qualify googletest symbols. Semi-automatically created with: git grep -l " testing::" | xargs sed -i "s/ testing::/ ::testing::/g" git grep -l "(testing::" | xargs sed -i "s/(testing::/(::testing::/g" git cl format After this, two .cc files failed to compile and I have fixed them manually. Bug: webrtc:10523 Change-Id: I4741d3bcedc831b6c5fdc04485678617eb4ce031 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132018 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27526}7 年前
Stop using LOG macros in favor of RTC_ prefixed macros. This CL has been generated with the following script: for m in PLOG \ LOG_TAG \ LOG_GLEM \ LOG_GLE_EX \ LOG_GLE \ LAST_SYSTEM_ERROR \ LOG_ERRNO_EX \ LOG_ERRNO \ LOG_ERR_EX \ LOG_ERR \ LOG_V \ LOG_F \ LOG_T_F \ LOG_E \ LOG_T \ LOG_CHECK_LEVEL_V \ LOG_CHECK_LEVEL \ LOG do git grep -l $m | xargs sed -i "s,\b$m\b,RTC_$m,g" done git checkout rtc_base/logging.h git cl format Bug: webrtc:8452 Change-Id: I1a53ef3e0a5ef6e244e62b2e012b864914784600 Reviewed-on: https://webrtc-review.googlesource.com/21325 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20617}8 年前
Reformat the WebRTC code base Running clang-format with chromium's style guide. The goal is n-fold: * providing consistency and readability (that's what code guidelines are for) * preventing noise with presubmit checks and git cl format * building on the previous point: making it easier to automatically fix format issues * you name it Please consider using git-hyper-blame to ignore this commit. Bug: webrtc:9340 Change-Id: I694567c4cdf8cee2860958cfe82bfaf25848bb87 Reviewed-on: https://webrtc-review.googlesource.com/81185 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23660}7 年前
Reformat the WebRTC code base Running clang-format with chromium's style guide. The goal is n-fold: * providing consistency and readability (that's what code guidelines are for) * preventing noise with presubmit checks and git cl format * building on the previous point: making it easier to automatically fix format issues * you name it Please consider using git-hyper-blame to ignore this commit. Bug: webrtc:9340 Change-Id: I694567c4cdf8cee2860958cfe82bfaf25848bb87 Reviewed-on: https://webrtc-review.googlesource.com/81185 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23660}7 年前
Updates rtcp::CompoundPacket to contain unique pointers to packets. Currently test code passes pointer to temporary objects, while RtcpSender passes raw pointers to objects that are then seen as owned, and will be manually deleted by a overloaded destructor, which is scary and fragile. This CL moves all usage to std::unique_ptr<RtcpPacket> instead, which may create some heap churn in unit tests but that should be fine. Bug: webrtc:11925 Change-Id: I981bc7ccd6a74115c5a3de64b8427adbf3f16cc7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183920 Commit-Queue: Erik Språng <sprang@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32084} 5 年前
Remove RTC_DISALLOW_COPY_AND_ASSIGN from modules/ Bug: webrtc:13555, webrtc:13082 Change-Id: I2c2cbcbd918f0cfa970c1a964893220ba11d4b41 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247960 Reviewed-by: Artem Titov <titovartem@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: (Daniel.L) Byoungchan Lee <daniel.l@hpcnt.com> Cr-Commit-Position: refs/heads/main@{#35771} 4 年前
Remove internal overrides using old SendRtp and SendRtcp interfaces. This CL takes away all usages except for Android code. Low-Coverage-Reason: Refactoring old code Bug: webrtc:15410 Change-Id: I66bed6a4a2787b4177a82e599b48623ca67cd235 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315940 Commit-Queue: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#40554} 2 年前
Move some numeric utility code from rtc_base/ to rtc_base/numerics/ Specifically, I'm moving safe_compare.h safe_conversions.h safe_minmax.h They shouldn't be part of the API, and moving them to an appropriate subdirectory of rtc_base/ is a good way to keep track of that. BUG=webrtc:8445 Change-Id: I458531aeb30bcf4291c4bec3bf22a2fffbf054ff Reviewed-on: https://webrtc-review.googlesource.com/20860 Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20829}8 年前
In RtcpTransceiver implement handling incoming RRTR Bug: webrtc:8239 Change-Id: I4a469b6a0c2e387e35262798f4686fbf310d00cd Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251902 Reviewed-by: Emil Lundmark <lndmrk@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36037} 4 年前
Fixing WebRTC after moving from src/webrtc to src/ In https://webrtc-review.googlesource.com/c/src/+/1560 we moved WebRTC from src/webrtc to src/ (in order to preserve an healthy git history). This CL takes care of fixing header guards, #include paths, etc... NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=tommi@webrtc.org Bug: chromium:611808 Change-Id: Iea91618212bee0af16aa3f05071eab8f93706578 Reviewed-on: https://webrtc-review.googlesource.com/1561 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19846}8 年前
Replace virtual RtcpPacket::SetSenderSsrc with base member to slightly improve binary size. Bug: None Change-Id: I894c7d67a72f4a8077963d2ba0a7bb471a2e7e4d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156300 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29428} 6 年前
Clean up previously deleted RTCP VOIP metrics block. Bug: None Change-Id: I6f9ddb09927200444dbccd24ed522c9b8f936b0f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/205623 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33169} 5 年前
In RtcpTransceiver implement handling incoming RRTR Bug: webrtc:8239 Change-Id: I4a469b6a0c2e387e35262798f4686fbf310d00cd Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251902 Reviewed-by: Emil Lundmark <lndmrk@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36037} 4 年前
Parse XR, FIR and PLI in rtc_event_log_parser.cc Bug: webrtc:10312 Change-Id: I1b24e23f8002feef8a2ef928130ac6da19c3cd81 Reviewed-on: https://webrtc-review.googlesource.com/c/122580 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Mirta Dvornicic <mirtad@webrtc.org> Commit-Queue: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26670}7 年前
Parse XR, FIR and PLI in rtc_event_log_parser.cc Bug: webrtc:10312 Change-Id: I1b24e23f8002feef8a2ef928130ac6da19c3cd81 Reviewed-on: https://webrtc-review.googlesource.com/c/122580 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Mirta Dvornicic <mirtad@webrtc.org> Commit-Queue: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26670}7 年前
Fully qualify googletest symbols. Semi-automatically created with: git grep -l " testing::" | xargs sed -i "s/ testing::/ ::testing::/g" git grep -l "(testing::" | xargs sed -i "s/(testing::/(::testing::/g" git cl format After this, two .cc files failed to compile and I have fixed them manually. Bug: webrtc:10523 Change-Id: I4741d3bcedc831b6c5fdc04485678617eb4ce031 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132018 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27526}7 年前
Use backticks not vertical bars to denote variables in comments for /modules/rtp_rtcp Bug: webrtc:12338 Change-Id: I52eb3b6675c4705e22f51b70799ed6139a3b46bc Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227164 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34686} 4 年前
Fix spelling of receiver and transceiver. Bug: None Change-Id: I439e217d67283b182833e48da15af9ae367ac14e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256015 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36257} 4 年前
Use backticks not vertical bars to denote variables in comments for /modules/rtp_rtcp Bug: webrtc:12338 Change-Id: I52eb3b6675c4705e22f51b70799ed6139a3b46bc Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227164 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34686} 4 年前
[Cleanup] Add missing #include. Remove useless ones. This CL is the result of running include-what-you-use tool on part of the code base (audio target and dependencies) plus manual fixes. bug: webrtc:8311 Change-Id: I277d281ce943c3ecc1bd45fd8d83055931743604 Reviewed-on: https://webrtc-review.googlesource.com/c/106280 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25311}7 年前
Remove clang:find_bad_constructs suppression from logging (part 1). This CL removes //build/config/clang:find_bad_constructs from the suppressed_configs list, which means that clang:find_bad_constructs is now enabled on these translation units. Bug: webrtc:9251, webrtc:163 Change-Id: I443c0c77cef30a3f5712f72ce88db80d1fb29874 Reviewed-on: https://webrtc-review.googlesource.com/96642 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24567}7 年前
Format almost everything. This CL was generated by running git ls-files | grep -P "(\.h|\.cc)$" | grep -v 'sdk/' | grep -v 'rtc_base/ssl_' | \ grep -v 'fake_rtc_certificate_generator.h' | grep -v 'modules/audio_device/win/' | \ grep -v 'system_wrappers/source/clock.cc' | grep -v 'rtc_base/trace_event.h' | \ grep -v 'modules/audio_coding/codecs/ilbc/' | grep -v 'screen_capturer_mac.h' | \ grep -v 'spl_inl_mips.h' | grep -v 'data_size_unittest.cc' | grep -v 'timestamp_unittest.cc' \ | xargs clang-format -i ; git cl format Most of these changes are clang-format grouping and reordering includes differently. Bug: webrtc:9340 Change-Id: Ic83ddbc169bfacd21883e381b5181c3dd4fe8a63 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144051 Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28505} 6 年前
Parse XR, FIR and PLI in rtc_event_log_parser.cc Bug: webrtc:10312 Change-Id: I1b24e23f8002feef8a2ef928130ac6da19c3cd81 Reviewed-on: https://webrtc-review.googlesource.com/c/122580 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Mirta Dvornicic <mirtad@webrtc.org> Commit-Queue: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26670}7 年前
Parse XR, FIR and PLI in rtc_event_log_parser.cc Bug: webrtc:10312 Change-Id: I1b24e23f8002feef8a2ef928130ac6da19c3cd81 Reviewed-on: https://webrtc-review.googlesource.com/c/122580 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Mirta Dvornicic <mirtad@webrtc.org> Commit-Queue: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26670}7 年前
Fully qualify googletest symbols. Semi-automatically created with: git grep -l " testing::" | xargs sed -i "s/ testing::/ ::testing::/g" git grep -l "(testing::" | xargs sed -i "s/(testing::/(::testing::/g" git cl format After this, two .cc files failed to compile and I have fixed them manually. Bug: webrtc:10523 Change-Id: I4741d3bcedc831b6c5fdc04485678617eb4ce031 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132018 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27526}7 年前
Replace virtual RtcpPacket::SetSenderSsrc with base member to slightly improve binary size. Bug: None Change-Id: I894c7d67a72f4a8077963d2ba0a7bb471a2e7e4d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156300 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29428} 6 年前
Replace virtual RtcpPacket::SetSenderSsrc with base member to slightly improve binary size. Bug: None Change-Id: I894c7d67a72f4a8077963d2ba0a7bb471a2e7e4d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156300 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29428} 6 年前
Change RtcpPacket::PacketReadyCallback to rtc::FunctionView from interface Bug: webrtc:5565 Change-Id: I2df5d7a0554b938888581f1c73dbdb8b85c387cc Reviewed-on: https://webrtc-review.googlesource.com/8680 Reviewed-by: Niels Moller <nisse@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21136}8 年前
Delete unneeded includes of basictypes.h. This is a kitchen-sink header, some pieces should be moved to byteorder.h, the rest likely deleted. Delete most includes of basictypes.h. In leaf headers, include stddef.h and stdint.h explicitly where needed. Bug: webrtc:6853 Change-Id: Ibc809936a8f94d418e4eb650da1e89c1b9142073 Reviewed-on: https://webrtc-review.googlesource.com/77721 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23333}7 年前
Fully qualify googletest symbols. Semi-automatically created with: git grep -l " testing::" | xargs sed -i "s/ testing::/ ::testing::/g" git grep -l "(testing::" | xargs sed -i "s/(testing::/(::testing::/g" git cl format After this, two .cc files failed to compile and I have fixed them manually. Bug: webrtc:10523 Change-Id: I4741d3bcedc831b6c5fdc04485678617eb4ce031 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132018 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27526}7 年前
Replace virtual RtcpPacket::SetSenderSsrc with base member to slightly improve binary size. Bug: None Change-Id: I894c7d67a72f4a8077963d2ba0a7bb471a2e7e4d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156300 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29428} 6 年前
Replace virtual RtcpPacket::SetSenderSsrc with base member to slightly improve binary size. Bug: None Change-Id: I894c7d67a72f4a8077963d2ba0a7bb471a2e7e4d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156300 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29428} 6 年前
Delete clamping cumulative loss in ReportBlocks on receiving side Bug: webrtc:9598 Change-Id: I8a54af88708e5d96e46ba67ab0ef2e0e59fe0b86 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/300941 Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39887} 3 年前
In remb parser discard bitrate larger than max int64_t Bug: b/265156399 Change-Id: I5bdbd42a8da565972a3c2e976a32a563f3cce6af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290888 Reviewed-by: Emil Lundmark <lndmrk@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39082} 3 年前
Allow REMB messages to be sent immediately in RtcpTransceiver This cl add a configuration flag to allow REMB messages to be sent immediately when the bitrate value have changed. The remb message is still included in all following compound packets. Bug: None Change-Id: I9f71d30cddbccd095e1d2971247c731bd1727d32 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169221 Commit-Queue: Per Kjellander <perkj@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30627} 6 年前
In remb parser discard bitrate larger than max int64_t Bug: b/265156399 Change-Id: I5bdbd42a8da565972a3c2e976a32a563f3cce6af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290888 Reviewed-by: Emil Lundmark <lndmrk@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39082} 3 年前
Replace DataSize and DataRate factories with newer versions This is search and replace change: find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/DataSize::Bytes<\(.*\)>()/DataSize::Bytes(\1)/g" find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/DataSize::bytes/DataSize::Bytes/g" find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/DataRate::BitsPerSec<\(.*\)>()/DataRate::BitsPerSec(\1)/g" find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/DataRate::BytesPerSec<\(.*\)>()/DataRate::BytesPerSec(\1)/g" find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/DataRate::KilobitsPerSec<\(.*\)>()/DataRate::KilobitsPerSec(\1)/g" find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/DataRate::bps/DataRate::BitsPerSec/g" find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/DataRate::kbps/DataRate::KilobitsPerSec/g" git cl format Bug: webrtc:9709 Change-Id: I65aaca69474ba038c1fe2dd8dc30d3f8e7b94c29 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168647 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30545} 6 年前
Fix for potential out of bounds reading in rtcp::RemoteEstimate parser. packet_size() includes the size of padding, this means that the size check might incorrectly not trigger even if the payload is empty. In turn this means that the ReadBigEndian call might read out of bounds memory. Refactored the code to reuse the App parsing code more, eliminating the risk of this particular kind of error. Bug: chromium:987507 Change-Id: Id8f3e292c3d30460d3cdb551f0a45070fdf8f022 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146716 Reviewed-by: Stefan Holmer <stefan@webrtc.org> Commit-Queue: Sebastian Jansson <srte@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28680} 6 年前
Replace DataSize and DataRate factories with newer versions This is search and replace change: find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/DataSize::Bytes<\(.*\)>()/DataSize::Bytes(\1)/g" find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/DataSize::bytes/DataSize::Bytes/g" find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/DataRate::BitsPerSec<\(.*\)>()/DataRate::BitsPerSec(\1)/g" find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/DataRate::BytesPerSec<\(.*\)>()/DataRate::BytesPerSec(\1)/g" find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/DataRate::KilobitsPerSec<\(.*\)>()/DataRate::KilobitsPerSec(\1)/g" find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/DataRate::bps/DataRate::BitsPerSec/g" find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/DataRate::kbps/DataRate::KilobitsPerSec/g" git cl format Bug: webrtc:9709 Change-Id: I65aaca69474ba038c1fe2dd8dc30d3f8e7b94c29 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168647 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30545} 6 年前
Delete clamping cumulative loss in ReportBlocks on receiving side Bug: webrtc:9598 Change-Id: I8a54af88708e5d96e46ba67ab0ef2e0e59fe0b86 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/300941 Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39887} 3 年前
Delete ReportBlock::cumulative_lost_signed accessor cumulative lost is always signed now. Bug: webrtc:9598 Change-Id: I7cf9f87c01a60fafc3fa6a9bdb84950343697193 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301940 Auto-Submit: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39905} 3 年前
Delete clamping cumulative loss in ReportBlocks on receiving side Bug: webrtc:9598 Change-Id: I8a54af88708e5d96e46ba67ab0ef2e0e59fe0b86 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/300941 Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39887} 3 年前
Fixing WebRTC after moving from src/webrtc to src/ In https://webrtc-review.googlesource.com/c/src/+/1560 we moved WebRTC from src/webrtc to src/ (in order to preserve an healthy git history). This CL takes care of fixing header guards, #include paths, etc... NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=tommi@webrtc.org Bug: chromium:611808 Change-Id: Iea91618212bee0af16aa3f05071eab8f93706578 Reviewed-on: https://webrtc-review.googlesource.com/1561 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19846}8 年前
In RtcpTransceiver implement handling incoming RRTR Bug: webrtc:8239 Change-Id: I4a469b6a0c2e387e35262798f4686fbf310d00cd Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251902 Reviewed-by: Emil Lundmark <lndmrk@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36037} 4 年前
Reformat the WebRTC code base Running clang-format with chromium's style guide. The goal is n-fold: * providing consistency and readability (that's what code guidelines are for) * preventing noise with presubmit checks and git cl format * building on the previous point: making it easier to automatically fix format issues * you name it Please consider using git-hyper-blame to ignore this commit. Bug: webrtc:9340 Change-Id: I694567c4cdf8cee2860958cfe82bfaf25848bb87 Reviewed-on: https://webrtc-review.googlesource.com/81185 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23660}7 年前
Replace virtual RtcpPacket::SetSenderSsrc with base member to slightly improve binary size. Bug: None Change-Id: I894c7d67a72f4a8077963d2ba0a7bb471a2e7e4d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156300 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29428} 6 年前
Replace virtual RtcpPacket::SetSenderSsrc with base member to slightly improve binary size. Bug: None Change-Id: I894c7d67a72f4a8077963d2ba0a7bb471a2e7e4d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156300 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29428} 6 年前
Adopt absl::string_view in modules/rtp_rtcp Bug: webrtc:13579 Change-Id: Ic4e1431bedc69492358cb2e3749b50a941306f44 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262250 Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Ali Tofigh <alito@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36887} 3 年前
Adopt absl::string_view in modules/rtp_rtcp Bug: webrtc:13579 Change-Id: Ic4e1431bedc69492358cb2e3749b50a941306f44 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262250 Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Ali Tofigh <alito@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36887} 3 年前
Remove simple stringstream usages. This CL replaces std::o?stringstream with rtc::StringBuilder where that's possible to do without changing any of the surrounding code. It also updates includes and build files as appropriate. The CL was generated by running 'git grep -l -P std::o?stringstream | xargs perl -pi -e "s/std::o?stringstream/rtc::StringBuilder/g"'. Then I've manually updated the #includes and BUILD files, run 'git cl format' and unstaged any file that would need more complex fixes. Bug: webrtc:8982 Change-Id: Ibc32153f4a3fd177e260b6ad05ce393972549357 Reviewed-on: https://webrtc-review.googlesource.com/98460 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24605}7 年前
Replace virtual RtcpPacket::SetSenderSsrc with base member to slightly improve binary size. Bug: None Change-Id: I894c7d67a72f4a8077963d2ba0a7bb471a2e7e4d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156300 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29428} 6 年前
Replace virtual RtcpPacket::SetSenderSsrc with base member to slightly improve binary size. Bug: None Change-Id: I894c7d67a72f4a8077963d2ba0a7bb471a2e7e4d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156300 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29428} 6 年前
Fully qualify googletest symbols. Semi-automatically created with: git grep -l " testing::" | xargs sed -i "s/ testing::/ ::testing::/g" git grep -l "(testing::" | xargs sed -i "s/(testing::/(::testing::/g" git cl format After this, two .cc files failed to compile and I have fixed them manually. Bug: webrtc:10523 Change-Id: I4741d3bcedc831b6c5fdc04485678617eb4ce031 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132018 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27526}7 年前
Move some numeric utility code from rtc_base/ to rtc_base/numerics/ Specifically, I'm moving safe_compare.h safe_conversions.h safe_minmax.h They shouldn't be part of the API, and moving them to an appropriate subdirectory of rtc_base/ is a good way to keep track of that. BUG=webrtc:8445 Change-Id: I458531aeb30bcf4291c4bec3bf22a2fffbf054ff Reviewed-on: https://webrtc-review.googlesource.com/20860 Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20829}8 年前
Delete unneeded includes of basictypes.h. This is a kitchen-sink header, some pieces should be moved to byteorder.h, the rest likely deleted. Delete most includes of basictypes.h. In leaf headers, include stddef.h and stdint.h explicitly where needed. Bug: webrtc:6853 Change-Id: Ibc809936a8f94d418e4eb650da1e89c1b9142073 Reviewed-on: https://webrtc-review.googlesource.com/77721 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23333}7 年前
Replace rtc::Optional with absl::optional in modules/rtp_rtcp This is a no-op change because rtc::Optional is an alias to absl::optional This CL generated using script: #!/bin/bash dir=modules/rtp_rtcp find $dir -type f \( -name \*.h -o -name \*.cc \) \ -exec sed -i 's|rtc::Optional|absl::optional|' {} \+ \ -exec sed -i 's|rtc::nullopt|absl::nullopt|' {} \+ \ -exec sed -i 's|#include "api/optional.h"|#include "absl/types/optional.h"|' {} \+ find $dir -type f -name BUILD.gn \ -exec sed -r -i 's|"(../)*api:optional"|"//third_party/abseil-cpp/absl/types:optional"|' {} \+; git cl format Bug: webrtc:9078 Change-Id: Ife720849709959046329c1c9faa3f31aa13274dc Reviewed-on: https://webrtc-review.googlesource.com/83584 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23624}7 年前
Stop using LOG macros in favor of RTC_ prefixed macros. This CL has been generated with the following script: for m in PLOG \ LOG_TAG \ LOG_GLEM \ LOG_GLE_EX \ LOG_GLE \ LAST_SYSTEM_ERROR \ LOG_ERRNO_EX \ LOG_ERRNO \ LOG_ERR_EX \ LOG_ERR \ LOG_V \ LOG_F \ LOG_T_F \ LOG_E \ LOG_T \ LOG_CHECK_LEVEL_V \ LOG_CHECK_LEVEL \ LOG do git grep -l $m | xargs sed -i "s,\b$m\b,RTC_$m,g" done git checkout rtc_base/logging.h git cl format Bug: webrtc:8452 Change-Id: I1a53ef3e0a5ef6e244e62b2e012b864914784600 Reviewed-on: https://webrtc-review.googlesource.com/21325 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20617}8 年前
Delete unneeded includes of basictypes.h. This is a kitchen-sink header, some pieces should be moved to byteorder.h, the rest likely deleted. Delete most includes of basictypes.h. In leaf headers, include stddef.h and stdint.h explicitly where needed. Bug: webrtc:6853 Change-Id: Ibc809936a8f94d418e4eb650da1e89c1b9142073 Reviewed-on: https://webrtc-review.googlesource.com/77721 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23333}7 年前
[Cleanup] Add missing #include. Remove useless ones. This CL is the result of running include-what-you-use tool on part of the code base (audio target and dependencies) plus manual fixes. bug: webrtc:8311 Change-Id: I277d281ce943c3ecc1bd45fd8d83055931743604 Reviewed-on: https://webrtc-review.googlesource.com/c/106280 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25311}7 年前
Delete unneeded includes of basictypes.h. This is a kitchen-sink header, some pieces should be moved to byteorder.h, the rest likely deleted. Delete most includes of basictypes.h. In leaf headers, include stddef.h and stdint.h explicitly where needed. Bug: webrtc:6853 Change-Id: Ibc809936a8f94d418e4eb650da1e89c1b9142073 Reviewed-on: https://webrtc-review.googlesource.com/77721 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23333}7 年前
Fully qualify googletest symbols. Semi-automatically created with: git grep -l " testing::" | xargs sed -i "s/ testing::/ ::testing::/g" git grep -l "(testing::" | xargs sed -i "s/(testing::/(::testing::/g" git cl format After this, two .cc files failed to compile and I have fixed them manually. Bug: webrtc:10523 Change-Id: I4741d3bcedc831b6c5fdc04485678617eb4ce031 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132018 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27526}7 年前
[Cleanup] Add missing #include. Remove useless ones. This CL is the result of running include-what-you-use tool on part of the code base (audio target and dependencies) plus manual fixes. bug: webrtc:8311 Change-Id: I277d281ce943c3ecc1bd45fd8d83055931743604 Reviewed-on: https://webrtc-review.googlesource.com/c/106280 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25311}7 年前
Delete unneeded includes of basictypes.h. This is a kitchen-sink header, some pieces should be moved to byteorder.h, the rest likely deleted. Delete most includes of basictypes.h. In leaf headers, include stddef.h and stdint.h explicitly where needed. Bug: webrtc:6853 Change-Id: Ibc809936a8f94d418e4eb650da1e89c1b9142073 Reviewed-on: https://webrtc-review.googlesource.com/77721 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23333}7 年前
Fix 28 ClangTidy - Readability findings in modules/rtp_rtcp/ These fixes are automatically created by various analysis tools, but have been manually triggered to be applied. * the 'empty' method should be used to check for emptiness instead of 'size' (3 times) * using decl 'Return' is unused (4 times) * using decl '_' is unused (3 times) * using decl 'DoAll' is unused (2 times) * using decl 'SetArgPointee' is unused * using decl 'Dlrr' is unused * using decl 'IsEmpty' is unused * redundant get() call on smart pointer * using decl 'Invoke' is unused (2 times) * using decl 'SizeIs' is unused (3 times) * using decl 'make_tuple' is unused * using decl 'NiceMock' is unused * using decl 'SaveArg' is unused (2 times) * using decl 'AtLeast' is unused * using decl 'ElementsAre' is unused * using decl 'Gt' is unused Bug: None Change-Id: I97658fb0e94620b8319d7c3da29b15e27ec23188 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151133 Reviewed-by: Niels Moller <nisse@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29056} 6 年前
in rtcp::TransportFeedback do not memorise all described packet Instead generate such info on request Bug: None Change-Id: I8c3b54c8acdd0e3df822ecbc313ab8c232de5812 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269251 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39207} 3 年前
in rtcp::TransportFeedback do not memorise all described packet Instead generate such info on request Bug: None Change-Id: I8c3b54c8acdd0e3df822ecbc313ab8c232de5812 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269251 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39207} 3 年前
Fix usages of RTC_DCHECK to GTEST macros to ensure tests pass in release builds as well Using RTC_DCHECK for test validation is wrong to begin with (gets compiled out in non-debug builds, which measn we may miss validations), but becomes extra problematic when we include code with side-effects inside the DCHECK, which results in release-build tests having a different flow than intended Bug: webrtc:15572 Change-Id: I89d5b55f903b9d93fe4a929548d1b9fcde8941be Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323182 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41005} 2 年前