0
代码
代码
Issues
Pull Requests
讨论
Wiki
分析
0
WWebRTC LUCI CQFix bug in SvcRateAllocator capping to VideoCodec.maxBitrate
e94dcefb创建于 2023年3月18日历史提交
文件最后提交记录最后更新时间
BUILD.gn
Add support for scalability modes L2T3 and S2T3 Bug: webrtc:11607 Change-Id: I1d0bd171564d2852f2f6ee2bbee26c7a1c0e1c3f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267103 Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37389} 3 年前
create_scalability_structure.cc
Add support for more scalability modes (1.5:1 resolution ratio). Added modes: - S2T1h - S2T2h - S2T3h - S3T1h - S3T2h - S3T3h Bug: webrtc:13960 Change-Id: I618a30c68b0ce1609847ee33a2298fe8fa0720c9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273664 Reviewed-by: Florent Castelli <orphis@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Commit-Queue: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37968} 3 年前
create_scalability_structure.h
New enum ScalabilityMode. Used instead of string representation in lower-levels of encoder configuration, to avoid string comparisons (with risk of misspelling) in lots of places. Bug: webrtc:11607 Change-Id: I4d51c2265aac297c29976d2aa601d8ffb33b7326 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259870 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36706} 4 年前
scalability_mode_util.cc
Add support for reducing number of spatial layers via scalability mode. Bug: webrtc:13960 Change-Id: Icf31d2e327e363dac24245cb5c9fc14cbaa9b3b4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/275942 Reviewed-by: Sergey Silkin <ssilkin@webrtc.org> Commit-Queue: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38454} 3 年前
scalability_mode_util.h
Add SVC fallback. Fallback to a default value if the scalability mode is unset or not supported by the codec. The fallback logic is only enabled if the scalability mode is configured for any of the encodings for now (i.e. initial default values are not set). Bug: webrtc:11607 Change-Id: Ie632767b627a1dbbef71c59f9340573daf386c14 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/287600 Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Commit-Queue: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39074} 3 年前
scalability_mode_util_unittest.cc
Add support for reducing number of spatial layers via scalability mode. Bug: webrtc:13960 Change-Id: Icf31d2e327e363dac24245cb5c9fc14cbaa9b3b4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/275942 Reviewed-by: Sergey Silkin <ssilkin@webrtc.org> Commit-Queue: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38454} 3 年前
scalability_structure_full_svc.cc
Add support for scalability modes L3T1_KEY, L3T2, L3T2_KEY. Bug: webrtc:13960 Change-Id: Ib5c8309271d83a0fcfdecf7a93fdd61483c7d3e2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273105 Commit-Queue: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37927} 3 年前
scalability_structure_full_svc.h
Add support for scalability modes L3T1_KEY, L3T2, L3T2_KEY. Bug: webrtc:13960 Change-Id: Ib5c8309271d83a0fcfdecf7a93fdd61483c7d3e2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273105 Commit-Queue: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37927} 3 年前
scalability_structure_full_svc_unittest.cc
Allow full SVC to reference T0 frame only after it has been encoded The VP9 encoder may drop a frame internally which will not advance the frame pattern. Consider the following scenario where only spatial layer 0 and temporal layer 0 is active: 1. Key frame encoded 2. Spatial layer 1 is activated 3. Delta T0 dropped 4. Delta T0 encoded No S1T0 frame is encoded in (1) since it's not active. When NextFrameConfig is called in (3) it will say that future frames may reference T0 on both S0 and S1, but it's then dropped. On step (4), the SVC controller essentially thinks it's encoding a new picture and will happily reference the T0 on what it thinks is the first delta frame. However, this is actually still the key frame and since there was no S1T0 frame produced it will reference an invalid buffer. To fix this, only say it's possible to reference a T0 frame after it has been successfully encoded. Bug: webrtc:11999, webrtc:13142, chromium:1178444 Change-Id: Iab3d2042ce0b3fa7d952b2831d1a36b1a6613a86 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231695 Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Emil Lundmark <lndmrk@webrtc.org> Cr-Commit-Position: refs/heads/main@{#34982} 4 年前
scalability_structure_key_svc.cc
Add support for scalability modes L3T1_KEY, L3T2, L3T2_KEY. Bug: webrtc:13960 Change-Id: Ib5c8309271d83a0fcfdecf7a93fdd61483c7d3e2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273105 Commit-Queue: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37927} 3 年前
scalability_structure_key_svc.h
Add support for scalability modes L3T1_KEY, L3T2, L3T2_KEY. Bug: webrtc:13960 Change-Id: Ib5c8309271d83a0fcfdecf7a93fdd61483c7d3e2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273105 Commit-Queue: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37927} 3 年前
scalability_structure_key_svc_unittest.cc
In ksvc controller reuse unused frame configuration vp9 encoder wrapper rely on that behaviour to generate vp9-specific temporal references Bug: webrtc:11999 Change-Id: I35536af4eca76450e2f72777e06ad3af872a5800 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/211340 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Philip Eliasson <philipel@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33445} 5 年前
scalability_structure_l2t2_key_shift.cc
Add helper to query scalability structure configuration without creating svc controller for it. Bug: chromium:1187565 Change-Id: I219f88203e73036bf48bce04527bb8e46ccf1c33 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231128 Reviewed-by: Johannes Kron <kron@webrtc.org> Reviewed-by: Philip Eliasson <philipel@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#34968} 4 年前
scalability_structure_l2t2_key_shift.h
Add layer skipping to L2T2_KEY_SHIFT structure Bug: None Change-Id: Iba019a999cb1812eee12bfe54c2f9ec9ebfa248f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/189965 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Philip Eliasson <philipel@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32487} 5 年前
scalability_structure_l2t2_key_shift_unittest.cc
Add layer skipping to L2T2_KEY_SHIFT structure Bug: None Change-Id: Iba019a999cb1812eee12bfe54c2f9ec9ebfa248f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/189965 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Philip Eliasson <philipel@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32487} 5 年前
scalability_structure_simulcast.cc
Add support for more scalability modes (1.5:1 resolution ratio). Added modes: - S2T1h - S2T2h - S2T3h - S3T1h - S3T2h - S3T3h Bug: webrtc:13960 Change-Id: I618a30c68b0ce1609847ee33a2298fe8fa0720c9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273664 Reviewed-by: Florent Castelli <orphis@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Commit-Queue: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37968} 3 年前
scalability_structure_simulcast.h
Add support for more scalability modes (1.5:1 resolution ratio). Added modes: - S2T1h - S2T2h - S2T3h - S3T1h - S3T2h - S3T3h Bug: webrtc:13960 Change-Id: I618a30c68b0ce1609847ee33a2298fe8fa0720c9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273664 Reviewed-by: Florent Castelli <orphis@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Commit-Queue: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37968} 3 年前
scalability_structure_test_helpers.cc
Ignore frame type when calculating generic frame dependencies. When spatial scalability is used, both vpx and aom set key frame flag for all spatial layers of the first frame, while rtp code expect it to be set only on the frame without spatial dependencies. That creates confusion for the frame dependency calculator. Simplest solution seems to ignore that confusing signal and instead rely encoder wrappers update frame buffer usages when key frame is generated. Bug: webrtc:11999 Change-Id: Ica24f1d8d42d32dd24664beabf32ac24872cd15a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194002 Reviewed-by: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32667} 5 年前
scalability_structure_test_helpers.h
Support layer skipping in key svc structures Add KSvc structure for 3 spatial and 3 temporal layers to allow to cover more scenarious Bug: webrtc:11999 Change-Id: Id16d1acfb4ca5f98d1b17d8f66d54b31d22d0745 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/188122 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Philip Eliasson <philipel@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32434} 5 年前
scalability_structure_unittest.cc
Add support for scalability modes S2T2, S3T1, S3T2. Bug: webrtc:13960 Change-Id: Icafd3a5a3f8889777d65da5313b24e56a57af4d9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273301 Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Commit-Queue: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37943} 3 年前
scalable_video_controller.h
Add helper to query scalability structure configuration without creating svc controller for it. Bug: chromium:1187565 Change-Id: I219f88203e73036bf48bce04527bb8e46ccf1c33 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231128 Reviewed-by: Johannes Kron <kron@webrtc.org> Reviewed-by: Philip Eliasson <philipel@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#34968} 4 年前
scalable_video_controller_no_layering.cc
Add helper to query scalability structure configuration without creating svc controller for it. Bug: chromium:1187565 Change-Id: I219f88203e73036bf48bce04527bb8e46ccf1c33 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231128 Reviewed-by: Johannes Kron <kron@webrtc.org> Reviewed-by: Philip Eliasson <philipel@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#34968} 4 年前
scalable_video_controller_no_layering.h
Test and fix unscalable video structure. Bug: webrtc:11999 Change-Id: I94e3a97ebadbf92ca741d750f67fbea5cbd2b66f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/206984 Reviewed-by: Philip Eliasson <philipel@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33237} 5 年前
svc_rate_allocator.cc
Fix bug in SvcRateAllocator capping to VideoCodec.maxBitrate When allocating bitrate, some parts of the coded directly uses the bitrate parameter, while others lets it be capped by VideoCodec.maxBitrate. This may result in an inconsistency between expected and actual number of temporal layers, causing a crash. Even better would be to update VideoCodecInitializer to not create VideoCodec instances where there's not enough maxBitrate to activate all spatial layers - but that's a much more complex issue. Bug: chromium:1423365 Change-Id: Ic74b68261ea6043f1795accdd9864319ab535435 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/298041 Commit-Queue: Erik Språng <sprang@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39593} 3 年前
svc_rate_allocator.h
Move SvcRateAllocator out of codecs/vp9 and make it not vp9 specific to reuse it for scalable av1 Bug: webrtc:12148 Change-Id: I0d413c5466a2d66df3eea9cdf13687f4ddd1a843 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/191765 Reviewed-by: Philip Eliasson <philipel@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32560} 5 年前
svc_rate_allocator_unittest.cc
Fix bug in SvcRateAllocator capping to VideoCodec.maxBitrate When allocating bitrate, some parts of the coded directly uses the bitrate parameter, while others lets it be capped by VideoCodec.maxBitrate. This may result in an inconsistency between expected and actual number of temporal layers, causing a crash. Even better would be to update VideoCodecInitializer to not create VideoCodec instances where there's not enough maxBitrate to activate all spatial layers - but that's a much more complex issue. Bug: chromium:1423365 Change-Id: Ic74b68261ea6043f1795accdd9864319ab535435 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/298041 Commit-Queue: Erik Språng <sprang@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39593} 3 年前