0
代码
代码
Issues
Pull Requests
讨论
Wiki
分析
0
WWebRTC LUCI CQdcsctp: Rename message_id to mid
ee0270b6创建于 2023年10月6日历史提交
文件最后提交记录最后更新时间
abort_chunk.cc
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
abort_chunk.h
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
abort_chunk_test.cc
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
chunk.cc
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
chunk.h
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
cookie_ack_chunk.cc
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
cookie_ack_chunk.h
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
cookie_ack_chunk_test.cc
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
cookie_echo_chunk.cc
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
cookie_echo_chunk.h
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
cookie_echo_chunk_test.cc
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
data_chunk.cc
Format ^(api|call|common_audio|examples|media|net|p2p|pc)/ half of the remaining folders git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -E "^(api|call|common_audio|examples|media|net|p2p|pc)/" | xargs clang-format -i ; git cl format after landing: add to .git-blame-ignore-revs Bug: webrtc:15082 Change-Id: I8b2cac13f4587d3ce9b2fccc7362967283f57ea2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/302062 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39977} 3 年前
data_chunk.h
Revert "dcsctp: Use rtc::CopyOnWriteBuffer" This reverts commit 2db59a6584eca54245794a0e657ca9ded9e6707f. Reason for revert: Causes msan-issue in crc32c, reading uninitialized memory. Bug: webrtc:12943, chromium:1275559 Change-Id: I05f1012d896aeaca86c4562e0df15fa7ea326d60 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239560 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Victor Boivie <boivie@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35461} 4 年前
data_chunk_test.cc
Revert "dcsctp: Use rtc::CopyOnWriteBuffer" This reverts commit 2db59a6584eca54245794a0e657ca9ded9e6707f. Reason for revert: Causes msan-issue in crc32c, reading uninitialized memory. Bug: webrtc:12943, chromium:1275559 Change-Id: I05f1012d896aeaca86c4562e0df15fa7ea326d60 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239560 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Victor Boivie <boivie@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35461} 4 年前
data_common.h
dcsctp: Rename message_id to mid MID is a RFC8260 property on an I-DATA chunk, replacing the SSN property on the DATA chunk in non-interleaved message. The MID stands for "Message Identifier", and it was frequently named "message_id" in the source code, but sometimes "mid". To be consistent and using the same terminology as is most common in the RFC, use "mid" everywhere. This was triggered by the need to introduce yet another "message identifier" - but for now, this is just a refacotring CL. Bug: None Change-Id: I9cca898d9f3a2f162d6f2e4508ec1b4bc8d7308f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322500 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Victor Boivie <boivie@webrtc.org> Cr-Commit-Position: refs/heads/main@{#40876} 2 年前
error_chunk.cc
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
error_chunk.h
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
error_chunk_test.cc
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
forward_tsn_chunk.cc
dcsctp: Don't deliver skipped messages If a FORWARD-TSN contains an ordered skipped stream with a large TSN but with a too small SSN, it can result in messages being assembled that should've been skipped. Typically: Receive DATA, ordered, complete, TSN=10, SID=1, SSN=0 - will be delivered. Receive DATA, ordered, complete, TSN=43, SID=1, SSN=7 - will stay in queue, due to missing SSN=1,2,3,4,5,6. Receive FORWARD-TSN, TSN=44, SSN=6 - is invalid, as the SSN should've been 7 or higher. However, as the TSN isn't used for removing messages in ordered streams, but just the SSN, the SSN=7 isn't removed but instead will be delivered as it's the next following SSN after 6. This will trigger internal consistency checks as a chunk with TSN=43 will be delivered when the current cumulative TSN is set to 44, which is greater. This was found when fuzzing, and can only be provoked by a client that is intentionally misbehaving. Before this fix, there was no harm done, but it failed consistency checks which fuzzers have enabled. When bug 13799 was fixed (in a previous commit), this allowed the fuzzers to find it faster. Bug: webrtc:13799 Change-Id: I830ef189476e227e1dbe08157d34f96ad6453e30 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/254240 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Victor Boivie <boivie@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36157} 4 年前
forward_tsn_chunk.h
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
forward_tsn_chunk_test.cc
dcsctp: Don't deliver skipped messages If a FORWARD-TSN contains an ordered skipped stream with a large TSN but with a too small SSN, it can result in messages being assembled that should've been skipped. Typically: Receive DATA, ordered, complete, TSN=10, SID=1, SSN=0 - will be delivered. Receive DATA, ordered, complete, TSN=43, SID=1, SSN=7 - will stay in queue, due to missing SSN=1,2,3,4,5,6. Receive FORWARD-TSN, TSN=44, SSN=6 - is invalid, as the SSN should've been 7 or higher. However, as the TSN isn't used for removing messages in ordered streams, but just the SSN, the SSN=7 isn't removed but instead will be delivered as it's the next following SSN after 6. This will trigger internal consistency checks as a chunk with TSN=43 will be delivered when the current cumulative TSN is set to 44, which is greater. This was found when fuzzing, and can only be provoked by a client that is intentionally misbehaving. Before this fix, there was no harm done, but it failed consistency checks which fuzzers have enabled. When bug 13799 was fixed (in a previous commit), this allowed the fuzzers to find it faster. Bug: webrtc:13799 Change-Id: I830ef189476e227e1dbe08157d34f96ad6453e30 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/254240 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Victor Boivie <boivie@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36157} 4 年前
forward_tsn_common.h
dcsctp: Rename message_id to mid MID is a RFC8260 property on an I-DATA chunk, replacing the SSN property on the DATA chunk in non-interleaved message. The MID stands for "Message Identifier", and it was frequently named "message_id" in the source code, but sometimes "mid". To be consistent and using the same terminology as is most common in the RFC, use "mid" everywhere. This was triggered by the need to introduce yet another "message identifier" - but for now, this is just a refacotring CL. Bug: None Change-Id: I9cca898d9f3a2f162d6f2e4508ec1b4bc8d7308f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322500 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Victor Boivie <boivie@webrtc.org> Cr-Commit-Position: refs/heads/main@{#40876} 2 年前
heartbeat_ack_chunk.cc
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
heartbeat_ack_chunk.h
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
heartbeat_ack_chunk_test.cc
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
heartbeat_request_chunk.cc
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
heartbeat_request_chunk.h
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
heartbeat_request_chunk_test.cc
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
idata_chunk.cc
dcsctp: Rename message_id to mid MID is a RFC8260 property on an I-DATA chunk, replacing the SSN property on the DATA chunk in non-interleaved message. The MID stands for "Message Identifier", and it was frequently named "message_id" in the source code, but sometimes "mid". To be consistent and using the same terminology as is most common in the RFC, use "mid" everywhere. This was triggered by the need to introduce yet another "message identifier" - but for now, this is just a refacotring CL. Bug: None Change-Id: I9cca898d9f3a2f162d6f2e4508ec1b4bc8d7308f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322500 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Victor Boivie <boivie@webrtc.org> Cr-Commit-Position: refs/heads/main@{#40876} 2 年前
idata_chunk.h
dcsctp: Rename message_id to mid MID is a RFC8260 property on an I-DATA chunk, replacing the SSN property on the DATA chunk in non-interleaved message. The MID stands for "Message Identifier", and it was frequently named "message_id" in the source code, but sometimes "mid". To be consistent and using the same terminology as is most common in the RFC, use "mid" everywhere. This was triggered by the need to introduce yet another "message identifier" - but for now, this is just a refacotring CL. Bug: None Change-Id: I9cca898d9f3a2f162d6f2e4508ec1b4bc8d7308f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322500 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Victor Boivie <boivie@webrtc.org> Cr-Commit-Position: refs/heads/main@{#40876} 2 年前
idata_chunk_test.cc
dcsctp: Rename message_id to mid MID is a RFC8260 property on an I-DATA chunk, replacing the SSN property on the DATA chunk in non-interleaved message. The MID stands for "Message Identifier", and it was frequently named "message_id" in the source code, but sometimes "mid". To be consistent and using the same terminology as is most common in the RFC, use "mid" everywhere. This was triggered by the need to introduce yet another "message identifier" - but for now, this is just a refacotring CL. Bug: None Change-Id: I9cca898d9f3a2f162d6f2e4508ec1b4bc8d7308f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322500 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Victor Boivie <boivie@webrtc.org> Cr-Commit-Position: refs/heads/main@{#40876} 2 年前
iforward_tsn_chunk.cc
dcsctp: Rename message_id to mid MID is a RFC8260 property on an I-DATA chunk, replacing the SSN property on the DATA chunk in non-interleaved message. The MID stands for "Message Identifier", and it was frequently named "message_id" in the source code, but sometimes "mid". To be consistent and using the same terminology as is most common in the RFC, use "mid" everywhere. This was triggered by the need to introduce yet another "message identifier" - but for now, this is just a refacotring CL. Bug: None Change-Id: I9cca898d9f3a2f162d6f2e4508ec1b4bc8d7308f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322500 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Victor Boivie <boivie@webrtc.org> Cr-Commit-Position: refs/heads/main@{#40876} 2 年前
iforward_tsn_chunk.h
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
iforward_tsn_chunk_test.cc
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
init_ack_chunk.cc
dcsctp: Log integers as unsigned Bug: webrtc:12614 Change-Id: I08fa2d43671972a3115c09228a9cd089a53c5c89 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214341 Reviewed-by: Florent Castelli <orphis@webrtc.org> Commit-Queue: Victor Boivie <boivie@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33790} 5 年前
init_ack_chunk.h
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
init_ack_chunk_test.cc
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
init_chunk.cc
dcsctp: Log integers as unsigned Bug: webrtc:12614 Change-Id: I08fa2d43671972a3115c09228a9cd089a53c5c89 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214341 Reviewed-by: Florent Castelli <orphis@webrtc.org> Commit-Queue: Victor Boivie <boivie@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33790} 5 年前
init_chunk.h
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
init_chunk_test.cc
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
reconfig_chunk.cc
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
reconfig_chunk.h
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
reconfig_chunk_test.cc
dcsctp: Merge ReconfigResponseSN/ReconfigRequestSN Adding strong types went a little too far as these two types represent the same sequence number. A "request sequence number" is a number, that - when responded to - will be used as "response sequence number". Having them separate added confusion and just a lot of type-casting. Bug: webrtc:12614 Change-Id: I4636ea8f2252023a2d5a9b7033763e1978b1812e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214130 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33789} 5 年前
sack_chunk.cc
dcsctp: Report duplicate TSNs Reporting the duplicate TSNs is a SHOULD in the RFC, and using the duplicate TNSs is a MAY, and in reality I haven't seen an implementation use it yet. However, it's good for debugging and for stats generation. Bug: webrtc:12614 Change-Id: I1cc3f86961a8d289708cbf50d98dedfd25077955 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219462 Reviewed-by: Florent Castelli <orphis@webrtc.org> Commit-Queue: Victor Boivie <boivie@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34053} 4 年前
sack_chunk.h
dcsctp: Report duplicate TSNs Reporting the duplicate TSNs is a SHOULD in the RFC, and using the duplicate TNSs is a MAY, and in reality I haven't seen an implementation use it yet. However, it's good for debugging and for stats generation. Bug: webrtc:12614 Change-Id: I1cc3f86961a8d289708cbf50d98dedfd25077955 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219462 Reviewed-by: Florent Castelli <orphis@webrtc.org> Commit-Queue: Victor Boivie <boivie@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34053} 4 年前
sack_chunk_test.cc
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
shutdown_ack_chunk.cc
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
shutdown_ack_chunk.h
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
shutdown_ack_chunk_test.cc
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
shutdown_chunk.cc
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
shutdown_chunk.h
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
shutdown_chunk_test.cc
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
shutdown_complete_chunk.cc
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
shutdown_complete_chunk.h
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前
shutdown_complete_chunk_test.cc
dcsctp: Add parameters, error causes and chunks Quite a large commit, but mostly trivial. It adds all the (in dcSCTP) supported parameters, error causes and chunks as an object model, with serializers and deserializers. They are verified with packet captures where available, that have been captured with Wireshark against a reference implementation. This _could_ be split in parameter/ as one commit, error_cause/ in the following, and chunk/ as the third, but as each chunk/parameter is completely isolated from the other, reviewing it should be linear with the number of chunks/parameters and having them in more commits wouldn't change that, taken all those three commits into account. Bug: webrtc:12614 Change-Id: Ie83c9a22cae6e3a39e35ef26fd532837a6387a08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213347 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33625} 5 年前