已开启
docs:更新modal组件br_rnoh0.77分支的中英文文档 #29
docs:更新modal组件br_rnoh0.77分支的中英文文档 #29
已开启
fangzhen创建于 22 天前
fangzhen
fangzhen成员
22 天前

docs:更新modal组件br_rnoh0.77分支的中英文文档

likedislike
合并受阻
openharmony_ci
openharmony_ci成员
22 天前 评论:

感谢提交 Pull Requests !此PR未通过DCO校验。
校验失败可能原因:

1. 未签署“DCO协议”(开发者原创声明协议),在线签署、查看签署状态

2. Commits 中未包含 Signed-off-by信息,参考FAQ处理

修复上述问题后,在PR的评论框输入“check dco” ,单击”评论”,系统将再次进行DCO校验。

当前检测到如下Commits 未包含Signed-off-by信息:


Thanks for submitting a pull request. This pull request has not passed the DCO check.
Possible causes:

1. You have not signed the Developer Certificate of Origin (DCO). Sign the DCO and check DCO status.

2. The commits do not contain the Signed-off-by information. To resolve this issue, see FAQs.

After resolving the preceding issues, enter check dco in the comment box of this pull request and click Comment. The system will check DCO status again.

The following commits do not contain the Signed-off-by information:

likedislike
openharmony_ciopenharmony_ci成员
22 天前 添加了label:dco检查失败
cpf-manager
cpf-manager22 天前进行代码检视2
README.md
已过期
@@ -11,3 +11,3 @@
1111| 三方库名称 | 三方库版本(npm地址) | 发布信息 | 支持RN版本 | Autolink | 编译API版本 | 社区基线版本 | 源码地址 |
1212| ------------------------------------- | ------------------------------------------------------------ | ------------------------------------------------------------ | ----------------------- | -------- | ----------- | ------------ | ------------------------------------------------------------ |
13-| @react-native-ohos/react-native-modal | [~ 14.0.1](https://www.npmjs.com/package/@react-native-ohos/react-native-modal) | [Gitcode Releases](https://gitcode.com/CPF-RN/rntpc_react-native-modal/releases) | 0.77.\*/0.82.\*/0.84.\* | 否 | API12+ | 14.0.0-rc.1 | [master](https://gitcode.com/CPF-RN/rntpc_react-native-modal/tree/master) |
13+| @react-native-ohos/react-native-modal | [~ 14.0.1](https://www.npmjs.com/package/@react-native-ohos/react-native-modal) | [Gitcode Releases](https://gitcode.com/CPF-RN/rntpc_react-native-modal/releases) | 0.77 | 否 | API12+ | 14.0.0-rc.1 | [br_rnoh0.77](https://gitcode.com/fangyygw/rntpc_react-native-modal/tree/br_rnoh0.77) |
cpf-manager
cpf-manager22 天前评论:

【AI-Review】【一般】【基础代码问题】【代码逻辑错误】源码地址链接指向个人fork而非官方仓库

● 问题:README.md 第13行"源码地址"列由合并前的 [master](https://gitcode.com/CPF-RN/rntpc_react-native-modal/tree/master) 修改为 [br_rnoh0.77](https://gitcode.com/fangyygw/rntpc_react-native-modal/tree/br_rnoh0.77),链接指向 fangyygw 用户的个人 fork 仓库而非官方组织仓库 CPF-RN/rntpc_react-native-modal。本 PR 的 base 分支即为 CPF-RN/rntpc_react-native-modalbr_rnoh0.77 分支(PR 数据 base.ref=br_rnoh0.77,base.repo.full_name=CPF-RN/rntpc_react-native-modal),官方仓库存在该分支,无需跳转到个人 fork。

● 影响:一般。用户点击"源码地址"将跳转至贡献者个人 fork 而非官方源码仓库,存在以下风险:1) fork 被删除或重命名后链接失效;2) fork 可能滞后于官方仓库的最新提交;3) 与同一文档内其他链接(同行第13行的 Release Information、第241行 Issues/PRs、第245行 LICENSE)均指向 CPF-RN 官方仓库的设定不一致,造成文档内部矛盾。

● 建议:将链接保持指向官方仓库的 br_rnoh0.77 分支:[br_rnoh0.77](https://gitcode.com/CPF-RN/rntpc_react-native-modal/tree/br_rnoh0.77)

likedislike
System
系统消息系统
21 天前 评论:

changed this line on 7c310daf view diff detail

cpf-manager
cpf-manager22 天前进行代码检视2
README_en.md
已过期
@@ -11,3 +11,3 @@
1111| Name | Version(Npm Address) | Release Information | Supported RN Version | Supported Autolink | Compile API Version | Community Baseline Version | Source code address |
1212| ------------------------------------- | --------------------------------------------------------- | ------------------------------------------------------------ | ---------------------- | -------- | ------------------- | -------------------------- | ----------------------------------------------------------- |
13-| @react-native-ohos/react-native-modal | [~ 14.0.1](https://www.npmjs.com/package/@react-native-ohos/react-native-modal) | [Gitcode Releases](https://gitcode.com/CPF-RN/rntpc_react-native-modal/releases) | 0.77.\*/0.82.\*/0.84.\* | No | API12+ | 14.0.0-rc.1 | [master](https://gitcode.com/CPF-RN/rntpc_react-native-modal/tree/master) |
13+| @react-native-ohos/react-native-modal | [~ 14.0.1](https://www.npmjs.com/package/@react-native-ohos/react-native-modal) | [Gitcode Releases](https://gitcode.com/CPF-RN/rntpc_react-native-modal/releases) | 0.77 | No | API12+ | 14.0.0-rc.1 | [br_rnoh0.77](https://gitcode.com/fangyygw/rntpc_react-native-modal/tree/br_rnoh0.77) |
cpf-manager
cpf-manager22 天前评论:

【AI-Review】【一般】【基础代码问题】【代码逻辑错误】Source code address link points to personal fork instead of official repo

● 问题:Line 13 of README_en.md, the "Source code address" column was changed from [master](https://gitcode.com/CPF-RN/rntpc_react-native-modal/tree/master) to [br_rnoh0.77](https://gitcode.com/fangyygw/rntpc_react-native-modal/tree/br_rnoh0.77). The link now points to the fangyygw personal fork instead of the official CPF-RN/rntpc_react-native-modal repo. The official repo has the br_rnoh0.77 branch (this PR's base.ref=br_rnoh0.77, base.repo.full_name=CPF-RN/rntpc_react-native-modal), so jumping to the personal fork is unnecessary.

● 影响:一般。Users clicking "Source code address" will be redirected to the contributor's personal fork instead of the official source repo, with the following risks: 1) the link breaks if the fork is deleted or renamed; 2) the fork may lag behind the latest commits in the official repo; 3) it is inconsistent with other links in the same document (Release Information on the same line 13, Issues/PRs on line 241, LICENSE on line 245) which all point to the CPF-RN official repo.

● 建议:Keep the link pointing to the official repo's br_rnoh0.77 branch: [br_rnoh0.77](https://gitcode.com/CPF-RN/rntpc_react-native-modal/tree/br_rnoh0.77).

likedislike
System
系统消息系统
21 天前 评论:

changed this line on 7c310daf view diff detail

yangweiping
yangweiping21 天前进行代码检视1
README.md
@@ -12,3 +12,3 @@
1212| ------------------------------------- | ------------------------------------------------------------ | ------------------------------------------------------------ | ----------------------- | -------- | ----------- | ------------ | ------------------------------------------------------------ |
13-| @react-native-ohos/react-native-modal | [~ 14.0.1](https://www.npmjs.com/package/@react-native-ohos/react-native-modal) | [Gitcode Releases](https://gitcode.com/CPF-RN/rntpc_react-native-modal/releases) | 0.77.\*/0.82.\*/0.84.\* | 否 | API12+ | 14.0.0-rc.1 | [master](https://gitcode.com/CPF-RN/rntpc_react-native-modal/tree/master) |
13+| @react-native-ohos/react-native-modal | [~ 14.0.1](https://www.npmjs.com/package/@react-native-ohos/react-native-modal) | [Gitcode Releases](https://gitcode.com/CPF-RN/rntpc_react-native-modal/releases) | 0.77 | 否 | API12+ | 14.0.0-rc.1 | [br_rnoh0.77](https://gitcode.com/fangyygw/rntpc_react-native-modal/tree/br_rnoh0.77) |
1414 
fangzhenfangzhen成员
21 天前 强制推送  1 个提交:7c310daf-docs:更新modal组件br_rnoh0.77分支的中英文文档
openharmony_ci
openharmony_ci成员
21 天前 评论:

感谢提交 Pull Requests !此PR未通过DCO校验。
校验失败可能原因:

1. 未签署“DCO协议”(开发者原创声明协议),在线签署、查看签署状态

2. Commits 中未包含 Signed-off-by信息,参考FAQ处理

修复上述问题后,在PR的评论框输入“check dco” ,单击”评论”,系统将再次进行DCO校验。

当前检测到如下Commits 未包含Signed-off-by信息:


Thanks for submitting a pull request. This pull request has not passed the DCO check.
Possible causes:

1. You have not signed the Developer Certificate of Origin (DCO). Sign the DCO and check DCO status.

2. The commits do not contain the Signed-off-by information. To resolve this issue, see FAQs.

After resolving the preceding issues, enter check dco in the comment box of this pull request and click Comment. The system will check DCO status again.

The following commits do not contain the Signed-off-by information:

likedislike
cpf-manager
cpf-manager21 天前进行代码检视1
README.md
@@ -11,30 +11,30 @@
1111| 三方库名称 | 三方库版本(npm地址) | 发布信息 | 支持RN版本 | Autolink | 编译API版本 | 社区基线版本 | 源码地址 |
1212| ------------------------------------- | ------------------------------------------------------------ | ------------------------------------------------------------ | ----------------------- | -------- | ----------- | ------------ | ------------------------------------------------------------ |
13-| @react-native-ohos/react-native-modal | [~ 14.0.1](https://www.npmjs.com/package/@react-native-ohos/react-native-modal) | [Gitcode Releases](https://gitcode.com/CPF-RN/rntpc_react-native-modal/releases) | 0.77.\*/0.82.\*/0.84.\* | 否 | API12+ | 14.0.0-rc.1 | [master](https://gitcode.com/CPF-RN/rntpc_react-native-modal/tree/master) |
13+| @react-native-ohos/react-native-modal | [~ 14.0.1](https://www.npmjs.com/package/@react-native-ohos/react-native-modal) | [Gitcode Releases](https://gitcode.com/CPF-RN/rntpc_react-native-modal/releases) | 0.77 | 否 | API12+ | 14.0.0-rc.1 | [br_rnoh0.77](https://gitcode.com/CPF-RN/rntpc_react-native-modal/tree/br_rnoh0.77) |
1414 
1515## 简介
1616 
@@ -36,7 +36,7 @@ yarn add @react-native-ohos/react-native-modal
3636 
3737| | 是否支持autolink | RN框架版本 |
3838| ------- | ---------------- | -------------- |
39-| ~14.0.1 | No | 0.77/0.82/0.84 |
39+| ~14.0.1 | No | 0.77 |
4040 
4141## 约束与限制
4242 
@@ -45,8 +45,6 @@ yarn add @react-native-ohos/react-native-modal
4545本文档内容基于以下版本验证通过:
4646 
47471. RNOH: 0.77.18; SDK: HarmonyOS 6.0.0 Release SDK; IDE: DevEco Studio 6.0.0.858; ROM: 6.0.0.112;
48-2. RNOH: 0.82.1; SDK: HarmonyOS 6.0.1 Release SDK; IDE: DevEco Studio 6.0.1 Release; ROM:6.0.0.120 SP7;
49-3. RNOH: 0.84.2; SDK: HarmonyOS 6.0.1 Release SDK; IDE: DevEco Studio 26.0.0 Beta1; ROM:6.0.0.120 SP7;
5048 
5149 ## 使用示例
5250 
@@ -244,247 +242,247 @@
244242> 文档模板:v0.4.2
245243 
246244<p align="center">
247245 <h1 align="center"> <code>react-native-modal</code> </h1>
cpf-manager
cpf-manager21 天前评论:

【AI-Review】【建议】【基础代码问题】【可读性问题】License 链接未同步更新为 br_rnoh0.77 分支

● 问题: README.md 第 245 行 License 链接仍指向 master 分支(https://gitcode.com/CPF-RN/rntpc_react-native-modal/blob/master/LICENSE)。本次 PR 第 13 行"源码地址"链接已由 master 分支更新为 br_rnoh0.77 分支(https://gitcode.com/CPF-RN/rntpc_react-native-modal/tree/br_rnoh0.77),但同一文档中 License 链接未同步更新,两处分支引用不一致。

● 影响: 建议。当前仓库分支列表包含 master、br_rnoh0.77、br_rnoh0.72、br_rnoh0.61,master 分支存在,LICENSE 文件可达,链接功能正常。但本次 PR 目标为将文档分支引用统一迁移至 br_rnoh0.77(PR 标题:"更新modal适配br_rnoh0.77分支"),License 链接未同步更新属于本次迁移遗漏项。若未来 master 分支被删除或 LICENSE 路径调整,该链接会失效;且与第 13 行已更新的源码地址链接存在分支指向不一致。

● 建议: 将第 245 行 License 链接同步更新为 br_rnoh0.77 分支:https://gitcode.com/CPF-RN/rntpc_react-native-modal/blob/br_rnoh0.77/LICENSE,与第 13 行源码地址链接保持分支一致。

likedislike
cpf-manager
cpf-manager21 天前进行代码检视1
README_en.md
@@ -11,30 +11,30 @@
1111| Name | Version(Npm Address) | Release Information | Supported RN Version | Supported Autolink | Compile API Version | Community Baseline Version | Source code address |
1212| ------------------------------------- | --------------------------------------------------------- | ------------------------------------------------------------ | ---------------------- | -------- | ------------------- | -------------------------- | ----------------------------------------------------------- |
13-| @react-native-ohos/react-native-modal | [~ 14.0.1](https://www.npmjs.com/package/@react-native-ohos/react-native-modal) | [Gitcode Releases](https://gitcode.com/CPF-RN/rntpc_react-native-modal/releases) | 0.77.\*/0.82.\*/0.84.\* | No | API12+ | 14.0.0-rc.1 | [master](https://gitcode.com/CPF-RN/rntpc_react-native-modal/tree/master) |
13+| @react-native-ohos/react-native-modal | [~ 14.0.1](https://www.npmjs.com/package/@react-native-ohos/react-native-modal) | [Gitcode Releases](https://gitcode.com/CPF-RN/rntpc_react-native-modal/releases) | 0.77 | No | API12+ | 14.0.0-rc.1 | [br_rnoh0.77](https://gitcode.com/CPF-RN/rntpc_react-native-modal/tree/br_rnoh0.77) |
1414 
1515## Introduction
1616 
@@ -36,7 +36,7 @@ yarn add @react-native-ohos/react-native-modal
3636 
3737| | Supported Autolink | Supported RN Version |
3838| ------- | ------------------ | -------------------- |
39-| ~14.0.1 | No | 0.77/0.82/0.84 |
39+| ~14.0.1 | No | 0.77 |
4040 
4141## Constraints
4242 
@@ -45,8 +45,6 @@ yarn add @react-native-ohos/react-native-modal
4545This document is verified based on the following versions:
4646 
47471. RNOH: 0.77.18; SDK: HarmonyOS 6.0.0 Release SDK; IDE: DevEco Studio 6.0.0.858; ROM: 6.0.0.112;
48-2. RNOH: 0.82.1; SDK: HarmonyOS 6.0.1 Release SDK; IDE: DevEco Studio 6.0.1 Release; ROM:6.0.0.120 SP7;
49-3. RNOH: 0.84.2; SDK: HarmonyOS 6.0.1 Release SDK; IDE: DevEco Studio 26.0.0 Beta1; ROM:6.0.0.120 SP7;
5048 
5149 ## Example
5250 
@@ -244,248 +242,248 @@
244242> Document Template: v0.4.2
245243 
246244<p align="center">
247245 <h1 align="center"> <code>react-native-modal</code> </h1>
cpf-manager
cpf-manager21 天前评论:

【AI-Review】【建议】【基础代码问题】【可读性问题】License link not updated to br_rnoh0.77 branch

● 问题: On line 245 of README_en.md, the License link still points to the master branch (https://gitcode.com/CPF-RN/rntpc_react-native-modal/blob/master/LICENSE). This PR has already updated the "Source code address" link on line 13 from the master branch to the br_rnoh0.77 branch (https://gitcode.com/CPF-RN/rntpc_react-native-modal/tree/br_rnoh0.77), but the License link in the same document was not synchronized, resulting in inconsistent branch references.

● 影响: Suggestion. The repo's branch list includes master, br_rnoh0.77, br_rnoh0.72, and br_rnoh0.61. The master branch exists and the LICENSE file is accessible, so the link works. However, the PR's purpose is to migrate branch references to br_rnoh0.77 (PR title: "更新modal适配br_rnoh0.77分支"), and the License link was not updated as part of this migration. If the master branch is deleted in the future or the LICENSE path changes, the link will break; it is also inconsistent with the updated source code address link on line 13.

● 建议: Update the License link on line 245 to the br_rnoh0.77 branch: https://gitcode.com/CPF-RN/rntpc_react-native-modal/blob/br_rnoh0.77/LICENSE, keeping it consistent with the source code address link on line 13.

likedislike