| Files | Last commit | Last update |
|---|---|---|
fix(fuzzing): return 0 (not 1) from the size guard in every harness (#3579) LLVMFuzzerTestOneInput may only return 0 (input consumed) or -1 (input rejected); libFuzzer asserts this after every call (compiler-rt/lib/fuzzer/FuzzerLoop.cpp:622) and runs the empty input first, so every harness here aborts an assert-enabled libFuzzer at startup. Returning 0 keeps out-of-range inputs out of the corpus (the harness body is still skipped) and matches the convention newer harnesses already use. All 18 test/fuzzing/fuzz_*.cpp harnesses share the same guard. Signed-off-by: li-lizhe <147392333@qq.com> | 1 month ago | |
Support seqlock and use it for TaskGroup CPU time stat (#3541) | 2 months ago | |
Support seqlock and use it for TaskGroup CPU time stat (#3541) | 2 months ago | |
Support seqlock and use it for TaskGroup CPU time stat (#3541) | 2 months ago | |
[mysql] Clean-room auth handshake codec (scramble + handshake + packet, Stage 1a of #2093) (#3310) * feat(mysql): clean-room auth-handshake codec (scramble + handshake + packet) Picks up the connection-phase authentication layer of MySQL protocol support per the staged plan announced on dev@brpc.apache.org and PR #2093. Three modules under src/brpc/policy/mysql_auth/: - mysql_auth_scramble: mysql_native_password (SHA1 XOR), plus caching_sha2_password fast path (SHA256 XOR) and slow path with both branches: - RSA-OAEP via OpenSSL EVP_PKEY_encrypt + PKCS1_OAEP_PADDING - TLS-cleartext (NUL-terminated password) selected at runtime via CachingSha2PasswordSlowPath(..., bool is_ssl = false). Default is_ssl=false preserves RSA behavior for callers not yet threaded with the connection's TLS state. - mysql_auth_packet: length-encoded int/string, 4-byte packet header, NUL-terminated string. - mysql_auth_handshake: HandshakeV10 parse, HandshakeResponse41 build, AuthSwitchRequest parse, AuthMoreData parse. All written clean-room from MySQL's public protocol documentation; no GPL-licensed source was consulted. SHA-256 and RSA paths use OpenSSL EVP -- works under both OpenSSL and BoringSSL. 75 unit tests across three files under test/mysql_auth/: 36 in brpc_mysql_auth_scramble_unittest.cpp 19 in brpc_mysql_auth_handshake_unittest.cpp 20 in brpc_mysql_auth_packet_unittest.cpp Mirrors every client-relevant case from mysql/mysql-server's GPLv2 unittest/gunit/sha2_password-t.cc + sha256_scramble_t.cc with independently re-derived hex vectors. Server-side cases (cache, storage format, *_verification_*) are out of scope for a client library; full mapping table linked from the PR description. Scope limits in this CL: auth codec only. No PROTOCOL_MYSQL registration, no Socket integration, no compressed packets, no prepared statements, no transactions. All land in the follow-up CL. TLS state plumbing in Stage 1c flows the dispatcher's Socket::is_ssl() into the trailing argument here -- no further API change. Replaces the earlier src/brpc/policy/mysql_auth_hash.{h,cpp} + test/brpc_mysql_auth_hash_unittest.cpp; those files are moved into the new mysql_auth/ subdirectory and renamed. * fix(mysql): handle lenenc NULL (0xFB) and reject oversize auth_response Address review findings on the Stage-1a auth codec (#3310): - DecodeLengthEncodedInt/String: 0xFB is the protocol NULL marker, not an error. Decode it as NULL (1 byte consumed) via a new optional bool* is_null out-param instead of folding it into the failure path, so the shared codec can faithfully parse resultsets containing NULL. Define *out/*is_null on every path and use an overflow-safe bounds check. - BuildHandshakeResponse41: the CLIENT_SECURE_CONNECTION 1-byte length prefix cannot represent an auth_response >255 bytes. Fail hard (return bool false, write nothing, LOG(ERROR)) instead of silently truncating, which produced an invalid response and desynchronized the packet stream. Callers with larger payloads must negotiate CLIENT_PLUGIN_AUTH_LENENC_CLIENT_DATA. Adds unit tests for the NULL marker (int + string) and for the oversize reject / 255-byte boundary cases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore(mysql): add diagnostic error logs on auth-codec failure paths Per review (chenBright on #3310): the handshake/packet parsers returned false/0 silently on malformed, truncated, or unsupported input, giving no clue why a connection failed. Add a LOG(ERROR) at each failure path naming the function and the concrete cause (truncated <field>, pre-4.1 server, reserved 0xFF marker, length mismatch, etc.). Logic unchanged — only logs inserted; the lenenc NULL (0xFB) success path is intentionally not logged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore(mysql): demote lenenc-codec diagnostic logs to LOG(WARNING) The length-encoded int/string/header decode failures fire during normal resultset parsing and are not catastrophic, so log them at WARNING rather than ERROR. Handshake-parse failures stay at LOG(ERROR) (a malformed handshake is a fatal connection-setup failure). Severity-only change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(mysql): build and run mysql/ unittests in Makefile CI path test/Makefile and test/run_tests.sh drive the make-based CI lane (clang-unittest: cd test && make then sh ./run_tests.sh). Both used non-recursive globs anchored at test/, so the new tests under test/mysql/ were neither compiled nor executed there — only the CMake and Bazel lanes picked them up. The make lane was silently green without running them. - Makefile: add $(wildcard mysql/brpc_*unittest.cpp) to TEST_BRPC_SOURCES, plus a mysql/brpc_%_unittest: link rule (the existing brpc_%_unittest: pattern anchors on a literal brpc_ prefix and won't match a mysql/ target). - run_tests.sh: add mysql/brpc*unittest to the executed set and enable nullglob so a missing subdir expands to nothing instead of a bogus name. Addresses @chenBright's review note that test/Makefile is used by CI and must be updated for the new MySQL tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(test): make AuthCase a C++11 aggregate so push_back{...} compiles CI compiles the unittests with -std=c++0x (C++11). The test helper struct AuthCase had a default member initializer (bool use_ssl = false), which makes a class a non-aggregate under C++11 (the rule was only relaxed in C++14). That broke every g_auth_cases.push_back({label,user,password,ssl}) with "no matching member function for call to 'push_back'", failing the clang-unittest and clang-unittest-asan compile-tests step. Drop the default member initializer; all five init sites already pass use_ssl explicitly, so behavior is unchanged and the struct is again an aggregate that accepts braced-init under C++11. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(build): compile src/brpc/policy/mysql into libbrpc in the Makefile The Makefile builds libbrpc by globbing $(d)/* over BRPC_DIRS, and the glob is non-recursive, so src/brpc/policy/mysql/*.cpp was never compiled into the library. The make-based CI lanes (clang-unittest, clang-unittest-asan) therefore failed to link the mysql unittests with "undefined reference to brpc::policy::mysql::*" for every codec symbol. CMake (file(GLOB_RECURSE src/brpc/*.cpp)) and Bazel already pick the directory up, which is why only the make lanes broke once the mysql tests were wired into that lane. Add src/brpc/policy/mysql to BRPC_DIRS so the codec sources land in libbrpc. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(mysql): move auth unittests from mysql/ subdir into test/ Move the three clean-room auth unittests (handshake, packet, scramble) and their test-plan doc out of test/mysql/ into test/, per review on apache/brpc#3310. The existing brpc_*_unittest glob in the Makefile, CMakeLists.txt and BUILD.bazel now picks them up, so all three build scripts revert to master with no mysql-specific additions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(mysql): drop run_tests.sh mysql/ subdir entry after move The auth unittests now live in test/ and match the existing brpc*unittest glob in run_tests.sh, so revert the script to master. The removed mysql/brpc*unittest entry needed shopt -s nullglob to skip a missing subdir, but CI runs the script under sh (dash), where shopt is absent; nullglob stayed off and the now-empty glob was executed as a literal path, exiting 127. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> | 5 months ago | |
support gc for ListOfABAFreeId (#2479) | 2 years ago | |
json2pb::JsonToProtoMessage() supports parsing multiple jsons | 4 years ago | |
insert_apache_header | 6 years ago | |
insert_apache_header | 6 years ago | |
Support ProtoJson formatted http body (#2921) | 1 year ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Support url safe base64 (#2337) * Support url safe base64 * Update base64url license * Update base64url license | 3 years ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Fix static initialization order fiasco in AdaptiveMaxConcurrency (#3315) AdaptiveMaxConcurrency has two class-static std::string members (UNLIMITED and CONSTANT) defined in adaptive_max_concurrency.cpp. Global AdaptiveMaxConcurrency objects in other translation units may be constructed before these static strings are initialized, causing undefined behavior. This issue was discovered during RISC-V porting and testing of BRPC. Different toolchains and linkers (GCC, Clang, cross-compilation toolchains for RISC-V, etc.) may produce different static initialization orders, making this bug manifest on some platforms but not others. Fix by replacing class-static std::string members with Meyers' Singleton pattern (function-local statics), which C++11 guarantees are initialized on first use in a thread-safe manner. This fix benefits all architectures including x86_64, ARM64, and RISC-V. Signed-off-by: Felix-Gong <gongxiaofei24@iscas.ac.cn> | 5 months ago | |
Fix port conflicts in parallel unit tests (#3568) * Fix port conflicts in parallel unit tests * Isolate naming service test state | 1 month ago | |
Use monotonic time instead of wall time (#3268) | 7 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
validate query parameters echoed into builtin html pages (#3589) /hotspots/* wrote view and base into its inline script without the ValidProfilePath check that its *_non_responsive handler already applies, and /rpcz printed the pointer of the time parameter instead of the escaped value. | 1 month ago | |
Add bounded-load consistent hashing load balancer (c_murmurhash_bl) (#3502) Classic consistent hashing routes a hot key to one server with no relief valve: that server saturates while its ring neighbors idle. c_murmurhash_bl implements "Consistent Hashing with Bounded Loads" (Mirrokni et al., CACM 2017) on the same murmurhash ring: each server accepts at most ceil(load_factor * average in-flight) requests, and an at-capacity server overflows clockwise to the next server with spare capacity, so spilled requests always land on the same ring successors. load_factor defaults to -chash_bounded_load_factor(1.25, validated > 1) and is overridable per channel: c_murmurhash_bl:load_factor=1.5. In-flight accounting uses relaxed per-server counters shared by both DoublyBufferedData buffers, incremented at selection and decremented in Feedback(); the total is restored even if the server was removed in between, and the counter map is resynced from the ring on membership changes. The ring code is reused by subclassing ConsistentHashingLoadBalancer via a per-key SetParameter() hook. The existing `replicas' parameter is now documented for all CH schemes, settling the old "TODO: or 160?" on the replica count. Includes unit tests (cap under hot-key load, overflow to ring successor, factor validation, feedback decrement, removal consistency, replicas parameter) and docs in cn/en client.md. Co-authored-by: rajvarun77 <287367605+rajvarun77@users.noreply.github.com> | 2 months ago | |
Validate RPC response sockets (#3580) * Validate RPC response sockets Check that responses arrive on the socket used by the matching request attempt before updating the controller. Account for current attempts and unfinished backup requests across the four protobuf RPC protocols. Add Hulu response tests for matching and mismatched sockets while keeping direct response injection compatible with existing internal callers. * Expand RPC response socket test coverage Verify rejection and subsequent completion on the sending socket for baidu_std, sofa_pbrpc, and public_pbrpc response handlers. Exercise real channel/server calls across all four affected protocols and their supported connection types using an ephemeral server port. * Tighten rejected RPC response handling Accept the base correlation ID only for direct response injection without a sending socket. Real requests must match a versioned attempt ID. Reset all advertised streams on the arrival socket when rejecting a baidu_std response. Extend the regression test to check both rejection paths and successful completion by the valid response. | 1 month ago | |
Fix port conflicts in parallel unit tests (#3568) * Fix port conflicts in parallel unit tests * Isolate naming service test state | 1 month ago | |
Ignore canceled requests in the circuit breaker (#3532) | 2 months ago | |
test: wait for submitted spans to be collected (#3448) Wait for the asynchronous span collector to release root client spans after Controller reset or submission. This prevents LeakSanitizer from reporting pending test spans when the short-lived test binary exits before the collector’s first polling interval. Signed-off-by: Zhengwei Zhu <141622927+ZhengweiZhu@users.noreply.github.com> | 3 months ago | |
Fix port conflicts in parallel unit tests (#3568) * Fix port conflicts in parallel unit tests * Isolate naming service test state | 1 month ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Fix port conflicts in parallel unit tests (#3568) * Fix port conflicts in parallel unit tests * Isolate naming service test state | 1 month ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Harden HTTP/2 receive path against unbounded resource growth (#3474) * Harden HTTP/2 receive path against unbounded resource growth The HTTP/2 (h2) parser advertised several receive-side limits that were never enforced, letting one hostile peer grow process memory without bound: - SETTINGS_MAX_CONCURRENT_STREAMS defaulted to unlimited and was never checked on the server; every odd stream id was accepted, so a peer could pin an unbounded number of streams per connection. The default is now a bounded 1024 and the server rejects streams beyond it with RST_STREAM(REFUSED_STREAM). - SETTINGS_MAX_HEADER_LIST_SIZE defaulted to unlimited and was never enforced on receive; decoded headers amplified by 1-byte HPACK indexed references ("HPACK bomb") and never-completed HEADERS/CONTINUATION fragments accumulated without bound. Both are now capped at a 1MB default. - The HPACK dynamic table size update was validated against the protocol default instead of the size this endpoint advertised, so a decoder configured with a smaller table could be forced to grow it beyond the capacity it was sized for. Updates above the advertised beyond the capacity it was sized for. Updates above the advertisedondi beyond the capacity it was sized for. Updates above the advertisg P beyETT beyond the capacity it was sized for. Updates above the advertisy wit beyond the capacity it was sized for. Updates above the advertisek_ beyond the capacity it was sized for. Updates above the advertisis de beyond the capacity it was sized for. Updates above the advertisedse beyond the capacity it wasfo beyond the capacity it was sized for. Updates above the adver continuing to parse whatever the peer keeps sending. Tests: new casesTests: new casesTests: new casesTests: new casesTests: nest cover each enforcement; the full brpc_hpack_unittest, brpc_http_rpc_protocol_unittest, brpc_h2_unsent_message_unittest and brpc_grpc_protocol_unittest suites pass. * Reset h2 header-list budget per header block and cap initial HEADERS fragment Two follow-up fixes from code review of the HTTP/2 receive-path hardening: - The decoded header-list size counter was never reset when a new HEADERS block began, so trailers on the same stream inherited the budget of the initial header list and could be rejected even though they form a separate list (RFC 7540 section 10.5.1 applies per header block). Reset the counter at the start of OnHeaders; it stays cumulative across the CONTINUATION frames that complete the same block. - The _remaining_header_fragment size cap was only checked when CONTINUATION frames were processed, but a single oversized HEADERS frame appends its unconsumed tail into the fragment too. Apply the same cap in OnHeaders via a shared HeaderFragmentTooLarge() helper and fail with ENHANCE_YOUR_CALM. Tests: brpc_http_rpc_protocol_unittest gains two cases (h2_header_list_budget_resets_per_block and h2_oversized_single_headers_bloh2_oversized_single_headers_bloh2_oversized_single_headers_bloh2_oversized_single_headers_b_message_unittest and brpc_grpc_protocol_unittest suites pass. | 2 months ago | |
Fix port conflicts in parallel unit tests (#3568) * Fix port conflicts in parallel unit tests * Isolate naming service test state | 1 month ago | |
Update license header to Apache | 7 years ago | |
Bound the number of http headers and query parameters per message (#3524) | 2 months ago | |
Update license header to Apache | 7 years ago | |
Validate RPC response sockets (#3580) * Validate RPC response sockets Check that responses arrive on the socket used by the matching request attempt before updating the controller. Account for current attempts and unfinished backup requests across the four protobuf RPC protocols. Add Hulu response tests for matching and mismatched sockets while keeping direct response injection compatible with existing internal callers. * Expand RPC response socket test coverage Verify rejection and subsequent completion on the sending socket for baidu_std, sofa_pbrpc, and public_pbrpc response handlers. Exercise real channel/server calls across all four affected protocols and their supported connection types using an ephemeral server port. * Tighten rejected RPC response handling Accept the base correlation ID only for direct response injection without a sending socket. Real requests must match a versioned attempt ID. Reset all advertised streams on the arrival socket when rejecting a baidu_std response. Extend the regression test to check both rejection paths and successful completion by the valid response. | 1 month ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Run Bazel tests in parallel in CI (#3482) * Run Bazel tests in parallel in CI * Use an ephemeral port in interceptor test * Use an ephemeral port in HTTP expect test * Set protobuf JSON test timeout explicitly * Use an ephemeral port in endpoint test * Use an ephemeral port in oversized message test * Isolate additional timing-sensitive Bazel tests Run the channel and SSL test binaries exclusively. They rely on strict timing or process-wide networking state and can fail when competing with parallel test processes. * Avoid restoring incompatible Bazel caches Limit fallback restoration to caches produced by the same CI job. The broad fallback could restore a cache from a different compiler or protobuf setup, which produced no hits while consuming transfer time and cache capacity. | 2 months ago | |
Reject truncated consistent hashing replica keys (#3585) Check snprintf results before hashing replica keys in the default and Ketama policies. Reject formatting errors and truncated keys without partially updating the hash ring. Keep existing mappings for keys that fit the buffer. Cover key-length boundaries, batch additions, and disabled tag hashing for Murmur3, MD5, and Ketama. | 1 month ago | |
Reject malformed mcpack input instead of CHECK-fatal in parser (#3576) * Reject malformed mcpack input instead of CHECK-fatal in parser The mcpack2pb parser used CHECK(false) to handle malformed input in unbox(), the object/array/isoarray iterators and the value conversion functions. CHECK(false) logs at FATAL level and aborts the process when -crash_on_fatal_log is on, so a single malformed nshead+mcpack request could terminate a server and drop all in-flight requests (CWE-617). Replace the wire-controlled CHECK(false) sites with LOG(ERROR) plus the existing error propagation (set_bad()/return 0, which the generated parsing code checks), and mark the stream bad in unbox() and the truncated as_string()/as_binary() paths so failed parses are reported by stream()->good() as before. The serializer and code-generator CHECKs are untouched since they are not driven by network input. * Avoid wire-controlled eager resize in as_string/as_binary Follow-up to the CHECK(false) hardening: the claimed value size of string/binary fields comes from the wire and can be close to UINT32_MAX. resize(size) before reading allocates that amount up front, so a tiny request could trigger an uncaught std::bad_alloc/std::length_error and still terminate the process. Read in bounded chunks and grow the output only for bytes that are actually present; a short read marks the stream bad as before. * Reject truncated primitive reads in cut_packed_pod The value-returning InputStream::cut_packed_pod<T>() left its result uninitialized when cutn() read fewer than sizeof(T) bytes, which is reachable when the enclosing object declares enough bytes but the real input ends inside a primitive value. The indeterminate value was then consumed or logged (UB), and the parse continued as if the input were complete. Zero-initialize the result, return a zero value and mark the stream bad on a short read, so the generated code fails the parse. The pointer version is unchanged: its callers already check the returned size. * Validate the trailing NUL when reading mcpack strings as_string() skipped the trailing byte with popn(1), which returns 0 on an exhausted stream and leaves it good. A string whose content was present but whose stream ended exactly before the required trailing '\0' (or ended with a non-NUL byte) was therefore accepted as valid. Read the terminator and reject the input when it is missing or not a NUL, marking the stream bad and clearing the output. * Avoid double copy of valid string/binary payload cut_bytes_to_string() copied every byte twice on valid input: once from the input into a stack buffer and once into the destination string. Grow the destination by at most one 8 KiB chunk at a time and cut directly into it, restoring the single-copy behavior of the original resize+cutn path while keeping the bounded allocation. --------- Co-authored-by: brpc-oncall <brpc-oncall@localhost> | 1 month ago | |
Fix use-after-free of response header in ParseMemcacheMessage (#3572) | 1 month ago | |
Serve builtin services only on ServerOptions.internal_port (#3525) | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
[mysql] Clean-room auth handshake codec (scramble + handshake + packet, Stage 1a of #2093) (#3310) * feat(mysql): clean-room auth-handshake codec (scramble + handshake + packet) Picks up the connection-phase authentication layer of MySQL protocol support per the staged plan announced on dev@brpc.apache.org and PR #2093. Three modules under src/brpc/policy/mysql_auth/: - mysql_auth_scramble: mysql_native_password (SHA1 XOR), plus caching_sha2_password fast path (SHA256 XOR) and slow path with both branches: - RSA-OAEP via OpenSSL EVP_PKEY_encrypt + PKCS1_OAEP_PADDING - TLS-cleartext (NUL-terminated password) selected at runtime via CachingSha2PasswordSlowPath(..., bool is_ssl = false). Default is_ssl=false preserves RSA behavior for callers not yet threaded with the connection's TLS state. - mysql_auth_packet: length-encoded int/string, 4-byte packet header, NUL-terminated string. - mysql_auth_handshake: HandshakeV10 parse, HandshakeResponse41 build, AuthSwitchRequest parse, AuthMoreData parse. All written clean-room from MySQL's public protocol documentation; no GPL-licensed source was consulted. SHA-256 and RSA paths use OpenSSL EVP -- works under both OpenSSL and BoringSSL. 75 unit tests across three files under test/mysql_auth/: 36 in brpc_mysql_auth_scramble_unittest.cpp 19 in brpc_mysql_auth_handshake_unittest.cpp 20 in brpc_mysql_auth_packet_unittest.cpp Mirrors every client-relevant case from mysql/mysql-server's GPLv2 unittest/gunit/sha2_password-t.cc + sha256_scramble_t.cc with independently re-derived hex vectors. Server-side cases (cache, storage format, *_verification_*) are out of scope for a client library; full mapping table linked from the PR description. Scope limits in this CL: auth codec only. No PROTOCOL_MYSQL registration, no Socket integration, no compressed packets, no prepared statements, no transactions. All land in the follow-up CL. TLS state plumbing in Stage 1c flows the dispatcher's Socket::is_ssl() into the trailing argument here -- no further API change. Replaces the earlier src/brpc/policy/mysql_auth_hash.{h,cpp} + test/brpc_mysql_auth_hash_unittest.cpp; those files are moved into the new mysql_auth/ subdirectory and renamed. * fix(mysql): handle lenenc NULL (0xFB) and reject oversize auth_response Address review findings on the Stage-1a auth codec (#3310): - DecodeLengthEncodedInt/String: 0xFB is the protocol NULL marker, not an error. Decode it as NULL (1 byte consumed) via a new optional bool* is_null out-param instead of folding it into the failure path, so the shared codec can faithfully parse resultsets containing NULL. Define *out/*is_null on every path and use an overflow-safe bounds check. - BuildHandshakeResponse41: the CLIENT_SECURE_CONNECTION 1-byte length prefix cannot represent an auth_response >255 bytes. Fail hard (return bool false, write nothing, LOG(ERROR)) instead of silently truncating, which produced an invalid response and desynchronized the packet stream. Callers with larger payloads must negotiate CLIENT_PLUGIN_AUTH_LENENC_CLIENT_DATA. Adds unit tests for the NULL marker (int + string) and for the oversize reject / 255-byte boundary cases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore(mysql): add diagnostic error logs on auth-codec failure paths Per review (chenBright on #3310): the handshake/packet parsers returned false/0 silently on malformed, truncated, or unsupported input, giving no clue why a connection failed. Add a LOG(ERROR) at each failure path naming the function and the concrete cause (truncated <field>, pre-4.1 server, reserved 0xFF marker, length mismatch, etc.). Logic unchanged — only logs inserted; the lenenc NULL (0xFB) success path is intentionally not logged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore(mysql): demote lenenc-codec diagnostic logs to LOG(WARNING) The length-encoded int/string/header decode failures fire during normal resultset parsing and are not catastrophic, so log them at WARNING rather than ERROR. Handshake-parse failures stay at LOG(ERROR) (a malformed handshake is a fatal connection-setup failure). Severity-only change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(mysql): build and run mysql/ unittests in Makefile CI path test/Makefile and test/run_tests.sh drive the make-based CI lane (clang-unittest: cd test && make then sh ./run_tests.sh). Both used non-recursive globs anchored at test/, so the new tests under test/mysql/ were neither compiled nor executed there — only the CMake and Bazel lanes picked them up. The make lane was silently green without running them. - Makefile: add $(wildcard mysql/brpc_*unittest.cpp) to TEST_BRPC_SOURCES, plus a mysql/brpc_%_unittest: link rule (the existing brpc_%_unittest: pattern anchors on a literal brpc_ prefix and won't match a mysql/ target). - run_tests.sh: add mysql/brpc*unittest to the executed set and enable nullglob so a missing subdir expands to nothing instead of a bogus name. Addresses @chenBright's review note that test/Makefile is used by CI and must be updated for the new MySQL tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(test): make AuthCase a C++11 aggregate so push_back{...} compiles CI compiles the unittests with -std=c++0x (C++11). The test helper struct AuthCase had a default member initializer (bool use_ssl = false), which makes a class a non-aggregate under C++11 (the rule was only relaxed in C++14). That broke every g_auth_cases.push_back({label,user,password,ssl}) with "no matching member function for call to 'push_back'", failing the clang-unittest and clang-unittest-asan compile-tests step. Drop the default member initializer; all five init sites already pass use_ssl explicitly, so behavior is unchanged and the struct is again an aggregate that accepts braced-init under C++11. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(build): compile src/brpc/policy/mysql into libbrpc in the Makefile The Makefile builds libbrpc by globbing $(d)/* over BRPC_DIRS, and the glob is non-recursive, so src/brpc/policy/mysql/*.cpp was never compiled into the library. The make-based CI lanes (clang-unittest, clang-unittest-asan) therefore failed to link the mysql unittests with "undefined reference to brpc::policy::mysql::*" for every codec symbol. CMake (file(GLOB_RECURSE src/brpc/*.cpp)) and Bazel already pick the directory up, which is why only the make lanes broke once the mysql tests were wired into that lane. Add src/brpc/policy/mysql to BRPC_DIRS so the codec sources land in libbrpc. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(mysql): move auth unittests from mysql/ subdir into test/ Move the three clean-room auth unittests (handshake, packet, scramble) and their test-plan doc out of test/mysql/ into test/, per review on apache/brpc#3310. The existing brpc_*_unittest glob in the Makefile, CMakeLists.txt and BUILD.bazel now picks them up, so all three build scripts revert to master with no mysql-specific additions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(mysql): drop run_tests.sh mysql/ subdir entry after move The auth unittests now live in test/ and match the existing brpc*unittest glob in run_tests.sh, so revert the script to master. The removed mysql/brpc*unittest entry needed shopt -s nullglob to skip a missing subdir, but CI runs the script under sh (dash), where shopt is absent; nullglob stayed off and the now-empty glob was executed as a literal path, exiting 127. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> | 5 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Reject truncated length-encoded integers in MySQL reply parser (#3575) * Reject truncated length-encoded integers in MySQL reply parser parse_encode_length did not check the return value of IOBuf::cutn, so a truncated 0xFC/0xFD/0xFE prefix left part of the stack buffer uninitialized and mysql_uint*korr interpreted that garbage as the value. A malicious server could turn it into bogus column counts, field lengths or loop counts. Check cut1/cutn and return -1 on truncated or invalid input; all call sites now fail with PARSE_ERROR_ABSOLUTELY_WRONG and the six duplicated column-string blocks are folded into one helper. * Bound MySQL packet parsing to the packet payload Address review feedback on the length-encoded integer hardening: 1. parse_header now optionally cuts the packet payload into a separate IOBuf and every sub-parser decodes from that bounded buffer, so a truncated field can no longer borrow bytes from a coalesced next packet and silently desync the stream. 2. parse_encode_length returns bool with a uint64_t out-param instead of an int64_t sentinel, which rejected legitimate values above INT64_MAX (e.g. a 2^64-1 affected-rows count in OK packets). Add regression tests for a truncated prefix followed by a coalesced packet and for the maximum encodable affected-rows value. * Fix MySQL reply dispatch for multi-byte column counts Address review feedback: the dispatcher matched the first payload byte against synthetic MysqlRspType values, so a result set whose column count used the multi-byte 0xFC form (252..65535 columns) was misclassified as a prepare-ok and fed to unchecked fixed-width header reads; 0xFB/0xFD counts hit the unknown-type fallback; and every 0xFE-leading packet was treated as EOF although MySQL only treats a SHORT (< 9 payload bytes) 0xFE packet as EOF. - Dispatch fresh wire bytes 0x01..0xFE to the result-set parser; prepare-ok resume is keyed on |_type| instead of the wire byte. - is_an_eof and the dispatcher now require payload < 9 for EOF, so a row starting with an 8-byte length-encoded value is a row. - All remaining unchecked fixed-width cuts (prepare-ok header, column fixed fields, OK status/warnings, EOF, ERR sql-state, auth fixed fields and NUL-terminated strings, binary row/field values, binary TIME/DATETIME) go through a parse_fixed helper that rejects short reads instead of using uninitialized stack memory. Tests: 0xFC/251-column result sets parse; truncated 0xFC count, huge 0xFE count, 0xFE-leading row and truncated prepare-ok are rejected; standalone EOF and a full prepare-ok still parse. * Add truncated greeting tests for MySQL auth parser Cover the review scenario directly: a greeting ending before the 4-byte thread id (previously left tmp partially uninitialized and continued) and a greeting with a non-NUL-terminated server version are both rejected. * Reject bare 0xFB header and zero column count in MySQL result sets A bare 0xFB is the length-encoded NULL marker, never a legal column count (251 is encoded as FC FB 00). The widened fresh-dispatch range accepted it as a zero-column result set when followed by two EOF packets. Exclude 0xFB from result-set dispatch (it falls to the unknown-type rejection) and reject an explicitly encoded zero column count in ResultSetHeader::Parse; a result set always carries at least one column. * Fix greeting test NUL terminator and prefix-failure diagnostics - RejectTruncatedGreeting copied only 11 of the 12 bytes of "5.7.99-fake\x00", so it failed at the cut_until delimiter check instead of exercising the truncated thread-id parse_fixed path it was written for. Copy the terminating NUL. - parse_column_string now distinguishes a truncated/invalid length prefix from an oversized length in its log message instead of reporting a misleading "length 0 exceeds ...". - Rename AcceptSingleByte251ColumnCount to AcceptMultiByte251ColumnCount to match the three-byte encoding it actually verifies. * Validate column/auth/ERR/prepare-ok filler bytes in MySQL parser Remaining unchecked pop_front calls on fixed filler fields silently removed zero bytes from a truncated packet and accepted it as parsed: the column definition's filler-length byte and final 2 reserved bytes, the auth greeting's 10 reserved bytes, the ERR packet's '#' sql_state marker (now also validated) and the prepare-ok header's filler byte. Consume them through parse_fixed so a truncated tail is rejected. Add tests for a column definition missing 1..3 tail bytes and for an ERR packet without the '#' marker. * Accept pre-4.1 initial-handshake ERR packets in MySQL parser An ERR packet sent before capabilities are negotiated (e.g. the 'Too many connections' error) carries no '#' and sql_state; the unconditional marker check rejected these legitimate packets during authentication. Peek for the '#' marker instead (as MySQL clients do): when present, parse the protocol-4.1 layout and keep rejecting a truncated 5-byte sql_state; otherwise treat the whole tail as the message with an empty sql_state. This also drops the pre-existing payload_size >= 9 guard, which rejected short pre-4.1 errors, and skips the message allocation for an empty tail. Fixes a fetch misuse found on the way: IOBuf::fetch returns a pointer into its own storage when the range fits one block, so the marker must be read through the returned pointer, not the aux buffer. Tests: initial-handshake ERR parses with the full message, 4.1 ERR keeps its sql_state, and a truncated sql_state is still rejected. * Select MySQL ERR layout from connection phase, not message content The '#' sniff could not distinguish a pre-4.1 initial-handshake error from a 4.1 error whose message starts with '#': '#quota exceeded' was misparsed as sql_state 'quota' + message ' exceeded', and a short '#bad' message was rejected as a truncated sql_state. Thread a protocol41 flag from ParseMysqlMessage through ConsumePartialIOBuf into Error::Parse: it is false only while the server greeting has not been processed yet (per-connection AuthContext group still empty), which is exactly when ERR packets use the pre-4.1 layout ('Too many connections'); after the HandshakeResponse41 and in the command phase the 4.1 layout ('#' + sql_state) is required. Tests: legacy messages starting with '#' (long and short) keep their message intact with an empty sql_state, a 4.1 error whose message starts with '#' still parses marker + sql_state, plus the existing initial-handshake / truncated-sql-state / plain 4.1 controls. * Keep legacy MySQL ConsumePartialIOBuf symbols for ABI compatibility A defaulted protocol41 parameter preserves source compatibility but changes the mangled symbol, breaking prebuilt clients that link against the old signatures. Restore both legacy signatures as out-of-line wrappers that forward protocol41=true, and drop the default argument from the new overloads so overload resolution stays unambiguous. * Add binary-row truncation regression tests for MySQL parser The short-read hardening of the binary protocol path (NULL bitmap, fixed-width values, string/TIME/DATETIME lengths) had no coverage: all unit tests used the text protocol and the prepared-statement integration tests need a live server. Add synthetic MYSQL_PREPARED_STATEMENT result sets with a valid control row plus truncated NULL bitmap, truncated LONGLONG value, truncated string length prefix/value and truncated TIME/DATETIME values, each followed by a coalesced EOF packet to verify that decoding never borrows bytes from the next packet. * Fix hex-escape over-read in binary string-field test The \x00ab escape greedily consumes the following hex digits, so the literal held 4 bytes while std::string(str, 5) copied five -- a global-buffer-overflow caught by the ASan CI build. Split the literal after \x00 so the escape terminates at the quote; the adjacent-literal concatenation yields the intended 5 bytes fc 05 00 'a' 'b'. --------- Co-authored-by: brpc-oncall <brpc-oncall@localhost> | 1 month ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Reject deeply nested JSON replies in naming services (#3592) * Reject deeply nested JSON replies in naming services The consul, nacos and discovery naming services parsed registry replies with rapidjson's default recursive parser, so a deeply nested reply crashed the consuming process with stack exhaustion. rapidjson also builds, visits and destroys its DOM recursively, so iterative parsing alone is not enough. Route all the reply parsing through a shared ParseNamingServiceJson() which parses iteratively (kParseIterativeFlag) and rejects replies nested deeper than kMaxNamingServiceJsonDepth (100, same default as json2pb) before parsing, bounding every recursion on the document. Legit replies of these services are only a few levels deep. * Address review: reject raw NUL and clamp depth in JSON pre-scan - A raw NUL is invalid JSON anywhere and rapidjson treats it as end-of-input, so reject replies containing one up front: the depth scan and the parser now accept exactly the same bytes. - Don't let the depth counter go negative on malformed text with more closing than opening brackets. - Reword the comment about the state of `doc' when the depth limit is exceeded: it is untouched rather than cleared. --------- Co-authored-by: brpc-oncall <brpc-oncall@localhost> | 1 month ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Fix bthread_id lock leak in ProcessNsheadMcpackResponse (#3574) * Fix bthread_id lock leak in ProcessNsheadMcpackResponse After ProcessNsheadMcpackResponse acquires the bthread_id lock, its two early-return paths (response object missing, mcpack parse failure) skip accessor.OnResponse(), the only unlock entry. The leaked lock makes Join(correlation_id) hang forever and the RPC timeout cannot rescue it since the timeout error is only consumed during unlocking. A server returning a valid nshead header plus a malformed mcpack body reliably triggers this. Adopt the do { ... break ... } while(0) pattern (consistent with ProcessRpcResponse) so that OnResponse() is always reached. * Close unused pipe read end in nshead_mcpack unittest fixture * Fix compile error with new protobuf in nshead_mcpack unittest Descriptor::full_name() returns absl::string_view since protobuf 35.x, which cannot be implicitly converted to the const std::string& parameter of mcpack2pb::register_message_handler_or_die. Wrap it into std::string explicitly. --------- Co-authored-by: brpc-oncall <brpc-oncall@localhost> | 1 month ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Support bvar::Histogram and fix Prometheus name/label conflicts between bvar and mbvar (#3557) * Support bvar::Histogram and fix Prometheus name/label conflicts between bvar and mbvar * Fix MVariableBase::dump_exposed return type * Fix some issues * Fix json output * Move the deduplication into PrometheusMetricsDumper | 1 month ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Validate RPC response sockets (#3580) * Validate RPC response sockets Check that responses arrive on the socket used by the matching request attempt before updating the controller. Account for current attempts and unfinished backup requests across the four protobuf RPC protocols. Add Hulu response tests for matching and mismatched sockets while keeping direct response injection compatible with existing internal callers. * Expand RPC response socket test coverage Verify rejection and subsequent completion on the sending socket for baidu_std, sofa_pbrpc, and public_pbrpc response handlers. Exercise real channel/server calls across all four affected protocols and their supported connection types using an ephemeral server port. * Tighten rejected RPC response handling Accept the base correlation ID only for direct response injection without a sending socket. Real requests must match a versioned attempt ID. Reset all advertised streams on the arrival socket when rejecting a baidu_std response. Extend the regression test to check both rejection paths and successful completion by the valid response. | 1 month ago | |
Post small RDMA messages inline (#3569) * Post small RDMA messages inline CutFromIOBufList() posts every message by reference, so the NIC has to read a small RPC from host memory before sending it. Request 236 bytes of inline data at QP creation, retrying without it if the device refuses, and inline a message that fits the granted size and comes entirely from the RDMA block pool. 236 bytes is the largest Send whose WQE fits the 256-byte BlueFlame buffer of current mlx5 NICs. Generated-by: Claude Code (Claude Opus 5.5) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Refine the inline size limit and the QP creation fallback The 236-byte limit keeps an inlined Send within the 256-byte BlueFlame buffer of mlx5 NICs. Apply it only on Mellanox/NVIDIA devices (vendor ID 0x02c9, kept from the device query GlobalRdmaInitializeOrDie already does); on other devices the inline size the QP was granted is the limit. If QP creation with 236 bytes of inline data fails, try 64 bytes before falling back to none. irdma (Intel E810) rejects requests above 101 bytes, so on those NICs nothing was inlined. Generated-by: Claude Code (Claude Opus 5.5) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Try known inline limits, then step down After a refused 236-byte inline request, QP creation was retried with 64 bytes, then with none. Devices take less than 236 by different amounts: Intel's irdma refuses more than 216, 101 or 48 bytes depending on the generation (101 on an E810, 48 on an X722), Alibaba's erdma more than 96. With 64 as the only middle step, an E810 or erdma QP got 64 bytes, a newer irdma QP 64 instead of 216, and an X722 QP none. The verbs API cannot report the limit, so step down to it. A device whose kernel driver has a fixed limit, found by the vendor ID kept from the device query GlobalRdmaInitializeOrDie already does, starts there: 216, then 101, then 48 on Intel, 96 on Alibaba, each capped at 236. Other devices start at 236. Each refused size is followed by the next one 16 bytes smaller, down to 0, so a failure unrelated to inline data still ends as before, after a few more attempts at QP creation. Devices that accept 236 (mlx5, rxe) are unchanged. libfabric's verbs provider also probes the limit by trial QP creation (vrb_find_max_inline()). Generated-by: Claude Code (Claude Opus 5.5) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Step down the inline size only on EINVAL, and add unit tests AllocateQp() retried with a smaller inline size after any ibv_create_qp failure, so a failure unrelated to inline data, such as ENOMEM or the device's QP limit, led to up to 16 failed calls, and the caller's PLOG reported the errno of the last attempt. Step down only when the failed call left errno == EINVAL, which is how providers refuse an inline size; any other failure is returned at once with its errno. Each step is logged under FLAGS_rdma_trace_verbose. QP creation moves into CreateQpWithInlineData(), which takes the vendor ID as a parameter. It and InlineDataToRequest() are no longer static, so that brpc_rdma_unittest can test them with a stubbed IbvCreateQp: the first request per vendor, the Mellanox cap at 236 bytes, Intel 216, 101 and 48, Alibaba 96, an unknown device stepping down to 92, a non-EINVAL failure stopping at once, and a device refusing every size ending at 0. Generated-by: Claude Code (Claude Opus 5.5) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Factor the inline send decision out and test it CutFromIOBufList() inlines a message only when it fits the inline size the QP was granted and all of its blocks come from the block pool; user registered memory may be device memory, which the CPU cannot copy from. Move that decision into ShouldPostInline(), exposed for UT, and test it in brpc_rdma_unittest: a pool-backed message at the granted size is inlined, one byte more is not, and a message in user registered memory never is, however small. CutFromIOBufList() itself needs an initialized RDMA device: it returns early in the unit test binary, sizes its SGE list from the device and looks blocks up in the registered block pool. So the decision is tested on its own; the send path is otherwise unchanged. Generated-by: Claude Code (Claude Opus 5.5) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Reuse the inline size of the last QP for new QPs All QPs are created on the same device with the same attributes apart from their queue sizes, so a device that refuses the first inline size made every one of the rdma_prepared_qp_cnt QPs repeat the same step-down (216, 101, 48 on an Intel device limited to 48 bytes). Remember the size the last QP was created with and start there. If that size is refused, the EINVAL step-down continues from it as before. Each QP still takes its own granted size from attr.cap.max_inline_data. Generated-by: Claude Code (Claude Opus 5.5) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> | 1 month ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Fix empty %b/%s argument dropped in redis command formatting (#3566) * Fix empty %b/%s argument dropped in redis command formatting (#2275) * Fix %s/%b variadic argument type mismatch in RedisCommandFormatV * Fix %b binary test to compare full payload bytes instead of ASSERT_STREQ * Tighten va_arg const char* comment in RedisCommandFormatV * Return false instead of CHECK-abort on AddCommand format errors | 1 month ago | |
Update license header to Apache | 7 years ago | |
reject out-of-range AMF numbers in ReadAMFUint32 (#3593) The AMF0 number is a peer-controlled double; casting NaN or values outside [0, UINT32_MAX] to uint32_t is undefined behavior (UBSan float-cast-overflow) and decodes to different ids per platform. Validate the range before the cast. | 1 month ago | |
Support bvar::Histogram and fix Prometheus name/label conflicts between bvar and mbvar (#3557) * Support bvar::Histogram and fix Prometheus name/label conflicts between bvar and mbvar * Fix MVariableBase::dump_exposed return type * Fix some issues * Fix json output * Move the deduplication into PrometheusMetricsDumper | 1 month ago | |
Bound wire-declared sizes and decompressed output during parsing (#3476) Several parsers that handle client-controlled input trusted sizes declared on the wire without bounding them, which could make a connection consume far more memory than the message itself: - gzip/zlib/snappy decompression had no output cap: -max_body_size is only checked against the compressed bytes, so a small body could decompress to tens of GiB. Add -max_decompressed_body_size (default 32x -max_body_size, 0 means use the default) and enforce it in all three decompressors. The output cap is applied via a local ZeroCopyInputStream wrapper so it builds against every protobuf version CI uses (>= 3.5.1); the wrapper clips oversized blocks without double-backing-up the wrapped stream. - AMF string readers resized the output buffer to the declared length before checking how many bytes were actually available; read the string in bounded chunks instead. - RTMP chunk headers may re-declare a message while a pr- RTMP chunk headers may re-declare a message while a pr- RTMP chunk headers may re-deed - RTMP chunk headers may re-declare a message while a pr- RTMP ody- RTMP chunk headers may re-declare a message while a pr- RTwir- RTMP chunk headers may re-declare a message while a pr- cou- RTMP chunk headers may re-declare a message while a pr- RTMP ch r- RTMP chunk headers may re-declare a message while a pr- RTMPvalues instead of CHECK-fatal. | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Stabilize timing-sensitive bthread tests and fix the butex interruption race (#3545) * Stabilize timing-sensitive bthread tests and fix the butex interruption race * Fix pthread_kill get ESRCH * Use a non-fatal assertion * Fix some issues * Check and set task->interrupted under task->version_lock * Fix butex_requeue UT | 1 month ago | |
Validate RPC response sockets (#3580) * Validate RPC response sockets Check that responses arrive on the socket used by the matching request attempt before updating the controller. Account for current attempts and unfinished backup requests across the four protobuf RPC protocols. Add Hulu response tests for matching and mismatched sockets while keeping direct response injection compatible with existing internal callers. * Expand RPC response socket test coverage Verify rejection and subsequent completion on the sending socket for baidu_std, sofa_pbrpc, and public_pbrpc response handlers. Exercise real channel/server calls across all four affected protocols and their supported connection types using an ephemeral server port. * Tighten rejected RPC response handling Accept the base correlation ID only for direct response injection without a sending socket. Real requests must match a versioned attempt ID. Reset all advertised streams on the arrival socket when rejecting a baidu_std response. Extend the regression test to check both rejection paths and successful completion by the valid response. | 1 month ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Fix stream count test cleanup (#3531) * Fix stream count test cleanup * Assert stream cleanup succeeds in the test | 2 months ago | |
Contain malformed Thrift T_EXCEPTION replies on the client (#3500) * Contain malformed Thrift T_EXCEPTION replies on the client The Thrift client decodes a T_EXCEPTION reply in ReadThriftException without catching what the underlying Thrift library throws. A reply carrying a malformed exception struct (e.g. a field with an oversized length) makes TBinaryProtocol raise an exception that unwinds through ProcessThriftResponse up to the bthread task frame, where std::terminate() is called, killing the whole process and every other in-flight RPC on it. Wrap the decode in the same try/catch that ReadThriftStruct already uses for the normal reply body, so a malformed T_EXCEPTION reply degrades to a failed parse instead of crashing the process. Add a unit test feeding a malformed T_EXCEPTION reply through the client response path. * Make the thrift T_EXCEPTION test compile on builds without thrift * Polish the thrift T_EXCEPTION handling test and log messages Incorporate review feedback: - Catch std::exception by const ref and fix 'Catched' -> 'Caught' in the T_EXCEPTION reply parse log messages. - Add <unistd.h> and close the pipe fds / release the socket in TearDown() so the unit test does not leak OS resources across tests. * Avoid double-close of the pipe write end in the thrift test The test socket owns the pipe write end passed in SocketOptions::fd and closes it on destruction, so TearDown must only close the read end to avoid double-closing (and potentially closing a recycled fd). * Remove redundant thrift define from test build Unit test targets already inherit ENABLE_THRIFT_FRAMED_PROTOCOL from the brpc source target's transitive defines, so the select in test/BUILD.bazel is unnecessary. | 2 months ago | |
Use monotonic time instead of wall time (#3268) | 7 months ago | |
Add IPC_V2 data path for UBRing IPC (#3573) * Add IPC_V2 data path for UBRing IPC * Move IPC_V2 ring implementation out of header --------- Co-authored-by: BGQ99 <1132767344@qq.com> | 1 month ago | |
reject CR/LF in SetHttpURL and SetH2Path (#3588) Both parsers copied control characters into _host/_path/_query/_fragment, which MakeRawHttpRequest and GenerateH2Path then wrote verbatim into the Host header, the request line and the HTTP/2 :path. | 1 month ago | |
feat: add URMA transport support (#3428) * Add URMA transport support * fix: address review comments on naming, IOBuf sizing and UMDK pinning - Rename ack_bit_is_rdma_ok to ack_bit_is_urma_ok. - Replace hard-coded IOBuf block header size with sizeof(butil::IOBuf::Block). - Pin UMDK dependency to a specific commit instead of a mutable tag. * modify the bazel docs and refine the ut * add DOWNLOAD_URMA_HEADERS lacks Bazel build support * Fix Bazel URMA mock source selection * Fix URMA review issues after input refactor * Clarify Bazel URMA source selection * force Restore InputMessenger formatting * reformat the code base on master --------- Co-authored-by: Winchell <cw20050111@gmail.com> Co-authored-by: Gzure <740684863@qq.com> | 1 month ago | |
Stabilize timing-sensitive bthread tests and fix the butex interruption race (#3545) * Stabilize timing-sensitive bthread tests and fix the butex interruption race * Fix pthread_kill get ESRCH * Use a non-fatal assertion * Fix some issues * Check and set task->interrupted under task->version_lock * Fix butex_requeue UT | 1 month ago | |
Stabilize timing-sensitive bthread tests and fix the butex interruption race (#3545) * Stabilize timing-sensitive bthread tests and fix the butex interruption race * Fix pthread_kill get ESRCH * Use a non-fatal assertion * Fix some issues * Check and set task->interrupted under task->version_lock * Fix butex_requeue UT | 1 month ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Stabilize timing-sensitive bthread tests and fix the butex interruption race (#3545) * Stabilize timing-sensitive bthread tests and fix the butex interruption race * Fix pthread_kill get ESRCH * Use a non-fatal assertion * Fix some issues * Check and set task->interrupted under task->version_lock * Fix butex_requeue UT | 1 month ago | |
fix: preserve XMM6-XMM15 in x86_64 bthread context switch (#3495) * Fix clang (#28) Co-authored-by: LinQuickDev <LinQuickDev@users.noreply.github.com> * fix: preserve SSE state in x86_64 bthread context switch (#31) --------- Co-authored-by: LinQuickDev <LinQuickDev@users.noreply.github.com> Co-authored-by: Spicy-cream <2667314914@qq.com> | 1 month ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Stabilize timing-sensitive bthread tests and fix the butex interruption race (#3545) * Stabilize timing-sensitive bthread tests and fix the butex interruption race * Fix pthread_kill get ESRCH * Use a non-fatal assertion * Fix some issues * Check and set task->interrupted under task->version_lock * Fix butex_requeue UT | 1 month ago | |
Stabilize timing-sensitive bthread tests and fix the butex interruption race (#3545) * Stabilize timing-sensitive bthread tests and fix the butex interruption race * Fix pthread_kill get ESRCH * Use a non-fatal assertion * Fix some issues * Check and set task->interrupted under task->version_lock * Fix butex_requeue UT | 1 month ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Stabilize timing-sensitive bthread tests and fix the butex interruption race (#3545) * Stabilize timing-sensitive bthread tests and fix the butex interruption race * Fix pthread_kill get ESRCH * Use a non-fatal assertion * Fix some issues * Check and set task->interrupted under task->version_lock * Fix butex_requeue UT | 1 month ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Fix lost wakeup in ParkingLot waiter check (#3539) | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Fix stack argument race in priority bthread scheduling (#3587) | 1 month ago | |
Stabilize timing-sensitive bthread tests and fix the butex interruption race (#3545) * Stabilize timing-sensitive bthread tests and fix the butex interruption race * Fix pthread_kill get ESRCH * Use a non-fatal assertion * Fix some issues * Check and set task->interrupted under task->version_lock * Fix butex_requeue UT | 1 month ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Stabilize timing-sensitive bthread tests and fix the butex interruption race (#3545) * Stabilize timing-sensitive bthread tests and fix the butex interruption race * Fix pthread_kill get ESRCH * Use a non-fatal assertion * Fix some issues * Check and set task->interrupted under task->version_lock * Fix butex_requeue UT | 1 month ago | |
Stabilize timing-sensitive bthread tests and fix the butex interruption race (#3545) * Stabilize timing-sensitive bthread tests and fix the butex interruption race * Fix pthread_kill get ESRCH * Use a non-fatal assertion * Fix some issues * Check and set task->interrupted under task->version_lock * Fix butex_requeue UT | 1 month ago | |
Stabilize timing-sensitive bthread tests and fix the butex interruption race (#3545) * Stabilize timing-sensitive bthread tests and fix the butex interruption race * Fix pthread_kill get ESRCH * Use a non-fatal assertion * Fix some issues * Check and set task->interrupted under task->version_lock * Fix butex_requeue UT | 1 month ago | |
Fix gflag namespace (#2877) | 1 year ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Fix gflag namespace (#2877) | 1 year ago | |
Fix flaky histogram window test (#3567) | 1 month ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Fix timing assumptions in multidimensional latency recorder test (#3581) * Fix timing assumptions in multidimensional latency recorder test Wait for asynchronous sampling with a bounded five-second timeout instead of assuming a one-second sleep is sufficient. Check positive QPS without assuming a minimum rate of seven requests per second. Use nonfatal assertions for independent metrics and restore modified flags automatically on all test exit paths. * Preserve sampled metrics in latency recorder test Cache each nonzero latency, maximum latency, and QPS observation while polling. Assert the cached values so a sampler tick cannot clear the one-second windows between polling and the assertions. Include QPS in the readiness check and preserve successful observations independently when sampler ticks occur between metric reads. | 1 month ago | |
Support bvar::Histogram and fix Prometheus name/label conflicts between bvar and mbvar (#3557) * Support bvar::Histogram and fix Prometheus name/label conflicts between bvar and mbvar * Fix MVariableBase::dump_exposed return type * Fix some issues * Fix json output * Move the deduplication into PrometheusMetricsDumper | 1 month ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Add latency recorder window statistics test (#3582) Exercise latency observations split across sampler ticks using a window longer than the bounded wait budget. Confirm the sampled count is complete before checking the sum and average from the saved snapshot, and verify the maximum through its independent sampler. | 1 month ago | |
Fix Maxer default value for floating-point types (#3563) | 1 month ago | |
Harden bvar sampling against use-after-free (#3487) | 2 months ago | |
remove authors | 6 years ago | |
Support bvar::Histogram and fix Prometheus name/label conflicts between bvar and mbvar (#3557) * Support bvar::Histogram and fix Prometheus name/label conflicts between bvar and mbvar * Fix MVariableBase::dump_exposed return type * Fix some issues * Fix json output * Move the deduplication into PrometheusMetricsDumper | 1 month ago | |
Harden bvar sampling against use-after-free (#3487) | 2 months ago | |
fixes for gcc on arm64 | 4 years ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Remove Callback/Bind/Tuple from butil | 9 years ago | |
test: rebuild test certs with 2048-bit RSA keys The previous test certificates use 1024-bit RSA keys and SHA-1 for signatures. They are somewhat deprecated. This commit updates the certificates with RSA-2048 and SHA-256. | 7 years ago | |
test: rebuild test certs with 2048-bit RSA keys The previous test certificates use 1024-bit RSA keys and SHA-1 for signatures. They are somewhat deprecated. This commit updates the certificates with RSA-2048 and SHA-256. | 7 years ago | |
test: rebuild test certs with 2048-bit RSA keys The previous test certificates use 1024-bit RSA keys and SHA-1 for signatures. They are somewhat deprecated. This commit updates the certificates with RSA-2048 and SHA-256. | 7 years ago | |
test: rebuild test certs with 2048-bit RSA keys The previous test certificates use 1024-bit RSA keys and SHA-1 for signatures. They are somewhat deprecated. This commit updates the certificates with RSA-2048 and SHA-256. | 7 years ago | |
Update license header to Apache | 7 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Support custom modification of sub controllers (#3213) * Copy http headers from main controller to sub controller * Support custom modification of sub controllers | 8 months ago | |
Run Bazel tests in parallel in CI (#3482) * Run Bazel tests in parallel in CI * Use an ephemeral port in interceptor test * Use an ephemeral port in HTTP expect test * Set protobuf JSON test timeout explicitly * Use an ephemeral port in endpoint test * Use an ephemeral port in oversized message test * Isolate additional timing-sensitive Bazel tests Run the channel and SSL test binaries exclusively. They rely on strict timing or process-wide networking state and can fail when competing with parallel test processes. * Avoid restoring incompatible Bazel caches Limit fallback restoration to caches produced by the same CI job. The broad fallback could restore a cache from a different compiler or protobuf setup, which produced no hits while consuming transfer time and cache capacity. | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Update license header to Apache | 7 years ago | |
Update license header to Apache | 7 years ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
add apache license header for missing cpp files under test directory | 7 years ago | |
fix some warnings for clang and revert changes on ALIGNAS/ALIGNOF | 4 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
test: bump brpc_channel_unittest to size=large (900s) (#3339) brpc_channel_unittest packs dozens of timing-sensitive TEST_F (backup request, retry/backoff, timeouts) into a single binary. On contended CI runners its cumulative real-time waits exceed Bazel's default per-test 300s (size=medium) limit, producing flaky TIMEOUT failures (observed TIMEOUT in 4/5 no-cache runs on a GitHub ubuntu-22.04 runner). Add an optional per_test_size override to the generate_unittests macro and set brpc_channel_unittest to size=large (900s). No test source changes. Sharding was rejected: the binary's TEST_F share fixed loopback endpoints and global state, so parallel shards make a 'connection refused' test observe another shard's live server and fail deterministically. Co-authored-by: rajvarun77 <287367605+rajvarun77@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> | 5 months ago | |
Support AddressSanitizer (#2890) * Support AddressSanitizer * Add gperftools helper header | 1 year ago | |
insert_apache_header | 6 years ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
insert_apache_header | 6 years ago | |
insert_apache_header | 6 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
fix UT of json2pb Change-Id: I0dc480ac6192a92b317b9a34a45db1567a3cb45d | 9 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
rename BASE_ prefixes to BUTIL_ to avoid potential conflicts | 8 years ago | |
insert_apache_header | 6 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Small FlatMap optimization with default initialization (#2620) * Small FlatMap optimization * Support optional | 1 year ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
fix some warnings for clang and revert changes on ALIGNAS/ALIGNOF | 4 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
insert_apache_header | 6 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Refactor Bazel build with custom proto rules and build all test targets (#3313) | 5 months ago | |
build(cxx): align all builds on a C++14 baseline (#3419) * build(cxx): align all builds on a C++14 baseline CMake, Make, tests, tools, and examples now require C++14 so every supported build path shares the same minimum language level. The compiler checks and user-facing documentation reflect that baseline. * fix(test): keep cores scoped to the failing test Clear prior cores before each test binary. A passing death test can leave a core that would otherwise be used to diagnose an unrelated later failure. * revert src/butil/type_traits.h | 3 months ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Small FlatMap optimization with default initialization (#2620) * Small FlatMap optimization * Support optional | 1 year ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
rename BASE_ prefixes to BUTIL_ to avoid potential conflicts | 8 years ago | |
Update license header to Apache | 7 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Support seqlock and use it for TaskGroup CPU time stat (#3541) | 2 months ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
insert_apache_header | 6 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Support AddressSanitizer (#2890) * Support AddressSanitizer * Add gperftools helper header | 1 year ago | |
Update license header to Apache | 7 years ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
string_printf support hint size of formatted string | 3 years ago | |
make butil::BasicStringPiece<T> support string split functions-family | 5 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Remove UT's deps on gmock & fix UT | 8 years ago | |
Update license header to Apache | 7 years ago | |
Remove Callback/Bind/Tuple from butil | 9 years ago | |
Remove UT's deps on gmock & fix UT | 8 years ago | |
rename BASE_ prefixes to BUTIL_ to avoid potential conflicts | 8 years ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Update license header to Apache | 7 years ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
insert_apache_header | 6 years ago | |
insert_apache_header | 6 years ago | |
Support arena rpc pb message factory (#2751) * Support arena rpc pb message factory * Update server document * Fix comment | 2 years ago | |
Remove code for unused FilePathWatcher and fix a warning under gcc 7.3 | 8 years ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Rename base to butil to avoid potential naming conflicts | 9 years ago | |
Refactor NULL with nullptr in test (#3464) | 2 months ago |
| Files | Last commit | Last update |
|---|---|---|
| 1 month ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 5 months ago | ||
| 2 years ago | ||
| 4 years ago | ||
| 6 years ago | ||
| 6 years ago | ||
| 1 year ago | ||
| 9 years ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 9 years ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 9 years ago | ||
| 9 years ago | ||
| 3 years ago | ||
| 9 years ago | ||
| 9 years ago | ||
| 2 months ago | ||
| 5 months ago | ||
| 1 month ago | ||
| 7 months ago | ||
| 2 months ago | ||
| 1 month ago | ||
| 2 months ago | ||
| 1 month ago | ||
| 1 month ago | ||
| 2 months ago | ||
| 3 months ago | ||
| 1 month ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 1 month ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 1 month ago | ||
| 7 years ago | ||
| 2 months ago | ||
| 7 years ago | ||
| 1 month ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 1 month ago | ||
| 1 month ago | ||
| 1 month ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 5 months ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 1 month ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 1 month ago | ||
| 2 months ago | ||
| 1 month ago | ||
| 2 months ago | ||
| 1 month ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 1 month ago | ||
| 1 month ago | ||
| 2 months ago | ||
| 1 month ago | ||
| 7 years ago | ||
| 1 month ago | ||
| 1 month ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 1 month ago | ||
| 1 month ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 7 months ago | ||
| 1 month ago | ||
| 1 month ago | ||
| 1 month ago | ||
| 1 month ago | ||
| 1 month ago | ||
| 2 months ago | ||
| 1 month ago | ||
| 1 month ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 1 month ago | ||
| 1 month ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 1 month ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 1 month ago | ||
| 1 month ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 1 month ago | ||
| 1 month ago | ||
| 1 month ago | ||
| 1 year ago | ||
| 2 months ago | ||
| 1 year ago | ||
| 1 month ago | ||
| 2 months ago | ||
| 1 month ago | ||
| 1 month ago | ||
| 2 months ago | ||
| 1 month ago | ||
| 1 month ago | ||
| 2 months ago | ||
| 6 years ago | ||
| 1 month ago | ||
| 2 months ago | ||
| 4 years ago | ||
| 9 years ago | ||
| 9 years ago | ||
| 9 years ago | ||
| 9 years ago | ||
| 9 years ago | ||
| 7 years ago | ||
| 7 years ago | ||
| 7 years ago | ||
| 7 years ago | ||
| 7 years ago | ||
| 2 months ago | ||
| 9 years ago | ||
| 2 months ago | ||
| 9 years ago | ||
| 9 years ago | ||
| 8 months ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 7 years ago | ||
| 7 years ago | ||
| 9 years ago | ||
| 9 years ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 7 years ago | ||
| 4 years ago | ||
| 2 months ago | ||
| 5 months ago | ||
| 1 year ago | ||
| 6 years ago | ||
| 9 years ago | ||
| 9 years ago | ||
| 9 years ago | ||
| 6 years ago | ||
| 6 years ago | ||
| 2 months ago | ||
| 9 years ago | ||
| 2 months ago | ||
| 9 years ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 9 years ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 8 years ago | ||
| 6 years ago | ||
| 2 months ago | ||
| 9 years ago | ||
| 2 months ago | ||
| 9 years ago | ||
| 9 years ago | ||
| 2 months ago | ||
| 9 years ago | ||
| 1 year ago | ||
| 9 years ago | ||
| 2 months ago | ||
| 9 years ago | ||
| 4 years ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 6 years ago | ||
| 2 months ago | ||
| 5 months ago | ||
| 3 months ago | ||
| 9 years ago | ||
| 2 months ago | ||
| 1 year ago | ||
| 9 years ago | ||
| 9 years ago | ||
| 2 months ago | ||
| 8 years ago | ||
| 7 years ago | ||
| 2 months ago | ||
| 9 years ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 9 years ago | ||
| 2 months ago | ||
| 9 years ago | ||
| 2 months ago | ||
| 9 years ago | ||
| 6 years ago | ||
| 2 months ago | ||
| 1 year ago | ||
| 7 years ago | ||
| 9 years ago | ||
| 9 years ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 3 years ago | ||
| 5 years ago | ||
| 2 months ago | ||
| 9 years ago | ||
| 2 months ago | ||
| 9 years ago | ||
| 9 years ago | ||
| 2 months ago | ||
| 9 years ago | ||
| 8 years ago | ||
| 7 years ago | ||
| 9 years ago | ||
| 8 years ago | ||
| 8 years ago | ||
| 9 years ago | ||
| 9 years ago | ||
| 9 years ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 2 months ago | ||
| 9 years ago | ||
| 7 years ago | ||
| 9 years ago | ||
| 9 years ago | ||
| 6 years ago | ||
| 6 years ago | ||
| 2 years ago | ||
| 8 years ago | ||
| 9 years ago | ||
| 9 years ago | ||
| 2 months ago |