Mmyelinated-wackerowfeat(search): pin localized queries from ETHGlossary
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Flag getExtracted like the other locale-optional next-intl APIs Bare getExtracted still hits getConfig without a locale override, so it belongs on the same list as getTranslations. Co-authored-by: Cursor <cursoragent@cursor.com> | 27 天前 | |
feat(ab-testing): A/B the rebuilt find-wallet catalog vs the legacy table Sets up the FindWalletCatalog2026 experiment so the revamp can be validated causally instead of before/after. The catalog is the shipped design; the old expandable table returns as the Original arm only for the duration of the test. The coded page is nested at find-wallet/ab-code/[code]/ rather than hoisted to the app root: a root-level coded page is outside find-wallet/layout.tsx, so it loses the @modal slot and the catalog arm would hard-navigate to standalone detail pages instead of intercepting into a modal - measuring a degraded version of the design under test. proxy.ts now appends the coded segment to the matched path to suit. Restores FindWalletProductTable, wallet-filters.ts and four wallets.ts helpers deleted in the revamp. No translation work was needed: that PR added keys without removing any. Three failure modes worth calling out, all fixed here: - The proxy only rewrites while an experiment is actually running. Rewriting unconditionally pins every visitor to variant 0, which is only harmless when index 0 is the shipped design; here it would have quietly served the design the revamp replaced between merge and experiment start, permanently on pause, and would have flipped CI's e2e/visual suites onto the old table. - The coded page declares dynamicParams. Without it the route serves only the permutations generateStaticParams enumerated, so a build that could not sign them (no FLAGS_SECRET, empty list) would 404 every request rather than rendering on demand as the docs claimed. - The legacy body is injected by the coded page instead of imported by the real page, keeping ~150KB of old-table client JS out of the shipped route's bundle (1730.7 -> 1580.5 KB) - it would otherwise have undercut the INP win the revamp exists for. Variation names reach Matomo verbatim from the variant elements' keys, so they are spelled Original and NewCatalog to match the dashboard exactly. | 1 个月前 | |
docs: sync agent docs and dev docs with current codebase Fixes verified-stale claims across AGENTS.md, .claude skills/commands, and docs/: - AGENTS.md: Next 16/React 19/next-intl 4/Storybook 10/Motion 12, Turbopack default + webpack fallbacks, real test scripts (unit/e2e/ visual replace "no automated unit tests"), drop removed markdown-checker/events-import scripts, React 19 ref-as-prop, condense A/B section to a pointer at docs/ab-testing.md - intl-pipeline skill: translation_branch -> target_branch; remove unsupported TARGET_FILES env var (TARGET_LANGUAGES or programmatic runSanitizer(filesWithContent) only) - intl-review skill: fix post-mortems path, /workflows:compound -> ce-compound - page-visual-tests skill: chromatic-pages.yml/chromatic.yml -> consolidated ci.yml jobs, maybeShuffle -> safeShuffle, staking call site, CI locale nuance, feedback-widget readiness wait in snippet - performance references: drop nonexistent audit script and common-server.json, fix LazyImports paths - data-layer skill: real task tuples, TaskDef[], WEEKLY cadence, EthPriceData, revalidate:false static pattern, tree additions - commands: fix dead doc refs, sanitizer size/test counts, broken node -e snippets -> ts-node, phantom Phase-1 sanitizer step, Crowdin -> Gemini pipeline attribution, prefer playwright-cli - docs/: resolve cva-vs-tv and type-vs-interface contradictions with AGENTS.md, remove Pages Router/Chakra/TS-migration leftovers, fix e2e dir layout, standardize .env.local, align Chromatic app IDs | 2 个月前 | |
chore(ci): pin Chromatic action, keep metadata upload off Pin chromaui/action@v18.5.0 in both jobs: @v18 is mutable and bundles its own CLI, so a floating tag can change a required merge gate with no PR. uploadMetadata defaults to on whenever onlyChanged is set (CLI 17.6+), which would publish chromatic.log next to the public Storybook. Set it explicitly. Also corrects the ci.yml and docs claims that every non-draft PR publishes a build -- bypassed builds publish nothing. | 1 个月前 | |
docs: capture setRequestLocale-first rule Records the pattern behind recovery PRs #18785/#18797/#18798/#18800 and systemic fix #18811 so future work surfaces it before reintroducing the bug. Every async Server Component page and generateMetadata under app/[locale]/ must call setRequestLocale(locale) before any next-intl API. next-intl's request config resolves the locale via requestLocale, which reads request headers unless setRequestLocale has primed the per-request cache; a next-intl call before priming opts the route into dynamic rendering and, for on-demand params (invalid-locale / unknown-slug bot probes not in generateStaticParams), throws "Page changed from static to dynamic at runtime, reason: headers". The getMetadata/getMdMetadata helpers call getTranslations("common") internally, so priming first is required even when locale is passed to them. Canonical writeup: docs/solutions/architecture/setrequestlocale-static-to-dynamic-rendering.md (discoverable via the learnings-researcher agent). Thin pointers added in docs/best-practices.md (next-intl section) and the design-system skill (references/i18n-rtl.md + SKILL.md rule 5 and load trigger). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com> | 2 个月前 | |
docs: sync agent docs and dev docs with current codebase Fixes verified-stale claims across AGENTS.md, .claude skills/commands, and docs/: - AGENTS.md: Next 16/React 19/next-intl 4/Storybook 10/Motion 12, Turbopack default + webpack fallbacks, real test scripts (unit/e2e/ visual replace "no automated unit tests"), drop removed markdown-checker/events-import scripts, React 19 ref-as-prop, condense A/B section to a pointer at docs/ab-testing.md - intl-pipeline skill: translation_branch -> target_branch; remove unsupported TARGET_FILES env var (TARGET_LANGUAGES or programmatic runSanitizer(filesWithContent) only) - intl-review skill: fix post-mortems path, /workflows:compound -> ce-compound - page-visual-tests skill: chromatic-pages.yml/chromatic.yml -> consolidated ci.yml jobs, maybeShuffle -> safeShuffle, staking call site, CI locale nuance, feedback-widget readiness wait in snippet - performance references: drop nonexistent audit script and common-server.json, fix LazyImports paths - data-layer skill: real task tuples, TaskDef[], WEEKLY cadence, EthPriceData, revalidate:false static pattern, tree additions - commands: fix dead doc refs, sanitizer size/test counts, broken node -e snippets -> ts-node, phantom Phase-1 sanitizer step, Crowdin -> Gemini pipeline attribution, prefer playwright-cli - docs/: resolve cva-vs-tv and type-vs-interface contradictions with AGENTS.md, remove Pages Router/Chakra/TS-migration leftovers, fix e2e dir layout, standardize .env.local, align Chromatic app IDs | 2 个月前 | |
docs: clarify skipped release behavior | 1 个月前 | |
docs: point at design-system skill Update AGENTS.md styling-conventions section to reflect tv-over-cva preference and add a pointer to the new design-system skill. Stub docs/ds-implementation.md to redirect at the skill + Storybook; the previous content (Figma reference, DS V1 epic) is superseded by the skill but the file is preserved so existing links resolve. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com> | 4 个月前 | |
docs: sync agent docs and dev docs with current codebase Fixes verified-stale claims across AGENTS.md, .claude skills/commands, and docs/: - AGENTS.md: Next 16/React 19/next-intl 4/Storybook 10/Motion 12, Turbopack default + webpack fallbacks, real test scripts (unit/e2e/ visual replace "no automated unit tests"), drop removed markdown-checker/events-import scripts, React 19 ref-as-prop, condense A/B section to a pointer at docs/ab-testing.md - intl-pipeline skill: translation_branch -> target_branch; remove unsupported TARGET_FILES env var (TARGET_LANGUAGES or programmatic runSanitizer(filesWithContent) only) - intl-review skill: fix post-mortems path, /workflows:compound -> ce-compound - page-visual-tests skill: chromatic-pages.yml/chromatic.yml -> consolidated ci.yml jobs, maybeShuffle -> safeShuffle, staking call site, CI locale nuance, feedback-widget readiness wait in snippet - performance references: drop nonexistent audit script and common-server.json, fix LazyImports paths - data-layer skill: real task tuples, TaskDef[], WEEKLY cadence, EthPriceData, revalidate:false static pattern, tree additions - commands: fix dead doc refs, sanitizer size/test counts, broken node -e snippets -> ts-node, phantom Phase-1 sanitizer step, Crowdin -> Gemini pipeline attribution, prefer playwright-cli - docs/: resolve cva-vs-tv and type-vs-interface contradictions with AGENTS.md, remove Pages Router/Chakra/TS-migration leftovers, fix e2e dir layout, standardize .env.local, align Chromatic app IDs | 2 个月前 | |
Reapply "Merge pull request #17870 from ethereum/videos-refactor" This reverts commit 3316f219035e0191764b6c8d57db97acb0e8a55a. | 5 个月前 | |
docs: sync agent docs and dev docs with current codebase Fixes verified-stale claims across AGENTS.md, .claude skills/commands, and docs/: - AGENTS.md: Next 16/React 19/next-intl 4/Storybook 10/Motion 12, Turbopack default + webpack fallbacks, real test scripts (unit/e2e/ visual replace "no automated unit tests"), drop removed markdown-checker/events-import scripts, React 19 ref-as-prop, condense A/B section to a pointer at docs/ab-testing.md - intl-pipeline skill: translation_branch -> target_branch; remove unsupported TARGET_FILES env var (TARGET_LANGUAGES or programmatic runSanitizer(filesWithContent) only) - intl-review skill: fix post-mortems path, /workflows:compound -> ce-compound - page-visual-tests skill: chromatic-pages.yml/chromatic.yml -> consolidated ci.yml jobs, maybeShuffle -> safeShuffle, staking call site, CI locale nuance, feedback-widget readiness wait in snippet - performance references: drop nonexistent audit script and common-server.json, fix LazyImports paths - data-layer skill: real task tuples, TaskDef[], WEEKLY cadence, EthPriceData, revalidate:false static pattern, tree additions - commands: fix dead doc refs, sanitizer size/test counts, broken node -e snippets -> ts-node, phantom Phase-1 sanitizer step, Crowdin -> Gemini pipeline attribution, prefer playwright-cli - docs/: resolve cva-vs-tv and type-vs-interface contradictions with AGENTS.md, remove Pages Router/Chakra/TS-migration leftovers, fix e2e dir layout, standardize .env.local, align Chromatic app IDs | 2 个月前 | |
docs: fix typo in docs/github-issue-triage-process.md | 6 个月前 | |
docs: sync agent docs and dev docs with current codebase Fixes verified-stale claims across AGENTS.md, .claude skills/commands, and docs/: - AGENTS.md: Next 16/React 19/next-intl 4/Storybook 10/Motion 12, Turbopack default + webpack fallbacks, real test scripts (unit/e2e/ visual replace "no automated unit tests"), drop removed markdown-checker/events-import scripts, React 19 ref-as-prop, condense A/B section to a pointer at docs/ab-testing.md - intl-pipeline skill: translation_branch -> target_branch; remove unsupported TARGET_FILES env var (TARGET_LANGUAGES or programmatic runSanitizer(filesWithContent) only) - intl-review skill: fix post-mortems path, /workflows:compound -> ce-compound - page-visual-tests skill: chromatic-pages.yml/chromatic.yml -> consolidated ci.yml jobs, maybeShuffle -> safeShuffle, staking call site, CI locale nuance, feedback-widget readiness wait in snippet - performance references: drop nonexistent audit script and common-server.json, fix LazyImports paths - data-layer skill: real task tuples, TaskDef[], WEEKLY cadence, EthPriceData, revalidate:false static pattern, tree additions - commands: fix dead doc refs, sanitizer size/test counts, broken node -e snippets -> ts-node, phantom Phase-1 sanitizer step, Crowdin -> Gemini pipeline attribution, prefer playwright-cli - docs/: resolve cva-vs-tv and type-vs-interface contradictions with AGENTS.md, remove Pages Router/Chakra/TS-migration leftovers, fix e2e dir layout, standardize .env.local, align Chromatic app IDs | 2 个月前 | |
update docs | 3 年前 | |
docs: sync agent docs and dev docs with current codebase Fixes verified-stale claims across AGENTS.md, .claude skills/commands, and docs/: - AGENTS.md: Next 16/React 19/next-intl 4/Storybook 10/Motion 12, Turbopack default + webpack fallbacks, real test scripts (unit/e2e/ visual replace "no automated unit tests"), drop removed markdown-checker/events-import scripts, React 19 ref-as-prop, condense A/B section to a pointer at docs/ab-testing.md - intl-pipeline skill: translation_branch -> target_branch; remove unsupported TARGET_FILES env var (TARGET_LANGUAGES or programmatic runSanitizer(filesWithContent) only) - intl-review skill: fix post-mortems path, /workflows:compound -> ce-compound - page-visual-tests skill: chromatic-pages.yml/chromatic.yml -> consolidated ci.yml jobs, maybeShuffle -> safeShuffle, staking call site, CI locale nuance, feedback-widget readiness wait in snippet - performance references: drop nonexistent audit script and common-server.json, fix LazyImports paths - data-layer skill: real task tuples, TaskDef[], WEEKLY cadence, EthPriceData, revalidate:false static pattern, tree additions - commands: fix dead doc refs, sanitizer size/test counts, broken node -e snippets -> ts-node, phantom Phase-1 sanitizer step, Crowdin -> Gemini pipeline attribution, prefer playwright-cli - docs/: resolve cva-vs-tv and type-vs-interface contradictions with AGENTS.md, remove Pages Router/Chakra/TS-migration leftovers, fix e2e dir layout, standardize .env.local, align Chromatic app IDs | 2 个月前 | |
merge: bring 19194's pins and shared params into v2 Search/index.tsx resolves to v2, which moved the modal config into SearchModal.tsx; searchParams.ts, promote.ts and curation.json resolve to 19194, whose SORT_BY (100 buckets, measured) and localized pins supersede the six-bucket constant this branch carried. SearchModal keeps importing SORT_BY and TEXT_MATCH_TYPE by the same names. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com> | 6 天前 | |
fix(search): bound result row height, drop Algolia refs A transcript hit could fill eight lines. The vendor truncates a result to one line; we override that with `whitespace-normal` so a wrapped title is not cut mid-word, and unbounded that lets a whole paragraph through. Titles clamp to two lines and the path to one. Worth noting for later: Typesense already returns a short snippet for these hits -- around 50 characters against a 300-character full value -- and the renderer displays the full field instead. The clamp bounds the symptom; using the snippet is the actual fix and sits in the search adapter rather than in CSS. Also clears the three Algolia references the review flagged: docs/stack.md still named it as the search stack, and two comments referred to the Algolia package and its styling docs. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com> | 15 天前 | |
docs: sync agent docs and dev docs with current codebase Fixes verified-stale claims across AGENTS.md, .claude skills/commands, and docs/: - AGENTS.md: Next 16/React 19/next-intl 4/Storybook 10/Motion 12, Turbopack default + webpack fallbacks, real test scripts (unit/e2e/ visual replace "no automated unit tests"), drop removed markdown-checker/events-import scripts, React 19 ref-as-prop, condense A/B section to a pointer at docs/ab-testing.md - intl-pipeline skill: translation_branch -> target_branch; remove unsupported TARGET_FILES env var (TARGET_LANGUAGES or programmatic runSanitizer(filesWithContent) only) - intl-review skill: fix post-mortems path, /workflows:compound -> ce-compound - page-visual-tests skill: chromatic-pages.yml/chromatic.yml -> consolidated ci.yml jobs, maybeShuffle -> safeShuffle, staking call site, CI locale nuance, feedback-widget readiness wait in snippet - performance references: drop nonexistent audit script and common-server.json, fix LazyImports paths - data-layer skill: real task tuples, TaskDef[], WEEKLY cadence, EthPriceData, revalidate:false static pattern, tree additions - commands: fix dead doc refs, sanitizer size/test counts, broken node -e snippets -> ts-node, phantom Phase-1 sanitizer step, Crowdin -> Gemini pipeline attribution, prefer playwright-cli - docs/: resolve cva-vs-tv and type-vs-interface contradictions with AGENTS.md, remove Pages Router/Chakra/TS-migration leftovers, fix e2e dir layout, standardize .env.local, align Chromatic app IDs | 2 个月前 | |
refactor: rename FeedbackCard to ContentFeedback No longer styled as a Card, and reduces over-used "Card" terminology Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com> | 3 个月前 |
