| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Refactor code using `gofmt` and `go lint`. (#148) - Refactors code using `gofmt` and `go lint` to improve code quality. - Adds scripts to `gofmt` code and to update required changes - Adds scripts to `go lint` and `go vet` code - Adds `lint` stage before `build` to retain code quality - Adds Godocs Badge to README.md | 6 年前 | |
Pass --revision to helm diff upgrade (#1046) * fix for #1045 * fix lint | 16 天前 | |
Pass --revision to helm diff upgrade (#1046) * fix for #1045 * fix lint | 16 天前 | |
chore: bump Go to 1.26.0 (#994) * Revert "Revert "chore: bump Go version to 1.26.0 (#992)" (#993)" This reverts commit de27d505ec32b8d1308e0a9712970a599dff28df. * chore: bump golangci-lint to v2.12.2 to support Go 1.26.0 Agent-Logs-Url: https://github.com/databus23/helm-diff/sessions/f186c977-2784-481d-a3cd-64368928ed0e Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com> * fix: resolve goconst lint errors from golangci-lint v2.12.2 Agent-Logs-Url: https://github.com/databus23/helm-diff/sessions/71abf1d7-4882-454b-8d5f-e343f098b80f Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> | 3 个月前 | |
add helper tests (#472) Signed-off-by: yxxhero <aiopsclub@163.com> | 3 年前 | |
fix: strip OCI chart pull progress from rendered manifests (#1040) (#1041) When templating an OCI-hosted chart (or a chart with OCI subcharts), Helm writes the chart pull progress to stdout before the rendered manifests: Pulled: public.ecr.aws/karpenter/karpenter:1.9.0 Digest: sha256:8e3952caafd208cb888fbf97467cd04a4a024a3fba64c84af73039040cc6a371 --- # Source: ... These progress lines leaked into the manifest buffer returned by the `helm template` code paths and got parsed as a YAML document lacking a Kind, breaking the downstream three-way-merge and take-ownership `kubeclient.Build()` calls: unable to decode "": Object 'Kind' is missing in '{"Digest":"...","Pulled":"..."}' This affected `helm diff upgrade --three-way-merge`/`--take-ownership` (the regular diff and `helm diff local` paths were not broken because `manifest.Parse()` already skips documents without apiVersion/kind). Strip the OCI pull progress lines ("Pulled:", "Digest:", and defensively "Pulling:") from the `helm template` output in both places that capture it: * cmd/helm.go `template()` -> upgrade (three-way-merge / take-ownership) * cmd/local.go `renderChart()` -> local diff Stripping at the source ensures `manifest.Generate()` (three-way-merge), the take-ownership `Build()` call, and `manifest.Parse()` all receive clean manifests, and keeps both `helm template` callers symmetric. The lines are matched at the start of a line (column 0), which is safe because top-level Kubernetes manifest keys are apiVersion/kind/metadata/ spec and never "Pulled"/"Digest"/"Pulling"; any homonymous keys nested inside a manifest are indented and therefore not matched. Fixes https://github.com/databus23/helm-diff/issues/1040 Signed-off-by: yxxhero <aiopsclub@163.com> | 1 个月前 | |
feat: add local subcommand to compare two chart folders (#982) * feat: add local subcommand to compare two chart folders * fix: format * fix: address PR review comments for local subcommand - Lowercase error messages to follow Go conventions - Extract stdin reading into prepareStdinValues() to avoid double-read when rendering both charts - Add HELM_BIN env var validation with "helm" default fallback Signed-off-by: yxxhero <aiopsclub@163.com> * fix: pass []byte directly to manifest.Parse instead of converting to string Signed-off-by: yxxhero <aiopsclub@163.com> * fix: check error return values for errcheck linter Signed-off-by: yxxhero <aiopsclub@163.com> * test: add integration tests for local subcommand Signed-off-by: yxxhero <aiopsclub@163.com> * fix: use errors.As instead of type assertion for errorlint Signed-off-by: yxxhero <aiopsclub@163.com> * fix: address PR review comments - Fix prepareStdinValues temp file cleanup: return cleanup func so the temp file survives until after both charts are rendered - Rewrite tests to use cross-platform TestMain re-exec pattern instead of #!/bin/sh shell scripts - Update README --output flag description to include json, structured * fix: address PR review comments from copilot - Remove unreachable --version flag check in local command - Fix prepareStdinValues to handle all stdin value files - Add proper error handling for os.Pipe and ReadFrom in tests - Handle errors in fake helm test helpers Signed-off-by: yxxhero <aiopsclub@163.com> * fix: address PR review comments - Fix temp file leak in prepareStdinValues on error paths - Use %q for quoted chart paths in error messages - Nil out manifest byte slices after parsing to reduce peak memory - Refactor tests to use captureStdout helper - Add tests for prepareStdinValues stdin handling Signed-off-by: yxxhero <aiopsclub@163.com> * fix: resolve ineffectual assignment lint errors in cmd/local.go Signed-off-by: yxxhero <aiopsclub@163.com> * fix: use nolint:ineffassign for manifest nil-ing consistent with other commands Signed-off-by: yxxhero <aiopsclub@163.com> * fix: address PR review comments - reduce peak memory and guard fake helm mode Signed-off-by: yxxhero <aiopsclub@163.com> --------- Signed-off-by: yxxhero <aiopsclub@163.com> Co-authored-by: bo0tzz <git@bo0tzz.me> | 4 个月前 | |
feat: add local subcommand to compare two chart folders (#982) * feat: add local subcommand to compare two chart folders * fix: format * fix: address PR review comments for local subcommand - Lowercase error messages to follow Go conventions - Extract stdin reading into prepareStdinValues() to avoid double-read when rendering both charts - Add HELM_BIN env var validation with "helm" default fallback Signed-off-by: yxxhero <aiopsclub@163.com> * fix: pass []byte directly to manifest.Parse instead of converting to string Signed-off-by: yxxhero <aiopsclub@163.com> * fix: check error return values for errcheck linter Signed-off-by: yxxhero <aiopsclub@163.com> * test: add integration tests for local subcommand Signed-off-by: yxxhero <aiopsclub@163.com> * fix: use errors.As instead of type assertion for errorlint Signed-off-by: yxxhero <aiopsclub@163.com> * fix: address PR review comments - Fix prepareStdinValues temp file cleanup: return cleanup func so the temp file survives until after both charts are rendered - Rewrite tests to use cross-platform TestMain re-exec pattern instead of #!/bin/sh shell scripts - Update README --output flag description to include json, structured * fix: address PR review comments from copilot - Remove unreachable --version flag check in local command - Fix prepareStdinValues to handle all stdin value files - Add proper error handling for os.Pipe and ReadFrom in tests - Handle errors in fake helm test helpers Signed-off-by: yxxhero <aiopsclub@163.com> * fix: address PR review comments - Fix temp file leak in prepareStdinValues on error paths - Use %q for quoted chart paths in error messages - Nil out manifest byte slices after parsing to reduce peak memory - Refactor tests to use captureStdout helper - Add tests for prepareStdinValues stdin handling Signed-off-by: yxxhero <aiopsclub@163.com> * fix: resolve ineffectual assignment lint errors in cmd/local.go Signed-off-by: yxxhero <aiopsclub@163.com> * fix: use nolint:ineffassign for manifest nil-ing consistent with other commands Signed-off-by: yxxhero <aiopsclub@163.com> * fix: address PR review comments - reduce peak memory and guard fake helm mode Signed-off-by: yxxhero <aiopsclub@163.com> --------- Signed-off-by: yxxhero <aiopsclub@163.com> Co-authored-by: bo0tzz <git@bo0tzz.me> | 4 个月前 | |
feat: add structured output mode for helm-diff (#899) * feat: add structured output mode for helm-diff * fix lint errors * fix: log panic msg and add tests for error paths * refactor: improve error handling in structured entry creation and update tests | 6 个月前 | |
Pass --revision to helm diff upgrade (#1046) * fix for #1045 * fix lint | 16 天前 | |
Pass --revision to helm diff upgrade (#1046) * fix for #1045 * fix lint | 16 天前 | |
Pass --revision to helm diff upgrade (#1046) * fix for #1045 * fix lint | 16 天前 | |
feat: add local subcommand to compare two chart folders (#982) * feat: add local subcommand to compare two chart folders * fix: format * fix: address PR review comments for local subcommand - Lowercase error messages to follow Go conventions - Extract stdin reading into prepareStdinValues() to avoid double-read when rendering both charts - Add HELM_BIN env var validation with "helm" default fallback Signed-off-by: yxxhero <aiopsclub@163.com> * fix: pass []byte directly to manifest.Parse instead of converting to string Signed-off-by: yxxhero <aiopsclub@163.com> * fix: check error return values for errcheck linter Signed-off-by: yxxhero <aiopsclub@163.com> * test: add integration tests for local subcommand Signed-off-by: yxxhero <aiopsclub@163.com> * fix: use errors.As instead of type assertion for errorlint Signed-off-by: yxxhero <aiopsclub@163.com> * fix: address PR review comments - Fix prepareStdinValues temp file cleanup: return cleanup func so the temp file survives until after both charts are rendered - Rewrite tests to use cross-platform TestMain re-exec pattern instead of #!/bin/sh shell scripts - Update README --output flag description to include json, structured * fix: address PR review comments from copilot - Remove unreachable --version flag check in local command - Fix prepareStdinValues to handle all stdin value files - Add proper error handling for os.Pipe and ReadFrom in tests - Handle errors in fake helm test helpers Signed-off-by: yxxhero <aiopsclub@163.com> * fix: address PR review comments - Fix temp file leak in prepareStdinValues on error paths - Use %q for quoted chart paths in error messages - Nil out manifest byte slices after parsing to reduce peak memory - Refactor tests to use captureStdout helper - Add tests for prepareStdinValues stdin handling Signed-off-by: yxxhero <aiopsclub@163.com> * fix: resolve ineffectual assignment lint errors in cmd/local.go Signed-off-by: yxxhero <aiopsclub@163.com> * fix: use nolint:ineffassign for manifest nil-ing consistent with other commands Signed-off-by: yxxhero <aiopsclub@163.com> * fix: address PR review comments - reduce peak memory and guard fake helm mode Signed-off-by: yxxhero <aiopsclub@163.com> --------- Signed-off-by: yxxhero <aiopsclub@163.com> Co-authored-by: bo0tzz <git@bo0tzz.me> | 4 个月前 | |
Pass --revision to helm diff upgrade (#1046) * fix for #1045 * fix lint | 16 天前 | |
Pass --revision to helm diff upgrade (#1046) * fix for #1045 * fix lint | 16 天前 | |
Restructre cli to have subcommands This change moves the orginal `helm diff` command to `helm diff upgrade` and adds a `helm diff version` subcommand. Using the root command is depreacted but still works to maintain backward compatibility. This change is a preparation to allow for different modes in the plugin (e.g. diffing between revisions). | 8 年前 |
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
| 6 年前 | ||
| 16 天前 | ||
| 16 天前 | ||
| 3 个月前 | ||
| 3 年前 | ||
| 1 个月前 | ||
| 4 个月前 | ||
| 4 个月前 | ||
| 6 个月前 | ||
| 16 天前 | ||
| 16 天前 | ||
| 16 天前 | ||
| 4 个月前 | ||
| 16 天前 | ||
| 16 天前 | ||
| 8 年前 |