| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
feat(ci): add Storybook PR preview deploys (#7084) ## Problem There's no stable place to share WIP components. Deploying Storybook from a feature branch overwrites `storybook.nango.dev`, and it gets clobbered again on the next `app_ui` merge to master. ## Solution - Every PR now gets its own Storybook at `pr-<N>-storybook.app-development.nango.dev`, uploaded to `previews/pr-<N>-storybook/` in the existing webapp preview bucket. - No infrastructure changes: the CloudFront viewer-request function already derives the S3 prefix from the first host label, and the wildcard cert, DNS, noindex header and 30-day lifecycle rule all cover the new host. No new Actions variables either — it reuses `PREVIEW_APP_UI_ROLE` / `_BUCKET` / `_DISTRIBUTION_ID`. - `preview-webapp.yml` is folded into `preview.yml` so all previews report into **one** sticky PR comment rather than one comment per preview. `comment-init` and `comment-final` are its only writers, avoiding the lost-update race two workflows editing one comment would hit. Adding a future preview is one more job plus one row. - The webapp and Storybook jobs run independently, so a broken story no longer blocks the webapp preview. - Shared logic extracted into `.github/actions/preview-comment` and `.github/actions/deploy-preview`. Fixes [NAN-6403](https://linear.app/nango/issue/NAN-6403) ## Testing - `npm run -w @nangohq/design-system build-storybook` passes; every file in `storybook-static/` ends in a simple extension, so the CloudFront function's extension-less → `index.html` branch only catches real routes. - `actionlint` clean on `preview.yml` (verified it actually validates the local composite-action inputs by re-running against a copy with a misspelled input — it caught it). - No required status check in the `master` ruleset references the old `preview` job name. - **Remaining:** this branch touches `.github/` only, so it doesn't match the path filter. A throwaway change under `packages/design-system/**` is needed to trigger a real run — then check one comment with both rows going 🔄 → ✅, a second commit updating that same comment, the Storybook manager and `?path=/docs/...` / `iframe.html?id=...` loading, `x-robots-tag: noindex` present, and `pr-<N>.app-development.nango.dev` still serving the webapp. | 24 天前 | |
chore: add deploy all workflow (#7380) Add `deploy_all_services` to deploy workflow to deploy all backend services in a single step. <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/NangoHQ/nango/pull/7380?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. --> | 4 天前 | |
chore: update pull_request_template (#3033) My take: having a checklist of things that rarely apply is pretty useless. I (and I am sure not the only one) just always ignore the observability and analytics points. I propose this change to focus on the things that matter: description of the changes, testing and ticket. All of them almost always applies. Also changing to comments so the template instructions don't show once the PR is submitted ## Checklist before requesting a review (skip if just adding/editing APIs & templates) - [ ] I added tests, otherwise the reason is: not applicable 🤔 - [ ] I added observability, otherwise the reason is: not applicable 🙄 - [ ] I added analytics, otherwise the reason is: not applicable 😝 | 1 年前 |
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
| 24 天前 | ||
| 4 天前 | ||
| 1 年前 |