| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
fix: cleanup more types (#4781) ## Changes - cleanup more types Most of them exists in `types` folder <!-- Summary by @propel-code-bot --> --- **Refactor: Centralize and Clean Up Type Definitions** This pull request consolidates and removes redundant or duplicated type and interface definitions across the codebase, especially those located in various `models` folders. Key types such as `Timestamps`, `TimestampsAndDeleted`, `Deleted`, `DBConfig`, `HTTP_METHOD`, and `SyncResult` have been moved to the canonical `@nangohq/types` package, and local or duplicate definitions have been deleted. Files throughout the project have been updated to import types from the central package, and some type exports have been removed or reorganized to enforce consistency across the application. <details> <summary><strong>Key Changes</strong></summary> • Removed duplicated type/interface definitions (e.g., `Timestamps`, `TimestampsAndDeleted`, `Deleted`, `DBConfig`, `HTTP_METHOD`, `SyncResult`) from local files in `models` and centralized them under `@nangohq/types`. • Updated all affected imports and type uses to reference types from `@nangohq/types`. • Added `packages/types/lib/dbConfig/db.ts` to house the `DBConfig` interface and exported it through `index.ts`. • Relocated definition of `FlowDownloadBody` to local usage within `flow.controller.ts`. • Cleaned up and removed redundant or now-centralized type exports in index files (e.g., `models/index.ts`, `types/lib/index.ts`). • Ensured all services, integration tests, and other modules exclusively use types from `@nangohq/types`. </details> <details> <summary><strong>Affected Areas</strong></summary> • `packages/shared/lib/models/Generic.ts` • `packages/shared/lib/models/Sync.ts` • `packages/shared/lib/models/Flow.ts` • `packages/shared/lib/models/Provider.ts` • `packages/shared/lib/models/index.ts` • `packages/shared/lib/services/sync/manager.service.ts` • `packages/shared/lib/services/sync/job.service.ts` • `packages/shared/lib/services/sync/config/endpoint.service.ts` • `packages/shared/lib/utils/encryption.manager.ts` • `packages/node-client/lib/types.ts` • `packages/server/lib/controllers/flow.controller.ts` • `packages/types/lib/dbConfig/db.ts` • `packages/types/lib/index.ts` • `packages/jobs/lib/execution/sync.integration.test.ts` • `packages/jobs/lib/execution/sync.ts` </details> --- *This summary was automatically generated by @propel-code-bot* | 1 年前 | |
feat: add and use `source` for tracking function source (#5899) Replacing `is_public` and `pre_built`, which are booleans used interchangeably (if you know the reason for `is_public` let me know, but as far as I've seen they always have the same value). > [!NOTE] > I'd like to split the migration from the logic but we need the values to be set correctly as soon as the column exists. > For safety, I'm keeping the migration for removing `is_public` and `pre_built` for a second stage | 5 个月前 | |
feat(webhooks): add allow unverified webhooks integration option (NAN-7312) (#7726) NAN-7312 Adds an "Allow unverified webhooks" option on integrations, off by default and editable from the integration settings. When it is on, webhooks with a missing or unverifiable signature are processed and still flagged as unverified. Invalid signatures are always rejected. GitHub App, GitHub App OAuth, Gmail, Salesforce and Microsoft Teams now respect the option, with their existing feature flags kept as a fallback. DB: adds `allow_unverified_webhooks boolean NOT NULL DEFAULT false` to `_nango_configs`. <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/NangoHQ/nango/pull/7726?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. --> | 12 天前 | |
chore: deprecate sync type (#5312) I am not planning to merge this PR before the replacement for sync type (ie: checkpoint) is ready but I wanted to have as many eyes as possible on the incoming changes and make sure I haven't forgotten any other places where the concept of sync type was exposed. cc @khaliqgant @kaposke <!-- Summary by @propel-code-bot --> --- **Deprecate legacy `syncType` references across SDK, CLI, and docs** Adds deprecation annotations to all TypeScript surface areas that still expose `syncType`/`SyncJobsType`, ensuring consumers know the field is slated for removal while runtime behavior stays unchanged. The CLI now injects a default `sync_type: 'full'` when scripts omit it, the Integrations UI no longer renders the badge, and documentation/OpenAPI spec call out the deprecation (though several JSON examples now contain invalid inline comments). <details> <summary><strong>Key Changes</strong></summary> • Tagged `syncType`, `SyncJobsType`, and related DTO fields across `packages/types`, runner SDK, node client, and webhook payload contracts with `@deprecated` JSDoc comments. • Updated `packages/cli/lib/zeroYaml/definitions.ts` so generated zero YAML definitions default `sync_type` to `'full'` when not explicitly provided, matching legacy behavior. • Removed the `Sync type` badge from `packages/webapp/src/pages/Integrations/providerConfigKey/Functions/One.tsx` so the UI no longer surfaces the deprecated concept. • Documentation (implementation guides, SDK reference, functions reference, OpenAPI spec) now explicitly labels `syncType` as deprecated. </details> <details> <summary><strong>Possible Issues</strong></summary> • Documentation JSON snippets now include `// DEPRECATED`, which breaks copy/paste usage. • Defaulting unspecified `sync_type` values to `'full'` in CLI output could hide incremental configurations unless authors consciously override. </details> --- *This summary was automatically generated by @propel-code-bot* | 7 个月前 | |
chore: execute simple function (#7219) Adding support for function execution in jobs/runner. This is the minimal changes to execute a function. I am trying to not refactor the entire runner and jobs all at once so implementation for now piggybacks on current logic, transforming function config into existing NangoProps and executing it as an action in order to minimize the amount of code change. The goal is to avoid big bang PRs that are introducing many changes and are hard to test or review. Over time the current function execution logic will be extended and some part of the runner would need to be refactored but I prefer to do it little by little rather than all at once Note: it is not yet possible to deploy a function that can be invoked. <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/NangoHQ/nango/pull/7219?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. --> | 1 个月前 | |
fix: cleanup more types (#4781) ## Changes - cleanup more types Most of them exists in `types` folder <!-- Summary by @propel-code-bot --> --- **Refactor: Centralize and Clean Up Type Definitions** This pull request consolidates and removes redundant or duplicated type and interface definitions across the codebase, especially those located in various `models` folders. Key types such as `Timestamps`, `TimestampsAndDeleted`, `Deleted`, `DBConfig`, `HTTP_METHOD`, and `SyncResult` have been moved to the canonical `@nangohq/types` package, and local or duplicate definitions have been deleted. Files throughout the project have been updated to import types from the central package, and some type exports have been removed or reorganized to enforce consistency across the application. <details> <summary><strong>Key Changes</strong></summary> • Removed duplicated type/interface definitions (e.g., `Timestamps`, `TimestampsAndDeleted`, `Deleted`, `DBConfig`, `HTTP_METHOD`, `SyncResult`) from local files in `models` and centralized them under `@nangohq/types`. • Updated all affected imports and type uses to reference types from `@nangohq/types`. • Added `packages/types/lib/dbConfig/db.ts` to house the `DBConfig` interface and exported it through `index.ts`. • Relocated definition of `FlowDownloadBody` to local usage within `flow.controller.ts`. • Cleaned up and removed redundant or now-centralized type exports in index files (e.g., `models/index.ts`, `types/lib/index.ts`). • Ensured all services, integration tests, and other modules exclusively use types from `@nangohq/types`. </details> <details> <summary><strong>Affected Areas</strong></summary> • `packages/shared/lib/models/Generic.ts` • `packages/shared/lib/models/Sync.ts` • `packages/shared/lib/models/Flow.ts` • `packages/shared/lib/models/Provider.ts` • `packages/shared/lib/models/index.ts` • `packages/shared/lib/services/sync/manager.service.ts` • `packages/shared/lib/services/sync/job.service.ts` • `packages/shared/lib/services/sync/config/endpoint.service.ts` • `packages/shared/lib/utils/encryption.manager.ts` • `packages/node-client/lib/types.ts` • `packages/server/lib/controllers/flow.controller.ts` • `packages/types/lib/dbConfig/db.ts` • `packages/types/lib/index.ts` • `packages/jobs/lib/execution/sync.integration.test.ts` • `packages/jobs/lib/execution/sync.ts` </details> --- *This summary was automatically generated by @propel-code-bot* | 1 年前 |
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
| 1 年前 | ||
| 5 个月前 | ||
| 12 天前 | ||
| 7 个月前 | ||
| 1 个月前 | ||
| 1 年前 |