HHermès Bélusca-Maïto[CMAKE] Improve build generation (#9523)
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
[ARP][MC] Add Romanian (ro-RO) translation to message table (#5440) | 3 年前 | |
[DWNL] Improve imports, use _countof(), and fix x64 build warnings dwnl\dwnl.c(387): warning C4267: 'function': conversion from 'size_t' to 'DWORD', possible loss of data dwnl\dwnl.c(401): warning C4267: '=': conversion from 'size_t' to 'DWORD', possible loss of data | 5 个月前 | |
Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. | 8 年前 | |
[FTP] Fix invalid call to free() While our glob is a dummy anyway and always returns NULL, the basic idea is that glob returns a NULL terminated array of pointers. The original code only calls blkfree to free any allocation in the array after the first one and doesn't free the array itself. Our code tried to be "smart" and free the array as well, but the array pointer was already changed by a "globbed++", resulting in trying to free an invalid address. Also the free was only called, when glob returned more than one result. This is now fixed by removing the "++", doing the blkfree on "&globbed[1]" and calling free on the originally returned array in all cases. Fixes GCC 13 warning: C:/ReactOS/reactos/base/applications/network/ftp/cmds.c: In function 'globulize': C:/ReactOS/reactos/base/applications/network/ftp/cmds.c:1684:25: error: 'free' called on pointer 'globbed' with nonzero offset 4 [-Werror=free-nonheap-object] 1684 | free((char *)globbed); | ^~~~~~~~~~~~~~~~~~~~~ C:/ReactOS/reactos/base/applications/network/ftp/cmds.c:1669:19: note: returned from 'glob' 1669 | globbed = glob(*cpp); | ^~~~~~~~~~ In our port glob is a dummy that always returns NULL, and the original code does not have a free here, either. | 6 个月前 | |
[IPCONFIG] Fix memory leak for disconnected adapters in ShowInfo (#9324) Signed-off-by: Deep Varkute <deepvarkute04@gmail.com> | 1 个月前 | |
[REACTOS] Stop using non-conforming swprintf / vswprintf Use the underscored versions instead. | 4 个月前 | |
[NETSH] Compare the stack entry against the tail, not the head twice (#9473) RemoveContextFromStack tests pStackEntry == pContextStackHead twice in the same condition, so the first branch takes every entry that happens to be the head, not only the one that is head and tail at once. The branch below it, the one that relinks pStackEntry->pNext->pPrev and moves the head forward, is then unreachable. Removing the head of a stack that has more than one entry sets both head and tail to NULL and frees only that entry, so the remaining entries are lost and leaked. The body of the first branch is what says which test was meant: it clears both ends, and that is only correct for the single element case. Compare the second test against pContextStackTail. I found this by reading, not by hitting it in a running netsh session, so I have not confirmed the leak on a live context stack. Reviewed-by: Whindmar Saksit <whindsaks@proton.me> Reviewed-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org> Reviewed-by: Eric Kohl <eric.kohl@reactos.org> Signed-off-by: Dmitry Rantovov <rantovov5@gmail.com> | 16 天前 | |
[CMDUTILS][NETWORK][LOGOFF][RUNAS][CMD][SYSTEM] Improve imports and headers for some tools | 5 个月前 | |
[NSLOOKUP] Fix calls to stricmp and strnicmp GCC does not complain about this! | 1 个月前 | |
[CMAKE] Improve build generation (#9523) User-mode: - DNSAPI uses the adns library. - CONSOLE.CPL uses the concfg library. - DISKPART, PING use the conutils library. - ADVAPI32 uses the cryptlib library. - EVENTLOG uses the evtlib library. - NTVDM uses the fast486 library. - HID uses the hidparser_um library. - WINEMP3.ACM uses the libmpg123 library. - OPENGL32 uses the mesa library. - LOCALSPL uses the skiplist library. - IPHLPAPI, WSHTCPIP use the tdilib library. - TIMEDATE.CPL, SYSSETUP use the tzlib library. - DRWTSN32, DXDIAG, SYSDM.CPL, SYSTEMINFO use the udmihelp library. - CABINET, VFDLIB, dbghelp_apitest use the zlib library. Drivers: - PCIX uses the arbiter library. - KSECDD uses the cryptlib library. - I8042PRT uses the dmilib library. - FTFD uses the freetype library. - HIDPARSE uses the hidparser_km library. - ATAPI, SCSIPORT, STORPORT, USBSTOR use the sptilib library. - NETKVM uses the virtio library. - BTRFS uses the zlib library. Sound: - backpln/audio_test use the libsamplerate library. - KMIXER, mmixer_test, WDMAUD, WDMAUD.DRV use the libsamplerate and mmixer libraries. | 7 天前 | |
[CMAKE] Remove global _CRT_NON_CONFORMING_SWPRINTFS Instead define it only in 3rd-party code where required. Most of these will go away with future wine-syncs. | 4 个月前 | |
[SDK][SHELL32_APITEST] Fix some warnings (#7031) | 1 年前 | |
[TRACERT] Improve imports, simplify code, and fix x64 build warning tracert\tracert.cpp(209): warning C4267: 'argument': conversion from 'size_t' to 'socklen_t', possible loss of data | 5 个月前 | |
Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. | 8 年前 | |
[WLANCONF] Improve imports and fix x64 build warnings wlanconf\wlanconf.c(592): warning C4267: '=': conversion from 'size_t' to 'DWORD', possible loss of data wlanconf\wlanconf.c(602),(683): warning C4267: '=': conversion from 'size_t' to 'ULONG', possible loss of data | 5 个月前 | |
[CMAKE] Do not use USE_CLANG_CL variable in CMake scripts | 4 年前 |