| Files | Last commit | Last update |
|---|---|---|
fix(pr): address second-round review findings for pr comment edit/delete - Add BaseRepo auto-detection to edit and delete commands - Add --body-file/-F support to edit command (including stdin via -) - Add empty body validation to edit command - Add comment ID > 0 validation to both edit and delete - Improve error messages for invalid comment IDs - Add updated timestamp to edit command output Refs #296 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> | 4 months ago | |
refactor: unify 5 duplicated getBody() to cmdutil.ReadBody delegation (#427) 5 commands had near-identical ~30-line getBody() copies that duplicated cmdutil.ReadBody logic (mutual exclusion, inline scan, file/stdin reading). The duplication was the root cause of #424 (inline --body bypassed scanning because local copies didn't sync ReadBody's ScanContentForSecrets addition). Replaced each with a 7-line delegate that: - Calls cmdutil.ReadBody (which scans inline + file + stdin) - Preserves TrimSpace for file/stdin paths (behavioral parity) - Returns ReadBody errors directly (same error messages) Files: - pkg/cmd/issue/comment/comment.go - pkg/cmd/issue/comment/edit/edit.go - pkg/cmd/issue/edit/edit.go - pkg/cmd/pr/comment/comment.go - pkg/cmd/pr/comment/edit/edit.go All existing tests pass without modification (ReadBody has the same error wrapping as the local copies had). Refs #427 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> | 3 months ago | |
refactor(pr): rename PRNumber to Number for field naming consistency Replace PRNumber with Number in ReplyOptions and ResolveOptions structs to match the convention used by all other PR commands. - pkg/cmd/pr/reply/reply.go: ReplyOptions.PRNumber → Number - pkg/cmd/pr/reply/reply_test.go: update test references - pkg/cmd/pr/comment/resolve/resolve.go: ResolveOptions.PRNumber → Number - pkg/cmd/pr/comment/resolve/resolve_test.go: update test references Closes #343 Co-Authored-By: Claude <noreply@anthropic.com> | 4 months ago | |
refactor: unify 5 duplicated getBody() to cmdutil.ReadBody delegation (#427) 5 commands had near-identical ~30-line getBody() copies that duplicated cmdutil.ReadBody logic (mutual exclusion, inline scan, file/stdin reading). The duplication was the root cause of #424 (inline --body bypassed scanning because local copies didn't sync ReadBody's ScanContentForSecrets addition). Replaced each with a 7-line delegate that: - Calls cmdutil.ReadBody (which scans inline + file + stdin) - Preserves TrimSpace for file/stdin paths (behavioral parity) - Returns ReadBody errors directly (same error messages) Files: - pkg/cmd/issue/comment/comment.go - pkg/cmd/issue/comment/edit/edit.go - pkg/cmd/issue/edit/edit.go - pkg/cmd/pr/comment/comment.go - pkg/cmd/pr/comment/edit/edit.go All existing tests pass without modification (ReadBody has the same error wrapping as the local copies had). Refs #427 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> | 3 months ago | |
fix(security): scan inline --body/--comment/--description/--notes for secrets 10 inline flag paths bypassed ScanContentForSecrets, allowing AI agents to accidentally submit content containing the current GC_TOKEN value. Fixed paths (issue #424): - issue comment --body (local getBody: add scan to inline branch) - issue comment edit --body (same) - issue edit --body (same) - pr comment --body (same) - pr comment edit --body (same) - pr edit --body (add scan before direct assignment) - pr review --comment (scan after --comment-file block, before API calls) - milestone edit --description (scan before HTTP client creation) - release create --notes (scan before HTTP client creation) - release edit --notes (scan after GetRelease, before PATCH) Preventive: ReadText (text_file.go) now calls ScanContentForSecrets. Tests: - cmdutil: 5 integration tests (ReadBody/ReadText/ReadTextFile/ ReadTextFromFlag reject token content) - 10 command-level unit tests (one per bypass path) - System test (secret-scan.txtar): 9 inline paths verified end-to-end with fake token, plus negative control - docs/REGRESSION.md: documented secret scanning regression Refs #424 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> | 3 months ago |
| Files | Last commit | Last update |
|---|---|---|
| 4 months ago | ||
| 3 months ago | ||
| 4 months ago | ||
| 3 months ago | ||
| 3 months ago |