| Files | Last commit | Last update |
|---|---|---|
fix(ci): remove unused truncate leftover; JSON-encode paths in doctor test manifests Two CI failures on the first run of this batch: - Lint: the C7 rewiring replaced the call site but the local truncate body in release/list survived (a scripted replacement missed silently); golangci-lint's unused check caught it. Removed. The full-repo lint run is now part of this batch's verification (it was previously only run per-directory). - Test (windows): the npm-prefix conflict fixture interpolated the temp-dir path into the manifest JSON raw — on Windows those paths carry backslashes, which are invalid JSON escape sequences, so json.Unmarshal failed, npmPrefix returned empty, and the conflict branch under test silently never ran (green on Linux, where paths have no backslashes). Both path-carrying manifests in the file now use json.Marshal, which cannot emit invalid JSON. Co-Authored-By: Claude Code <noreply@anthropic.com> | 1 month ago | |
fix(review): address multi-role review findings for the 608 batch Four independent reviewers (code/security/test/docs) cleared the batch with no P1/P2 code findings; their P2/P3 findings are fixed here: - sync-docs-version.sh: add the left boundary to the version patterns (code review). Without it, a new version that digit-prefix-extends the old one (0.6.1 -> 10.6.1) left the residual check matching the old version embedded in the new string — the sync could never exit 0 — and a longer mention in the docs (v10.6.1) was silently rewritten to v10.7.0. The consumed-boundary form has a known limitation for back-to-back same-version tokens, documented in the comment; the residual check fails loudly rather than missing it. Two new test cases: v10.6.1 survival, and the true self-heal variant (first file already at target, another lagging) that the old README-only detection silently no-op'ed. - list tests: lock the sort-before-trim order (test+code review). The original pagination fixture was monotonic, so trim-first and sort-first were indistinguishable; the new case gives a page-2 release beyond the accumulation window the newest published_at and asserts it heads the trimmed output. Also cover the --page + --limit=100 boundary of the mutual-exclusion guard. - delete tests: add the success path (DELETE 204 -> "Deleted release") and the GetRelease 404 WrapNotFound path (exit 3) — the success branch was completely unlocked should the platform ever enable the delete endpoint. - docs: AI-GUIDE.md pinned gitcode-cli==0.11.1 one release behind README (a version pin the URL-based sync can never reach); the 405 guidance wording claimed an unconditional html_url link where the code degrades to URL-less text; the (latest) marker note now states the --page window semantics. - test-npm-install-upgrade.js: correct the completion-assertion comment — "gc" is not a prefix of "gitcode" (g-c vs g-i); the real protection is the anchored ( |$)/$ patterns. Recorded without code changes: prerelease versions (v1.0.0-rc.1) are rejected by the new docs gate (fail-closed, no rc has ever been shipped); the --page nil-slice JSON concern is a false positive (WriteJSON normalizes top-level nil slices); e2e-only completion coverage is tracked by the installCompletions injection-point item. Co-Authored-By: Claude Code <noreply@anthropic.com> | 1 month ago |