已开启
AIV Jetty build failure with CANN C API headers #232
AIV Jetty build failure with CANN C API headers #232
已开启
KaranocaVe创建于 13 天前
KaranocaVe
KaranocaVe
13 天前

AIV Jetty build failure with CANN C API headers

Problem

The AIV Jetty implementation cannot be compiled with the CANN C API headers. It includes c_api/utils/sys_var.h, but the SDK provides c_api/sys_var/sys_var.h. Once that include is corrected, compilation still fails because the implementation uses ReadGmBypassDCache and WriteGmBypassDCache, while the declared APIs are ReadGmByPassDCache and WriteGmByPassDCache.

Fix

Correct the include path and the helper-name casing in hcomm_aiv_urma_jetty.h.

Verification

With CANN 9.2.0-beta.2 and target dav-3510, examples/simt_jetty fails at baseline and builds successfully after the correction. Runtime verification requires a DAV_3510 two-device environment.

关联 Issue: https://gitcode.com/cann/asc-comm/issues/46

likedislike
合并受阻
KaranocaVeKaranocaVe
13 天前 创建了 pull request,commit ea5744f3
KaranocaVeKaranocaVe
13 天前 关联了issue:AIV Jetty source does not build against the CANN C API headers
atomgit-bot
atomgit-bot
13 天前 评论:

变更摘要

本次变更修复 hcomm_aiv_urma_jetty.h 在 CANN C API 头文件下无法编译的问题。核心改动是将错误的头文件引用路径修正为 SDK 实际提供的位置,并统一 helper 名称大小写,使实现中调用的 ReadGmByPassDCache / WriteGmByPassDCache 与所声明的接口名一致。

主要改动

  • 修正头文件引用路径: 将 #include <c_api/utils/sys_var.h> 改为 #include <c_api/sys_var/sys_var.h>,使包含路径与 CANN C API 提供的实际头文件位置匹配。
  • 修正读取 helper 名称大小写: 将 ReadGmBypassDCache 统一改为 ReadGmByPassDCache,涉及 HcommPeer 与 HcommJettyImpl 构造函数、PollCqWhenSqOverflow、PollCq、Drain 等方法中的系统变量读取调用。
  • 修正写入 helper 名称大小写: 将 WriteGmBypassDCache 统一改为 WriteGmByPassDCache,涉及 AdvanceSq、RingDoorbell 以及 PollCq 中对 cqTailAddr、cqDoorbellAddr、completionTailAddr 的写入调用。

以上改动仅调整接口名与引用路径,不改变原有逻辑;修正后可配合 CANN 9.2.0-beta.2 与 dav-3510 目标成功编译 examples/simt_jetty。

likedislike
不准确?
atomgit-bot
atomgit-bot
13 天前 评论:

代码审查

✅ 未发现问题

likedislike
不准确?
CANN-robotCANN-robot成员
13 天前 添加了label:cann-cla/yes
CANN-robot
CANN-robot成员
13 天前 评论:

CLA Signature Pass

KaranocaVe, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
CANN-robot
CANN-robot成员
13 天前 评论:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.


PR Approval Progress

⚠️ This PR does not yet meet the following requirements:lgtm (requires ≥ 2 person(s) per module)、approve (requires ≥ 1 person(s) per module)

Module Approval Details

module lgtm status approve status
src ❌ (0/2)(You can also ask: kong0808, DragonBornHD84, 诸葛洵, 闫庆尚, chenma) ❌ (0/1)(You can also ask: YeZZzzz1, qin437231, houyuyang, bluesky901, 石楠翔)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)
likedislike
KaranocaVe
KaranocaVe
13 天前 评论:

/compile

likedislike
KaranocaVeKaranocaVe
13 天前 预合并成功(commit_id: 65b304c15220a3bdbacd61bc58b60ec865097dd5)
CANN-robot
CANN-robot成员
13 天前 评论:
🚀 CI 流水线已启动
📋 执行详情: 点击查看流水线
likedislike
CANN-robotCANN-robot成员
13 天前 添加了label:ci-pipeline-running
CANN-robotCANN-robot成员
13 天前 删除了label:ci-pipeline-running
CANN-robotCANN-robot成员
13 天前 添加了label:ci-pipeline-passed