Merged
fix(examples): resolve Ain: basic_ring #276
chen_xu0513Add on 24 days ago
fix(examples): resolve Ain: basic_ring #276
Merged
chen_xu0513Add on 24 days ago
chen_xu0513Collaborators
24 days ago

当前PR是否有AI参与:

[x] 否

[ ] 是
__1. AI Agent 平台:
__2. AI 模型:
__3. Prompt上下文 :

PR功能描述 / 为什么需要这个合入**:

删除ain_impl_def.h中冗余的临时结构体,并修正样例的cmake文件,以解决头文件hcomm_res_defs.h找不到的问题

该PR关联的issue

fixes#90(格式为fixes #<issue号>, 或者resolves #<issue号>): fixes #

希望检视人员了解:

改动类型 / Change Type

测试信息 / Testing

检查清单 / Checklist

likedislike
Pull Request has been successfully merged by CANN-robot.
(Thank you for chen_xu0513's contribution.)
Cchen_xu0513Collaborators
24 days ago Created pull request, commit ad466771
atomgit-bot
atomgit-bot
24 days ago Comments:

变更摘要

本 PR 针对 src/aicore/ain/impl/ain_impl_def.h 进行头文件整理,将原先在本文件中就地定义的 HcommWindow、HcommTeamSyncMem、HcommTeam 等结构体及其相关依赖头文件移除,改为统一引用 hcomm/hcomm_team_entity_defs.h,使 AIN 实现层不再重复维护通信实体相关的类型定义,而是复用公共的实体定义头文件。

主要改动

  • 移除本地结构体定义: 删除了 HcommWindow(含 netWin、lsaWin 等窗口字段)、HcommTeamSyncMem(含 remoteMems、syncMemReq 等同步内存字段)以及 HcommTeam(含 engine、memberNum、selfMemberId、channelsBaseAddr、syncMem 等团队描述字段)三处 typedef struct 定义。
  • 调整头文件依赖: 去除了 hcomm_res_defs.h 与 hcomm_team_defs.h 两个 #include,仅保留 hcomm/hcomm.h。
  • 引入统一实体定义头文件: 新增 #include "hcomm/hcomm_team_entity_defs.h",由该头文件为上述被删除的结构体提供类型来源。
likedislike
Incorrect?
atomgit-bot
atomgit-bot
24 days ago Comments:

代码审查

✅ 未发现问题

likedislike
Incorrect?
CANN-robotCANN-robotCollaborators
24 days ago Added label: cann-cla/yes
CANN-robot
CANN-robotCollaborators
24 days ago Comments:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.


PR Approval Progress

✅ Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
examples ✅ YeZZzzz1, 苏建加 (2/2) ✅ YeZZzzz1 (1/1)
src ✅ YeZZzzz1, 苏建加 (2/2) ✅ YeZZzzz1 (1/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)

CLA Signature Pass

chen_xu0513, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
CANN-robot
CANN-robotCollaborators
24 days ago Comments:

CLA Signature Pass

chen_xu0513, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
Cchen_xu0513Collaborators
24 days ago Modify description of pull request
Cchen_xu0513Collaborators
24 days ago Pre merge succeeded (commit_id: 1ffb00cee084fd7b454b5bae82544b6bdc279a27)
Cchen_xu0513Collaborators
24 days ago Force-pushed 1 commits:dade055c-update ain example
Cchen_xu0513Collaborators
24 days ago Pre merge succeeded (commit_id: 64c1ab652b333ee2249bb5632cd77c43cd760213)
CANN-robotCANN-robotCollaborators
24 days ago Removed label: cann-cla/yes
CANN-robotCANN-robotCollaborators
24 days ago Added label: cann-cla/yes
chen_xu0513Collaborators
24 days ago Comments:

compile

likedislike
Cchen_xu0513Collaborators
24 days ago Pre merge succeeded (commit_id: d9c2628fc8d2cea190970a0d33ca6c6e4a00011a)
Cchen_xu0513Collaborators
24 days ago Modify description of pull request
CANN-robot
CANN-robotCollaborators
24 days ago Comments:
🚀 CI 流水线已启动
📋 执行详情: 点击查看流水线
likedislike
CANN-robotCANN-robotCollaborators
24 days ago Added label: ci-pipeline-running
5 event messages are collapsed here。 See more
Cchen_xu0513Collaborators
24 days ago Modify description of pull request
suqwe
suqweCollaborators
24 days ago Comments:

/lgtm

likedislike
YeZZzzz1Collaborators
24 days ago Comments:

/approve

likedislike
CANN-robotCANN-robotCollaborators
24 days ago Added label: lgtmapproved
CANN-robotCANN-robotCollaborators
24 days ago Merged pull request