已合并
取消编译过程对ASCEND_CANN_PACKAGE_PATH的引用 #2355
liuyang163创建于 5月20日
取消编译过程对ASCEND_CANN_PACKAGE_PATH的引用 #2355
已合并
liuyang163创建于 5月20日
liuyang163
5月20日

描述

取消编译过程对ASCEND_CANN_PACKAGE_PATH的引用

关联的Issue

测试

文档更新

类型标签

likedislike
Pull Request已成功合入, 合并人@CANN-robot
(感谢 liuyang163 的贡献)
Lliuyang163
5月20日 创建了 pull request,commit 96fbb6c8
CANN-robot
CANN-robot成员
5月20日 评论:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here。
You can get sig-info at here


PR Approval Progress

✅ Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
cmake ✅ yangbinhua, chenyiyuan, 诸葛洵 (3/2) ✅ 诸葛洵 (1/1)
impl/aicpu_api ✅ chenyiyuan, 诸葛洵, yangbinhua (3/2) ✅ chenyiyuan (1/1)
repo-cann/asc-devkit ✅ yangbinhua, chenyiyuan, XuebinYang, 诸葛洵 (4/2) ✅ 诸葛洵, chenyiyuan, XuebinYang (3/1)
tools/aclrtc ✅ YANXI_ZHAO, 诸葛洵, yangbinhua, chenyiyuan (4/2) ✅ YANXI_ZHAO (1/1)
tools/build ✅ 诸葛洵, yangbinhua, XuebinYang, chenyiyuan (4/2) ✅ XuebinYang (1/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)

CLA Signature Pass

liuyang163, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
CANN-robotCANN-robot成员
5月20日 添加了label:cann-cla/yes
CANN-robotCANN-robot成员
5月20日 将zengjuan,zhanghao_0689,wk0911,wulinyu,zhuliangying,kong0808,dengjing_aoe,YeZZzzz1,bluesky901,yangbinhua,gao_dafa,chenyiyuan,xun_zhuge,bianque,houyuyang,YANXI_ZHAO,shi_nanxiang,wuyang_hw,ascendhjh,DragonBornHD84,jiangZD设为评审人
CANN-robotCANN-robot成员
5月20日 将zengjuan,zhanghao_0689,wk0911,wulinyu,zhuliangying,kong0808,dengjing_aoe,YeZZzzz1,bluesky901,yangbinhua,gao_dafa,chenyiyuan,xun_zhuge,bianque,houyuyang,YANXI_ZHAO,shi_nanxiang,wuyang_hw,ascendhjh,DragonBornHD84,jiangZD设为审查人
此处折叠了52条消息 查看更多
CANN-robot
CANN-robot成员
5月21日 评论:

Review Guide

This pull-request passes review.
Committers who wrote a comment of /approve are: YANXI_ZHAO, XuebinYang, 诸葛洵, chenyiyuan.
Reviewers who wrote a comment of /lgtm are: YANXI_ZHAO, 诸葛洵, XuebinYang, yangbinhua, chenyiyuan.

likedislike
CANN-robot
CANN-robot成员
5月21日 评论:

The MR can not be merged, because of CodeReview discussion not resolved

If you want to solve this problem, you can click here to do it in the FAQs.

likedislike
yangbinhua
yangbinhua成员
5月21日 评论:

/check-pr

likedislike
CANN-robot
CANN-robot成员
5月21日 评论:

Review Guide

This pull-request passes review.
Committers who wrote a comment of /approve are: XuebinYang, 诸葛洵, chenyiyuan, YANXI_ZHAO.
Reviewers who wrote a comment of /lgtm are: XuebinYang, YANXI_ZHAO, 诸葛洵, chenyiyuan, yangbinhua.

likedislike
CANN-robotCANN-robot成员
5月21日 合入了pull request