Merged
fix: isolate MC2 HCOMM initialization symbols #5326
fix: isolate MC2 HCOMM initialization symbols #5326
Merged
izanaamiAdd on Aug 25
izanaami
izanaamiCollaborators
Aug 25

描述

关联的Issue

测试

文档更新

类型标签

likedislike
Pull Request has been successfully merged by CANN-robot.
(Thank you for izanaami's contribution.)
izanaamiizanaamiCollaborators
Aug 25 Created pull request, commit e2d92b05
atomgit-bot
atomgit-bot
Aug 25 Comments:

变更摘要

该 PR 旨在隔离 MC2 的 HCOMM 初始化符号,将 HCOMM 动态库初始化相关函数统一重命名为带 Mc2 前缀的符号,以避免与其他模块的同名符号发生冲突。改动仅涉及符号重命名及对应声明、注释的同步更新,不改变函数实现逻辑与初始化行为。

主要改动

  • 重命名 HcommDeviceDlInit 为 Mc2HcommDeviceDlInit:在 hcomm_device_dlsym.h 中更新声明,并在 hcomm_device_dlsym.cc 与 device_compat.cc 中同步替换调用与定义,使 MC2 的动态库管理入口符号具备独立命名空间。
  • 重命名 HcommPrimitivesDlInit 为 Mc2HcommPrimitivesDlInit:在 hcomm_primitives_dl.h 中更新声明,并在 hcomm_primitives_dl.cc、hcomm_dlsym.cc 以及 hcomm_device_dlsym.cc 中同步替换实现与调用点,保持各初始化链路的调用一致性。
  • 同步更新注释与文件结尾格式:在 hcomm_device_dlsym.h 中将注释由「动态库管理接口」调整为「MC2动态库管理接口」,并在 hcomm_dlsym.cc、hcomm_device_dlsym.h 中补充文件末尾换行。
likedislike
Incorrect?
atomgit-bot
atomgit-bot
Aug 25 Comments:

代码审查

✅ 未发现问题

likedislike
Incorrect?
CANN-robotCANN-robotCollaborators
Aug 25 Added label: cann-cla/yes
CANN-robot
CANN-robotCollaborators
Aug 25 Comments:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.


PR Approval Progress

✅ Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
9.1.0 ✅ Andy-lb, 石楠翔 (2/2) ✅ Andy-lb (1/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)
likedislike
CANN-robot
CANN-robotCollaborators
Aug 25 Comments:

CLA Signature Pass

jiangxinyu3, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
CANN-robotCANN-robotCollaborators
Aug 25 Set zengjuan,zhanghao_0689,suqwe,wulinyu,kong0808,dengjing_aoe,YeZZzzz1,bluesky901,TianXL,yangbinhua,zhudi22,chenyiyuan,xun_zhuge,XuebinYang,sjtulxh,bianque,houyuyang,Lycheeeee,YANXI_ZHAO,chentianyu19,shi_nanxiang,wuyang_hw,ascendhjh,hujiawen_kaven,wangxiaozhi,DragonBornHD84,louyuxuan,jiangtao_rts,hyolee,yukangchen,hanxiaolong,gcw_kUomxQ2l,Andy-lb as approver
CANN-robotCANN-robotCollaborators
Aug 25 Set TianXL,jiangtao_rts,hanxiaolong,gcw_kUomxQ2l,Andy-lb as approver
izanaami
izanaamiCollaborators
Aug 25 Comments:

compile

likedislike
izanaamiizanaamiCollaborators
Aug 25 Pre merge succeeded (commit_id: bd57aef67c6e0e71c4437aaac2dd54af9fbfcecb)
gao_dafaCollaborators
Aug 25 Comments:

jiangxinyu3,感谢您的提交,建议在完成PR充分自验证后,再触发线上构建任务。

若您的PR已具备检视条件,可根据下表的责任田,@对应的committer进行代码检视,我们会在第一时间对您的提交进行处理。

代码责任田:

module committer
adv_api chenyiyuan, wuyang_hw
basic_api chenyiyuan, wuyang_hw
c_api pangfd, haipingmao
cmake xun_zhuge, DragonBornHD84
docs munanhw, ai_xin
examples changxianyu, bianque
simt_api wulinyu, zhanghao_0689
scripts xun_zhuge, kevin365
tools YANXI_ZHAO, XuebinYang, sjtulxh

💡 如您不确定可以@谁,可以直接@我或者ascend-c sig的maintainer,xun_zhuge和ascendhjh,我们会为您分配合适的committer进行代码检视。

再次感谢您参与CANN的社区贡献。

likedislike
CANN-robotCANN-robotCollaborators
Aug 25 Added label: ci-pipeline-running
CANN-robot
CANN-robotCollaborators
Aug 25 Comments:

流水线任务触发成功
任务链接 [3bb385bbc30244d6ac8578022deda041][流水线指导]

任务名称状态日志下载链接
SCA ✅ SUCCESS >>>>>
antipoison ✅ SUCCESS >>>>>
codecheck ✅ SUCCESS >>>>>
codecheck_Pr ✅ SUCCESS
pre_comment ✅ SUCCESS >>>>>
codecheck_codestyle ⚠️ WARNING >>>>>
codecheck_precommit ⚠️ WARNING >>>>> >>>>>

[2026-08-25 16:04:35]    CI执行结束

likedislike
CANN-robot
CANN-robotCollaborators
Aug 25 Comments:

流水线任务触发成功
任务链接 [e6d4202335d14025a497ffa2aafa7b70][流水线指导]

任务名称状态日志下载链接
pre_comment ✅ SUCCESS >>>>>
UT_Test_adv_test_one ✅ SUCCESS
UT_Test_adv_test_two ✅ SUCCESS
UT_Test_basic_test_two ✅ SUCCESS
UT_Test_basic_test_three ✅ SUCCESS
UT_Test_basic_test_four ✅ SUCCESS
UT_Test_basic_test_five ✅ SUCCESS
UT_Test_arm ✅ SUCCESS
UT_Test_report ✅ SUCCESS >>>>>

[2026-08-25 16:27:05]    CI执行结束

likedislike
CANN-robot
CANN-robotCollaborators
Aug 25 Comments:

流水线任务触发成功
任务链接 [c8788537173b44f49733ddf10a3cc1c8][流水线指导]

任务名称状态日志下载链接
Compile_Ascend_X86 ✅ SUCCESS >>>>> >>>>>
Compile_Ascend_ARM ✅ SUCCESS >>>>> >>>>>
pre_comment ✅ SUCCESS >>>>>
PreSmoke_A900_npupool ✅ SUCCESS >>>>>

[2026-08-25 16:11:10]    CI执行结束

likedislike
CANN-robotCANN-robotCollaborators
Aug 25 Removed label: ci-pipeline-running
CANN-robotCANN-robotCollaborators
Aug 25 Added label: ci-pipeline-passed
Andy-lbCollaborators
Aug 25 Comments:

/approve

likedislike
CANN-robotCANN-robotCollaborators
Aug 25 Added label: approved
shi_nanxiangCollaborators
Aug 25 Comments:

/lgtm

likedislike
CANN-robotCANN-robotCollaborators
Aug 25 Added label: lgtm
CANN-robotCANN-robotCollaborators
Aug 25 Merged pull request