Merged
topk sync bugfix #6352
DianaBlessYouAdd on Sep 23
topk sync bugfix #6352
Merged
Merged fromlijunjie147/asc-devkit_9351topk-exampleintocann/asc-devkitmaster
Pull Request has been successfully merged by CANN-robot.
（Thank you for DianaBlessYou's contribution.）Sep 23 Created pull request, commit 995f5660
atomgit-bot
Sep 23 Comments：
Sep 23 Comments：
变更摘要
本 PR 为 topk sync bugfix 的缺陷修复，主要针对 impl/adv_api/detail/sort/topk/topk_3510_impl.h 中 TopKCompute 的同步逻辑进行补充。在 isHasfinish 分支内读取 finishLocal 的值之前，新增了 MTE2_S 硬件事件的同步，以保证数据搬运（MTE2）与标量（Scalar）读取之间的正确顺序。
主要改动
- 新增
MTE2_S事件同步: 在TopKCompute的isHasfinish分支中，通过GetTPipePtr()->FetchEventID(HardEvent::MTE2_S)获取事件 ID，并调用SetFlag<HardEvent::MTE2_S>与WaitFlag<HardEvent::MTE2_S>建立等待关系。 - 保障
finishLocal读取时序: 该同步插入在finishLocal.GetValue(j)之前，使标量读取finishLocal前先等待相关数据搬运完成，修正topk场景下的同步缺陷。
Incorrect?
atomgit-bot
Sep 23 Comments：
Sep 23 Comments：
Sep 23 Added label: cann-cla/yes
CANN-robot
Sep 23 Comments：
Sep 23 Comments：
CANN-robot
Sep 23 Comments：
Sep 23 Comments：
Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.
PR Approval Progress
✅ Congratulations! All modules have met the lgtm and approve requirements.
Module Approval Details
| module | lgtm status | approve status |
|---|---|---|
| repo-cann/asc-devkit | ✅ wuyang_hw, Lycheeeee (2/2) | ✅ wuyang_hw, Lycheeeee (2/1) |
💡 Tip:
- Committer can comment
/approveor/lgtm- Commenting
/approveimplies both code review (lgtm) and intent to merge (approve)
CANN-robotSep 23 Set zengjuan,zhanghao_0689,suqwe,wulinyu,kong0808,dengjing_aoe,YeZZzzz1,bluesky901,yangbinhua,zhudi22,chenyiyuan,xun_zhuge,XuebinYang,sjtulxh,bianque,houyuyang,Lycheeeee,YANXI_ZHAO,chentianyu19,shi_nanxiang,wuyang_hw,jiangxinyu3,ascendhjh,hujiawen_kaven,wangxiaozhi,DragonBornHD84,louyuxuan,hyolee,yukangchen as approver
Sep 23 Set zengjuan,zhanghao_0689,suqwe,wulinyu,kong0808,dengjing_aoe,YeZZzzz1,bluesky901,yangbinhua,zhudi22,chenyiyuan,xun_zhuge,XuebinYang,sjtulxh,bianque,houyuyang,Lycheeeee,YANXI_ZHAO,chentianyu19,shi_nanxiang,wuyang_hw,jiangxinyu3,ascendhjh,hujiawen_kaven,wangxiaozhi,DragonBornHD84,louyuxuan,hyolee,yukangchen as approver
CANN-robotSep 23 Set zengjuan,zhanghao_0689,suqwe,wulinyu,kong0808,dengjing_aoe,YeZZzzz1,bluesky901,yangbinhua,zhudi22,chenyiyuan,xun_zhuge,XuebinYang,sjtulxh,bianque,houyuyang,Lycheeeee,YANXI_ZHAO,chentianyu19,shi_nanxiang,wuyang_hw,jiangxinyu3,ascendhjh,hujiawen_kaven,wangxiaozhi,DragonBornHD84,louyuxuan,hyolee,yukangchen as approver
Sep 23 Set zengjuan,zhanghao_0689,suqwe,wulinyu,kong0808,dengjing_aoe,YeZZzzz1,bluesky901,yangbinhua,zhudi22,chenyiyuan,xun_zhuge,XuebinYang,sjtulxh,bianque,houyuyang,Lycheeeee,YANXI_ZHAO,chentianyu19,shi_nanxiang,wuyang_hw,jiangxinyu3,ascendhjh,hujiawen_kaven,wangxiaozhi,DragonBornHD84,louyuxuan,hyolee,yukangchen as approver
DianaBlessYou
Sep 24 Comments：
Sep 24 Comments：
/compile
Sep 24 Pre merge succeeded (commit_id: 91da32f1f7dfbde694c870b1ff199a4ead310f73)
CANN-robot
Sep 24 Comments：
Sep 24 Comments：
| 🚀 CI 流水线已启动 |
|---|
| 📋 执行详情: 点击查看流水线 |
Sep 24 Added label: ci-pipeline-running
Sep 24 Removed label: ci-pipeline-running
Sep 24 Added label: ci-pipeline-passed
Sep 24 Modify description of pull request
Sep 28 Added label: approved
Sep 28 Added label: lgtm
Sep 28 Removed label: ci-pipeline-passed
CANN-robot
Sep 28 Comments：
Sep 28 Comments：
The following label is not ready.
ci-pipeline-passed: The ci-pipeline-passed label is expired as added over 72 hours. Please use /compile to recompile.
DianaBlessYou
Sep 28 Comments：
Sep 28 Comments：
/compile
Sep 28 Pre merge succeeded (commit_id: e481e0bea18368d5dbbd12b1aee96a0490bb991e)
CANN-robot
Sep 28 Comments：
Sep 28 Comments：
| 🚀 CI 流水线已启动 |
|---|
| 📋 执行详情: 点击查看流水线 |
Sep 28 Added label: ci-pipeline-running
Sep 28 Removed label: ci-pipeline-running
Sep 28 Added label: ci-pipeline-passed
Sep 28 Merged pull request
描述
关联的Issue
#1736
测试
文档更新
类型标签