已合并
fix(mla) issue288: restrict MASK_TYPE_SWA_NORM for decode path #2078
fix(mla) issue288: restrict MASK_TYPE_SWA_NORM for decode path #2078
已合并
ivanS创建于 4月30日
ivanS
4月30日

描述

fix(mla): add MASK_TYPE_SWA_NORM and windowSize support for decode path

image.png

checklist

likedislike
Pull Request已成功合入, 合并人@CANN-robot
(感谢 ivanS 的贡献)
IivanS
4月30日 创建了 pull request,commit b7e77f00
IivanS
4月30日 关联了issue:[Bug-Report|缺陷反馈]: MultiLatentAttention decode 路径静默丢弃 MASK_TYPE_SWA_NORM 与 windowSize,导致滑动窗口注意力不生效
CANN-robotCANN-robot成员
4月30日 添加了label:stat/needs-squash
CANN-robot
CANN-robot成员
4月30日 评论:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here
You can get sig-info at here


PR Approval Progress

Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
repo-cann/ascend-transformer-boost goodpeople233, 尹祺然 (2/2) 尹祺然 (1/1)
src 尹祺然, goodpeople233 (2/2) 尹祺然 (1/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)

CLA Signature Pass

ivanshan05075, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
CANN-robotCANN-robot成员
4月30日 添加了label:cann-cla/yes
此处折叠了73条消息 查看更多
goodpeople233成员
5月7日 评论:

/lgtm

likedislike
CANN-robotCANN-robot成员
5月7日 添加了label:lgtm
CANN-robot
CANN-robot成员
5月7日 评论:

Review Guide

This pull-request passes review.
Committers who wrote a comment of /approve are: 尹祺然.
Reviewers who wrote a comment of /lgtm are: 尹祺然, goodpeople233.

likedislike
CANN-robotCANN-robot成员
5月7日 关闭了关联的issue
CANN-robotCANN-robot成员
5月7日 合入了pull request