已开启
[L1] fix: sample README 的性能对比图指向不存在的 media/ 目录(图片显示不出),应为本仓的 figures/ #135
[L1] fix: sample README 的性能对比图指向不存在的 media/ 目录(图片显示不出),应为本仓的 figures/ #135
已开启
eieiei创建于 4 天前
eieiei
eieiei
4 天前

问题

samples/quant_block_sparse_attn/README.md:147 的性能对比图用的是一个本仓不存在的目录:

![QuantBlockSparseAttn vs AscendC 性能对比](../../media/quant_block_sparse_attn.png)

该 README 在 samples/quant_block_sparse_attn/ 下,../../ 正好回到仓库根,
但根下没有 media/ 目录(GET /repos/cann/cannbot-dsl/contents/media?ref=master → 404),
图片全仓也只有一份,在 figures/ 里:

GET /repos/cann/cannbot-dsl/contents/media                               -> 404 NOT_FOUND
GET /repos/cann/cannbot-dsl/contents/figures/quant_block_sparse_attn.png -> 200 type=file
$ git ls-files | grep -c '^media/'      -> 0          (全仓没有任何 media/ 下的文件)
$ grep -rn ']((\.\./)*/media/' --include=*.md . | wc -l   -> 1(就这一处)

于是这个 sample 主页最关键的一张"vs AscendC 性能对比"图在仓库页面与文档站上都是空的。

修改

把目录名改成本仓实际存放图片的 figures/(本仓其它 README 用的就是 figures/):

-![QuantBlockSparseAttn vs AscendC 性能对比](../../media/quant_block_sparse_attn.png)
+![QuantBlockSparseAttn vs AscendC 性能对比](../../figures/quant_block_sparse_attn.png)

复验

  1. 脚本硬断言:旧写法命中 1 次;figures/quant_block_sparse_attn.png 本地存在 + contents API type=file;
    media 目录 contents API 404、仓内无任何 media/ 文件;
  2. ../../ 从 samples/quant_block_sparse_attn/ 回到仓库根,因此 ../../figures/… 就是上面确认存在的这条路径;
  3. 只改 1 行里的目录名,图片说明文字与其余内容不动;
  4. 另外说明:本仓 docs/ 下若干文档用 /figures/x.png 这种站点根绝对路径(配合 docs/public/figures),
    那是文档站的既有约定、不是缺陷,本 PR 没有动它们;只有这一处 media/ 是纯笔误。
likedislike
合并受阻
eieieieieiei
4 天前 创建了 pull request,commit 6adf84d2
CANN-robot
CANN-robot成员
4 天前 评论:

Hi @wsnidie1, welcome to submitting your first PR to cannbot-dsl!

PR Merge Steps

1. CLA Signing

If the current PR label includes cann-cla/yes, it means you have signed the CLA and can proceed to the next step. If the label includes cann-cla/no, please sign the CLA first. If you have any questions, please refer to the FAQ.

2. CI Check

Please comment /compile to trigger the CI pipeline check. If the CI run is successful, the PR will be tagged with ci-pipeline-passed and you can proceed to the next step. If the CI run fails, the PR will be tagged with ci-pipeline-failed, please check the CI logs to fix the issues in the PR. If you have any questions, please refer to the FAQ.

3. Code Review

After CI passes, please refer to the PR Approval Progress and proactively @ the committers in the table to review the code. After approval, committers will comment /lgtm and /approve. Once the lgtm and approved labels are successfully added, the PR will be merged automatically.

likedislike
CANN-robotCANN-robot成员
4 天前 添加了label:cann-cla/yes
CANN-robot
CANN-robot成员
4 天前 评论:

CLA Signature Pass

wsnidie1, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
CANN-robot
CANN-robot成员
4 天前 评论:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.


PR Approval Progress

⚠️ This PR does not yet meet the following requirements:lgtm (requires ≥ 2 person(s) per module)、approve (requires ≥ 1 person(s) per module)

Module Approval Details

module lgtm status approve status
repo-cann/cannbot-dsl ❌ (0/2)(You can also ask: liujun2025, yang-jiwei, 陈振宇, 陆玲辉, 金炯) ❌ (0/1)(You can also ask: 陈振宇, 刘佳玮, 陆玲辉, 金炯, 沈敏)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)
likedislike
eieiei
eieiei
4 天前 评论:

/compile

likedislike
eieieieieiei
4 天前 预合并成功(commit_id: 414d9013d2b595b61c463e6fdedc8bf363f12321)
CANN-robot
CANN-robot成员
4 天前 评论:
🚀 CI 流水线已启动
📋 执行详情: 点击查看流水线
likedislike
CANN-robotCANN-robot成员
4 天前 添加了label:ci-pipeline-running
CANN-robotCANN-robot成员
4 天前 删除了label:ci-pipeline-running
CANN-robotCANN-robot成员
4 天前 添加了label:ci-pipeline-failed
eieiei
eieiei
4 天前 评论:

流水线标红但没有定界报告。本 PR 只改 samples README 里 1 行图片路径(media/ → figures/,本仓无 media 目录),不会影响编译/用例结果;先 /retest,若仍红请给出具体 job 名与失败检查项,我按那个 job 定界。

likedislike
eieiei
eieiei
4 天前 评论:

/retest

likedislike
eieiei
eieiei
19 小时前 评论:

/compile

likedislike
eieieieieiei
19 小时前 预合并成功(commit_id: 0a39a74b77f7f3a820168b3568ba0d3ca48f1ea0)
CANN-robot
CANN-robot成员
19 小时前 评论:
🚀 CI 流水线已启动
📋 执行详情: 点击查看流水线
likedislike
CANN-robotCANN-robot成员
19 小时前 删除了label:ci-pipeline-failed
CANN-robotCANN-robot成员
19 小时前 添加了label:ci-pipeline-running
CANN-robotCANN-robot成员
18 小时前 删除了label:ci-pipeline-running
CANN-robotCANN-robot成员
18 小时前 添加了label:ci-pipeline-failed