Merged
feat(governance): 注册 catlass technology 作为 CATLASS route 的规则基础 #122
johan_leeAdd on 22 days ago
feat(governance): 注册 catlass technology 作为 CATLASS route 的规则基础 #122
Merged
johan_leeAdd on 22 days ago
Merged fromDeleted :catlass-route-registerintocann/cannbot-knowledgemaster
johan_lee
22 days ago

Pull Request 说明

变更说明

  • 关联 Issue:无
  • 主要改动:为接收 CATLASS 算子知识 route,先落规则:governance/schemas/registries.yaml 的 technologies 新增 catlass(type: ascendc、domains: [ops]);governance/specs/paths.md 的 ops route 表补 catlass;evals/test_governance.py 的预建 route 期望集合补 knowledge/ops/catlass。
  • 补充说明(为什么拆成两个 PR):本仓 FormatCheck 的可信快照是「基线分支树 + 仅本 PR 的 knowledge/」。规则改动不进快照,同一 PR 既改规则又加内容时,内容必然被判 unregistered technology or scope(已关闭的 PR #121 的 50 条 P0 即此原因)。故拆为「规则 PR + 内容 PR」。
  • 为什么不顺带最小 knowledge/ops/catlass/index.md:实测不可行。按同一快照口径模拟(基线树 + 仅该 index.md 与父级导航),knowledge_lint.py --strict-navigation 得到 6 条 P0:unregistered technology or scope: catlass、link.missing: apis/index.md 与 guides/index.md、index.empty、index.non_direct ×2。原因是规则文件同样不在快照内,catlass 在快照里仍是未注册 route,等于把 #121 的失败搬回本 PR。因此只能规则先行、内容紧随合入。
  • 影响与风险:规则合入后 knowledge/ops/catlass 成为预建/必需目录。在内容 PR 合入前,该基线分支上其他 PR 的格式校验快照会报 structure.missing: knowledge/ops/catlass,本分支自身跑 check.sh 亦同;两个变更建议紧邻合入。

变更类型

验证

CI 等价证据(用仓库自带 linter 复现 FormatCheck 的快照口径):

  • 本 PR 自身 CI 快照(基线树 + 基线 knowledge,规则不参与):P0=0,故本 PR 的 FormatCheck 通过。
  • 本 PR head 单独跑 check.sh(规则已生效、内容未合):checked=8738 P0=1(structure.missing: knowledge/ops/catlass),即上述预期红窗。
  • 「基线 + 仅 index.md」模拟:checked=8739 P0=6,即不建议在本 PR 携带 index 的实测依据。
  • 规则 + 内容合并后的快照:待内容 PR rebase 到合入后的基线重测(旧基数 7910 已随基线前移失效,届时更新)。
likedislike
Pull Request has been successfully merged by CANN-robot.
(Thank you for johan_lee's contribution.)
Jjohan_lee
22 days ago Created pull request, commit 8d4dc162
CANN-robotCANN-robotCollaborators
22 days ago Added label: cann-cla/no
CANN-robot
CANN-robotCollaborators
22 days ago Comments:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.


PR Approval Progress

✅ Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
repo-cann/cannbot-knowledge ✅ qq_41667743, 金炯 (2/2) ✅ 金炯 (1/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)

CLA Signature Pass

johan_lee, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
johan_lee
22 days ago Comments:

compile

likedislike
Jjohan_lee
22 days ago Pre merge succeeded (commit_id: 94cf53cf7f3227ee5dc36baaa5319b7f8f80ce28)
47 messages are collapsed here。 See more
CANN-robot
CANN-robotCollaborators
18 days ago Comments:

The following users do not have permission to comment /lgtm or /approve on any module in this PR:
/lgtm: 冯彤

likedislike
CANN-robotCANN-robotCollaborators
18 days ago Added label: lgtmapproved
CANN-robot
CANN-robotCollaborators
18 days ago Comments:

The MR can not be merged, because of CodeReview discussion not resolved

If you want to solve this problem, you can click here to do it in the FAQs.

likedislike
yangziqi007yangziqi007
18 days ago Resolved final issue
CANN-robotCANN-robotCollaborators
18 days ago Merged pull request