已合并
feat(orchestrator): verify失败原因回灌到executor重试提示词 #29
shenmin创建于 8 天前
feat(orchestrator): verify失败原因回灌到executor重试提示词 #29
已合并
shenmin创建于 8 天前
shenmin成员
8 天前

变更内容

  • executor 重试(execute 阶段)时读取任务最近一次 fail 裁决的 reason,以 Previous-Verification-Failure: 注入提示词
  • 新增 read_verdict_failure_reason:仅接受 verdict=fail 且 reason 非空;裁决文件缺失/损坏时静默返回 None
  • verify 阶段提示词不受影响

测试

  • 新增 3 个单测:fail 原因注入 execute 提示词、verify 提示词不注入、缺失/pass/非法 JSON 场景返回 None

关联 issue

close #11

likedislike
Pull Request已成功合入, 合并人@CANN-robot
(感谢 shenmin 的贡献)
Sshenmin成员
8 天前 创建了 pull request,commit 2b5180ae
CANN-robot
CANN-robot成员
8 天前 评论:

Hi @OpSphere, welcome to submitting your first PR to cannbot!

PR Merge Steps

1. CLA Signing

If the current PR label includes cann-cla/yes, it means you have signed the CLA and can proceed to the next step. If the label includes cann-cla/no, please sign the CLA first. If you have any questions, please refer to the FAQ.

2. CI Check

Please comment /compile to trigger the CI pipeline check. If the CI run is successful, the PR will be tagged with ci-pipeline-passed and you can proceed to the next step. If the CI run fails, the PR will be tagged with ci-pipeline-failed, please check the CI logs to fix the issues in the PR. If you have any questions, please refer to the FAQ.

3. Code Review

After CI passes, please refer to the PR Approval Progress and proactively @ the committers in the table to review the code. After approval, committers will comment /lgtm and /approve. Once the lgtm and approved labels are successfully added, the PR will be merged automatically.

likedislike
CANN-robot
CANN-robot成员
8 天前 评论:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.


PR Approval Progress

✅ Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
repo-cann/cannbot ✅ xutianze, 宋恺 (2/2) ✅ xutianze (1/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)

CLA Signature Pass

OpSphere, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
CANN-robotCANN-robot成员
8 天前 添加了label:cann-cla/yes
Sshenmin成员
8 天前 virtual merging failed, update merge request[project_id: 10708627, iid: 29, target_commit_sha: b6fbc3e24a814a32c5a49fef3208c48c3170a3ad], message: You are not allowed to merge to this ref
Sshenmin成员
8 天前 virtual merging failed, update merge request[project_id: 10708627, iid: 29, target_commit_sha: b6fbc3e24a814a32c5a49fef3208c48c3170a3ad], message: You are not allowed to merge to this ref
CANN-robot
CANN-robot成员
8 天前 评论:
🚀 CI 流水线已启动
📋 执行详情: 点击查看流水线
likedislike
CANN-robotCANN-robot成员
8 天前 添加了label:ci-pipeline-running
CANN-robotCANN-robot成员
8 天前 删除了label:ci-pipeline-running
CANN-robotCANN-robot成员
8 天前 添加了label:ci-pipeline-passed
Sshenmin成员
8 天前 修改了pull request 的描述
xutianze
xutianze成员
8 天前 评论:

/approve

likedislike
CANN-robotCANN-robot成员
8 天前 添加了label:approved
songkai111成员
8 天前 评论:

/lgtm

likedislike
CANN-robotCANN-robot成员
8 天前 添加了label:lgtm
CANN-robotCANN-robot成员
8 天前 关闭了关联的issue
CANN-robotCANN-robot成员
8 天前 合入了pull request