已关闭
[Log规范] runtime目录下日志不规范问题整改 #566
wangyuchen创建于 12 天前关闭于 9 天前
12 天前 添加了label:bug
12 天前 将 lihecen 设为负责人
11 天前 关联了pull request:[PR]: 整改 runtime 目录日志不规范问题
10 天前 修改了issue 的描述
10 天前 关联了pull request:[PR]: 整改日志不规范问题(Issue #566 第5类 其他日志问题)
10 天前 关联了pull request:fix: 整改 api/compiler/runtime 目录日志不规范问题 for #566
9 天前 issue状态由 进行中 改变为 已完成
9 天前 关闭了 issue
6 天前 关联了pull request:fix: cherry-pick 拼写修正与日志规范整改到9.2.0分支 (#4987 #5025)


背景
根据日志规范扫描结果(
output/ge-gmd-runtime_findings.jsonl),runtime 目录下共发现 21处 日志不规范问题,涉及拼写错误、语法错误、日志级别错配、缺少度量单位四类。问题清单
1. 拼写错误(8处,严重)
Dose not support→Does not supportruntime/om2/formats/format_transfers/om2_format_transfer_c1hwncoc0_hwcn.ccruntime/om2/formats/format_transfers/om2_format_transfer_fracz_hwcn.ccruntime/om2/formats/format_transfers/om2_format_transfer_fracz_nchw.ccruntime/om2/formats/format_transfers/om2_format_transfer_fracz_nhwc.ccruntime/om2/formats/format_transfers/om2_format_transfer_hwcn_c1hwncoc0.ccruntime/om2/formats/format_transfers/om2_format_transfer_nc1hwc0_nchw.ccruntime/om2/formats/format_transfers/om2_format_transfer_nc1hwc0_nhwc.ccruntime/om2/formats/format_transfers/om2_format_transfer_nhwc_nc1hwc0.cc2. 语法错误(5处,中等)
runtime/v2/engine/aicore/converter/aicore_node_converter.ccNot find AI core task defFailed to find AI core task defruntime/v2/engine/aicore/converter/aicore_node_converter.ccNot find AI core taskdef.Failed to find AI core taskdef.runtime/v2/engine/gelocal/if_case_converter.ccFailed to loweringFailed to lowerruntime/v2/kernel/common_kernel_impl/build_tensor.ccnot support dtypeis not supportedruntime/v2/kernel/common_kernel_impl/infer_shape_range.ccdim num not matchdoes not match3. 日志级别错配(4处,中等)
错误/失败场景错误使用了 INFO 级别日志,应改用 WARN 或 ERROR 级别。
runtime/custom_op/python_custom_op_bridge_loader.ccruntime/custom_op/python_custom_op_bridge_loader.ccruntime/om2/om2_model_executor.ccruntime/v1/hybrid/executor/runtime_v2/rt_v2_pipeline_executor.cc4. 缺少度量单位(2处,中等)
runtime/v1/graph/load/model_manager/model_manager.cc5. 其他日志问题
GELOGD("Infer node:%s. Parent node uninfered", (*it)->GetName().c_str());it = inferred_nodes.erase(it);
uninfered应为uninferred,影响阅读与检索uninfered修正为uninferred后复测bool BinaryPartitioner::CheckNodesContainsCycle(const std::vector<NodePtr> &infered_nodes,const std::vector<NodePtr> &uninfer_nodes) {
uninfered/infered应为uninferred/inferred,影响阅读与检索uninfered/infered修正为uninferred/inferred后复测GELOGI("Partition completed! remaining nodes is empty. graph name:%s", graph->GetName().c_str());"Partition completed! remaining nodes is empty. graph name:%s"GELOGE(ACL_ERROR_GE_DATATYPE_INVALID, "[Trans][Param]Failed, the data type %s is not support","[Trans][Param]Failed, the data type %s is not support"GELOGE(FAILED,PLIST conflicts with与OPTION_EXEC_HCOM_GRO直接相连GELOGI(ersize, or this node与different core num s直接相连GELOGI("Try re-lowering for node %s, type %s after realize inputs as kernel box is oversize, or this node"
"different core num scope with after nodes.",
node->GetName().c_str(), node->GetType().c_str());
...ersize, or this node与different core num s...直接相连,运行时输出为or this nodedifferent coGELOGE(ACL_ERROR_GE_DATATYPE_INVALID, "[Trans][Param]Failed, the data type %s is not support","[Trans][Param]Failed, the data type %s is not support"printf("[Warning]: tiling struct [%s] is conflict with one in file %s, line %u\n", name, item.first, item.second);is conflict with动词形式错误,应为conflicts with修改要求