已开启
fix_rs #2774
hanyan创建于 2 天前
fix_rs #2774
已开启
hanyan创建于 2 天前
hanyan
hanyan成员
2 天前

描述

关联的Issue

测试

文档更新

类型标签

likedislike
合并受阻
hanyanhanyan成员
2 天前 创建了 pull request,commit 5b1d64a7
atomgit-bot
atomgit-bot
2 天前 评论:

变更摘要

该 PR(fix_rs)主要针对 reduce_scatter 的 CCU 模板路径进行修复性调整,涉及两个文件:在 CcuTempReduceScatterNHR1DMem2Mem::KernelRun 中新增调试日志输出 argSize 参数,并在 DoRepeatReduceScatterNHR 中移除事件记录/等待的同步逻辑(ccu::EventRecordccu::EventWait),同时以调试日志取代原有事件操作。

主要改动

  • 新增 argSize 调试日志: 在 ccu_temp_reduce_scatter_nhr_1D_mem2mem.ccCcuTempReduceScatterNHR1DMem2Mem::KernelRun 中新增 HCCL_INFO("YYYargSize=%llu", argSize),用于输出内核启动时的 argSize 参数值。
  • 移除事件记录调用: 在 ccu_kernel_reduce_scatter_nhr1d_mem2mem.ccDoRepeatReduceScatterNHR 中删除 isInputOutputEqual != 0 分支及 localSliceSize == 0 分支内的 ccu::EventRecord(ctx.event, 1) 调用。
  • 移除事件等待并新增日志: 删除 ccu::EventWait(ctx.event, 1) 事件同步等待,并在该位置新增调试日志 HCCL_INFO("YYYYYY"),同时保留 ctx.isRepeatIter = 1 的赋值逻辑。
likedislike
atomgit-bot
atomgit-bot
2 天前 评论:

代码审查

✅ 未发现问题

likedislike
CANN-robotCANN-robot成员
2 天前 添加了label:cann-cla/yes
CANN-robot
CANN-robot成员
2 天前 评论:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.


PR Approval Progress

⚠️ This PR does not yet meet the following requirements:lgtm (requires ≥ 2 person(s) per module)、approve (requires ≥ 1 person(s) per module)

Module Approval Details

module lgtm status approve status
src ❌ (0/2)(You can also ask: 颜业峰, 李标智, 杨小渊, 施秉辰, 胡林康) ❌ (0/1)(You can also ask: 李标智, 颜业峰, 文学敏)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)
likedislike
CANN-robot
CANN-robot成员
2 天前 评论:

CLA Signature Pass

hanyan233, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
CANN-robotCANN-robot成员
2 天前 将leabclove,yanglianxiang2,linyf950,yanzhenghang,chenliang267,yanyefeng,chenhao_,dingweiqin_57,songmingyang,wenxuemin,yangxiaoyuan,laodazhao1,yangshaohua,chenke2026,zhongqin2020,bz_lee,Innoecho,chenyia,temper7620,zhangxp1030,lilin_137,hulk1997,ouyangxizi,one_random设为评审人
CANN-robotCANN-robot成员
2 天前 将yanyefeng,wenxuemin,bz_lee设为审查人
hanyanhanyan成员
2 天前 update merge request[project id: 8277906, iid: 2774, commit_id: 1fcee2e9e1dee6bfd59b4445c4c58e55832b0281] virtual merging success
hanyanhanyan成员
2 天前 推送  1 个提交:c27c2407-delete_YYY
hanyanhanyan成员
2 天前 update merge request[project id: 8277906, iid: 2774, commit_id: c547f0b0e487b857b16b19ff52041fcccc2bb16c] virtual merging success
hanyan
hanyan成员
2 天前 评论:

/compile

likedislike
hanyanhanyan成员
2 天前 update merge request[project id: 8277906, iid: 2774, commit_id: 13663c19086832cfc298ba8db5efcedab555af2d] virtual merging success
CANN-robotCANN-robot成员
2 天前 删除了label:cann-cla/yes
CANN-robotCANN-robot成员
2 天前 添加了label:stat/needs-squash
CANN-robotCANN-robot成员
2 天前 添加了label:cann-cla/yes
CANN-robotCANN-robot成员
2 天前 添加了label:ci-pipeline-running
CANN-robot
CANN-robot成员
2 天前 评论:

流水线任务触发成功
任务链接 [05a6b238c1774a29b7a65076e38b43e8][流水线指导]

任务名称状态日志下载链接
SCA ✅ SUCCESS >>>>>
antipoison ✅ SUCCESS >>>>>
Check_Pr ✅ SUCCESS >>>>>
pre_comment ✅ SUCCESS >>>>>
Compile_Ascend_X86 ✅ SUCCESS >>>>> >>>>>
Compile_Ascend_ARM ✅ SUCCESS >>>>> >>>>>
Compile_Ascend_X86_ubuntu24 ✅ SUCCESS >>>>> >>>>>
Compile_Ascend_ARM_ubuntu24 ✅ SUCCESS >>>>> >>>>>
StaticCheck_codespell ✅ SUCCESS
StaticCheck_link_validity ✅ SUCCESS
StaticCheck_resource_existence ✅ SUCCESS
StaticCheck_tag_closed ✅ SUCCESS
StaticCheck_markdownlint ✅ SUCCESS
Compile_Ascend_X86_monitor ✅ SUCCESS >>>>>
Compile_Ascend_ARM_monitor ✅ SUCCESS >>>>>
UT_Test ✅ SUCCESS >>>>>
API_Check ✅ SUCCESS >>>>>
ST_Test ✅ SUCCESS >>>>>
codecheck ✅ SUCCESS >>>>>
precommit ✅ SUCCESS >>>>>
codecheck_codestyle ✅ SUCCESS >>>>>
PreSmoke_A900_npupool ✅ SUCCESS >>>>>
PreSmoke_A3_npupool ✅ SUCCESS >>>>>

[2026-08-26 21:24:19]    CI执行结束

likedislike
CANN-robotCANN-robot成员
2 天前 添加了label:api-check-pass
CANN-robotCANN-robot成员
2 天前 删除了label:ci-pipeline-running
CANN-robotCANN-robot成员
2 天前 添加了label:ci-pipeline-passed
CANN-robot
CANN-robot成员
2 天前 评论:
流水线 PR-pipeline_cann_hccl#6886 [ commitID:c27c2407 ] 已完成
likedislike