已合并
Fix string padding in Conv3d wrappers #32
Fix string padding in Conv3d wrappers #32
已合并
KaranocaVe创建于 28 天前
KaranocaVe
KaranocaVe
28 天前

Fix string padding in Conv3d wrappers

conv3d_custom.functional.conv3d and the custom Conv3d path reject the valid PyTorch padding values "valid" and "same" before convolution. Convert these options to zero padding or equivalent explicit padding before entering the custom autograd function. The same path preserves PyTorch's asymmetric padding for even kernels, and non-zero padding_mode uses the same padding calculation.

Added regression coverage for both string values, zero and reflect padding modes, forward output, and input/weight/bias gradients. Float64 CPU results match native Conv3d within 7.11e-15; small Ascend 910B checks match within 4.77e-6.

关联 Issue: https://gitcode.com/cann/oil-gas-ops-prospect/issues/5

likedislike
Pull Request已成功合入, 合并人@CANN-robot
(感谢 KaranocaVe 的贡献)
KaranocaVeKaranocaVe
28 天前 创建了 pull request,commit 1d585d3d
KaranocaVeKaranocaVe
28 天前 关联了issue:Conv3d 字符串 padding 在自定义路径报错
CANN-robot
CANN-robot成员
28 天前 评论:

Hi @KaranocaVe, welcome to submitting your first PR to oil-gas-ops-prospect!

PR Merge Steps

1. CLA Signing

If the current PR label includes cann-cla/yes, it means you have signed the CLA and can proceed to the next step. If the label includes cann-cla/no, please sign the CLA first. If you have any questions, please refer to the FAQ.

2. CI Check

Please comment /compile to trigger the CI pipeline check. If the CI run is successful, the PR will be tagged with ci-pipeline-passed and you can proceed to the next step. If the CI run fails, the PR will be tagged with ci-pipeline-failed, please check the CI logs to fix the issues in the PR. If you have any questions, please refer to the FAQ.

3. Code Review

After CI passes, please refer to the PR Approval Progress and proactively @ the committers in the table to review the code. After approval, committers will comment /lgtm and /approve. Once the lgtm and approved labels are successfully added, the PR will be merged automatically.

likedislike
CANN-robotCANN-robot成员
28 天前 添加了label:cann-cla/yes
CANN-robot
CANN-robot成员
28 天前 评论:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.


PR Approval Progress

✅ Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
sig-oil-gas-engineering ✅ 胡艺馨, 徐澜 (2/2) ✅ 胡艺馨 (1/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)

CLA Signature Pass

KaranocaVe, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
KaranocaVe
KaranocaVe
28 天前 评论:

/compile

likedislike
KaranocaVeKaranocaVe
28 天前 预合并成功(commit_id: 16a0a46ba9c8b6239216df84d5f67acd59017326)
CANN-robot
CANN-robot成员
28 天前 评论:
🚀 CI 流水线已启动
📋 执行详情: 点击查看流水线
likedislike
CANN-robotCANN-robot成员
28 天前 添加了label:ci-pipeline-running
CANN-robotCANN-robot成员
28 天前 删除了label:ci-pipeline-running
CANN-robotCANN-robot成员
28 天前 添加了label:ci-pipeline-passed
newbgirl
newbgirl成员
25 天前 评论:

/lgtm
/approve

likedislike
CANN-robotCANN-robot成员
25 天前 添加了label:approved
Chris-Lan成员
25 天前 评论:

/lgtm

likedislike
CANN-robotCANN-robot成员
25 天前 添加了label:lgtm
CANN-robotCANN-robot成员
25 天前 合入了pull request