已合并
[Bug] Filter pybind extensions in operator subset wheel builds #35
[Bug] Filter pybind extensions in operator subset wheel builds #35
已合并
KaranocaVe创建于 24 天前
KaranocaVe
KaranocaVe
24 天前

[Bug] Filter pybind extensions in operator subset wheel builds

build.sh --ops filters the generated OPP, but the wheel build currently bundles every discovered AscendC pybind extension. A subset wheel can therefore include an extension that references ACLNN symbols omitted from its OPP. For example, --ops=complex_mul produced a wheel whose fused_bias_softmax_npu failed to load with undefined symbol: aclnnFusedSoftmaxGrad.

The wheel build now receives the selected operator list and includes an extension family only when all of its declared operator dependencies are selected. Builds without an operator filter still include all extensions.

Validation: on CANN 9.2.0-beta.2 with Python 3.11, a single-op OPP/wheel no longer bundles the fused extension, and a complete ComplexMul/ComplexMulGrad build retains an importable complex_mul_npu. No NPU kernel was run.

关联 Issue: https://gitcode.com/cann/oil-gas-ops-prospect/issues/9

likedislike
Pull Request已成功合入, 合并人@CANN-robot
(感谢 KaranocaVe 的贡献)
KaranocaVeKaranocaVe
24 天前 创建了 pull request,commit 663acf90
KaranocaVeKaranocaVe
24 天前 关联了issue:[构建缺陷] `--ops` 子集构建仍将不匹配的 pybind 扩展打入 wheel
CANN-robotCANN-robot成员
24 天前 添加了label:cann-cla/yes
CANN-robot
CANN-robot成员
24 天前 评论:

CLA Signature Pass

KaranocaVe, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
CANN-robot
CANN-robot成员
24 天前 评论:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.


PR Approval Progress

✅ Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
sig-oil-gas-engineering ✅ 徐澜, 马成贵, 胡艺馨 (3/2) ✅ 徐澜 (1/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)
likedislike
KaranocaVe
KaranocaVe
24 天前 评论:

/compile

likedislike
KaranocaVeKaranocaVe
24 天前 预合并成功(commit_id: 027b611881a6dba8ab463d28a156fdb39a759647)
CANN-robot
CANN-robot成员
24 天前 评论:
🚀 CI 流水线已启动
📋 执行详情: 点击查看流水线
likedislike
CANN-robotCANN-robot成员
24 天前 添加了label:ci-pipeline-running
CANN-robotCANN-robot成员
24 天前 删除了label:ci-pipeline-running
CANN-robotCANN-robot成员
24 天前 添加了label:ci-pipeline-passed
KaranocaVe
KaranocaVe
5 天前 评论:

@MetalMetal @gcw_luCgmemv @machenggui-coder @li_tianen @coffee2code @zlove9 @jygslym @newbgirl

麻烦各位抽空审核这个 PR;确认没有问题后,请按仓库规则补齐所需的 /lgtm 和 /approve。如果有需要修改的地方,请直接留言,我会跟进。谢谢!

likedislike
KaranocaVe
KaranocaVe
4 天前 评论:

@MetalMetal @gcw_luCgmemv @machenggui-coder @li_tianen @coffee2code @zlove9 @jygslym @newbgirl

昨天已请各位审核,这里再跟进一下:麻烦抽空看一下这个 PR。如有需要修改的地方,请直接留言;确认没有问题后,烦请按仓库规则补齐所需的 /lgtm 和 /approve,协助推进合入。谢谢!

likedislike
machenggui-coder成员
3 天前 评论:

/lgtm

likedislike
newbgirl
newbgirl成员
3 天前 评论:

/lgtm

likedislike
CANN-robotCANN-robot成员
3 天前 添加了label:lgtm
Chris-Lan成员
3 天前 评论:

/approve

likedislike
CANN-robotCANN-robot成员
3 天前 添加了label:approved
CANN-robotCANN-robot成员
3 天前 合入了pull request