Pull Request已成功合入, 合并人@CANN-robot
(感谢 justsheldon 的贡献)变更摘要
该 PR(#763)为纯日志层面的 Bug 修复,不涉及功能逻辑改动。主要内容是对 src/nnopbase 与 tests/nnopbase 下 17 个文件中残留日志的拼写错误(如 op cahce、emtpy、massage、avaiable、filed、determinisitcLevel 等)和语法错误(如 cant、does not contains、does not has、cann't、Dont 等)进行统一修正,并顺带丰富了 OpExecCacheManager::AddOpExecCache 中缓存已满的日志输出内容,使其包含缓存大小与上限信息。
主要改动
- 修复日志拼写错误: 在
include/nnopbase/opdev/op_cache.h(op cahce→op cache)、src/nnopbase/composite_op/aclnn_engine/op_kernel_lib.cpp(emtpy→empty)、src/nnopbase/composite_op/mem_mgr/huge_mem.cpp(avaiable→available)、src/nnopbase/composite_op/aclnn_engine/op_dfx.cpp(filed→failed)、src/nnopbase/common/utils/kernel_graph.cpp(thank→than)以及op_kernel.h(determinisitcLevel→deterministicLevel)等文件中修正拼写,确保日志可读性与可检索性。 - 纠正日志语法错误: 将
op_cache.cpp、op_executor.cpp、rts_arg.cpp中多处cant改为can't、cann't改为can't,将op_info_serialize.cpp、op_kernel.cpp、op_kernel.h中does not contains/has改为does not contain/have,并修正kernel_tensor.h的cant no set、op_executor.cpp的size if tensor relation must be pair of tensor、op_kernel_bin.cpp的Dont/Dont has等表达,使日志语句符合英文语法。 - 补充缓存满日志的上下文信息: 在
OpExecCacheManager::AddOpExecCache中,将"op cache is full"日志扩展为带参数输出的"op cache is full, cache size %zu, limit %zu"(cache2_分支同理),便于定位缓存容量问题。 - 同步修正测试文件的日志与断言文案:
tests/nnopbase/st/composite_op/test_error_manager.cpp与tests/nnopbase/ut/composite_op/test_error_manager.cpp中massage→message;tests/nnopbase/ut/composite_op/test_check_double_free.cpp中ASSERT_TRUE的失败提示由中文改为英文"precondition: huge page path entered"。


Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.
PR Approval Progress
✅ Congratulations! All modules have met the lgtm and approve requirements.
Module Approval Details
| module | lgtm status | approve status |
|---|---|---|
| include | ✅ 宋恺, 汤平川, 王永光 (3/2) | ✅ 王永光 (1/1) |
| repo-cann/opbase | ✅ 汤平川, 宋恺 (2/2) | ✅ 汤平川, 宋恺 (2/1) |
💡 Tip:
- Committer can comment
/approveor/lgtm- Commenting
/approveimplies both code review (lgtm) and intent to merge (approve)
CLA Signature Pass
justsheldon, thanks for your pull request. All authors of the commits have signed the CLA. 👍


compile


/lgtm
/approve


/compile


/approve


/lgtm


/approve


描述
1、修复残留日志拼写错误
2、纠正语法错误
关联的Issue
测试
日志修改,不涉及测试
文档更新
类型标签