Pull Request已成功合入, 合并人@CANN-robot
(感谢 justsheldon 的贡献)变更摘要
本 PR(#817)针对 opbase(nnopbase)模块的日志问题进行全面修复。根据 PR 描述与补丁内容,这是一次纯日志层面的修改(不涉及代码逻辑与测试):一方面修正了大量日志文案中的拼写、语法、时态与主谓一致等英文表达问题(如 fail. → failed.、is not exist → does not exist、has full → is full、do not need → does not need 等);另一方面修复了日志中错误引用变量、错误的任务名/参数名以及缺少单位、缺少实际上下文数值等问题,使日志信息更准确、可读且便于问题定位。
主要改动
-
修复日志中错误引用的变量:在
non_finite_check_op.h与op_dfx.cpp中,aclrtSynchronizeStream/aclrtMemcpy失败日志原先误打印ret,现改为打印实际返回值rc;在z_framework_op.cpp中,输出参数 placement 校验日志原先误打印src->GetPlacement(),现更正为dst->GetPlacement()。 -
修复日志中复制粘贴导致的函数名/任务名错误:
kernel_context_holder.h中UpdateOutputArg失败的日志原先误写为UpdateInputArg failed,现更正为UpdateOutputArg failed;dsa_task.h中DSAGenBitMaskTask的参数数量错误信息原先误写为DSARandomUniformTask,已更正,同时将memcpy first input arg更正为更准确的memcpy second input arg (std/max)。 -
在错误日志中补充实际数值以便定位:
dsa_task.h的输出/输入参数数量校验日志补充了实际的argList.count值;op_executor.cpp的CreateViewoffset 校验错误日志补充了offset与storageSize的取值及合法范围信息。 -
尺寸类日志统一补充单位:在
launch_arg_info.h、block_pool.h、non_finite_check_op.h、memory_allocator.cpp等文件中,涉及 tensor 大小、cache 大小、workspace 大小、offset 等数值的日志统一补充了单位B或bytes。 -
修正日志英文文案语法与表达:
include/nnopbase/opdev/op_executor.h、op_cache.cpp、op_feature.cpp、kernel_mgr.cpp、op_kernel.cpp、op_error_manager.cpp、platform.cpp、gen_stubapi.py等文件的日志文案在时态、主谓一致及措辞上做了规范化修正。


compile


Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.
PR Approval Progress
✅ Congratulations! All modules have met the lgtm and approve requirements.
Module Approval Details
| module | lgtm status | approve status |
|---|---|---|
| include | ✅ 王永光, 张磊, 汤平川, pengjiahao96 (4/2) | ✅ 王永光 (1/1) |
| repo-cann/opbase | ✅ 张磊, 汤平川, pengjiahao96 (3/2) | ✅ pengjiahao96, 张磊, 汤平川 (3/1) |
💡 Tip:
- Committer can comment
/approveor/lgtm- Commenting
/approveimplies both code review (lgtm) and intent to merge (approve)
CLA Signature Pass
justsheldon, thanks for your pull request. All authors of the commits have signed the CLA. 👍


| 🚀 CI 流水线已启动 |
|---|
| 📋 执行详情: 点击查看流水线 |


compile


| 🚀 CI 流水线已启动 |
|---|
| 📋 执行详情: 点击查看流水线 |


/lgtm
/approve


/lgtm
/approve


/approve


The following label is not ready.
ci-pipeline-passed: The label was added before the last update of the PR. Please re-add it after the latest update.


The following label is not ready.
ci-pipeline-passed: The label was added before the last update of the PR. Please re-add it after the latest update.


| 🚀 CI 流水线已启动 |
|---|
| 📋 执行详情: 点击查看流水线 |


描述
修复opbase的log问题
关联的Issue
测试
仅日志修改,不涉及代码测试
文档更新
类型标签