Closed
[Bug-Report|缺陷反馈]: aclnnSliceGetWorkspaceSize() 整数加法溢出 #3457
wuaoAdd on  Oct 9Closed at  Oct 12
wuao
wuaoCollaborators
Oct 9 Create

一、问题描述 (必填)

libopapi.so 中的 aclnnSliceGetWorkspaceSize() 函数在计算切片范围时对 step 参数进行加法运算。当 step=INT64_MAX 时,加法运算溢出,触发 libgcc_s.so.1 中的 __addvdi3。

二、环境信息 (可选)

A5

三、重现步骤 (可选)

调用链

aclnnSliceGetWorkspaceSize()        [libopapi.so]
  └─> step 算术运算(加法)
       └─> __addvdi3()              [libgcc_s.so.1]
            └─> abort()             [libc]  *** SIGABRT 进程崩溃 ***

GDB 调用栈

#5  __addvdi3 () from /lib/x86_64-linux-gnu/libgcc_s.so.1
#6  aclnnSliceGetWorkspaceSize () from libopapi.so
#7  main at poc_v11_nofork.c:39
     dims = {2, 3}, step = 9223372036854775807 (INT64_MAX)

POC

int64_t dims[] = {2, 3};
int64_t strides[] = {3, 1};
aclTensor* self = aclCreateTensor(dims, 2, ACL_FLOAT, strides, 0, ACL_FORMAT_ND, NULL, 0, NULL);
aclTensor* out = aclCreateTensor(dims, 2, ACL_FLOAT, strides, 0, ACL_FORMAT_ND, NULL, 0, NULL);
uint64_t ws = 0; aclOpExecutor* exec = NULL;
aclnnSliceGetWorkspaceSize(self, 0, 0, 2, 0x7FFFFFFFFFFFFFFFLL, out, &ws, &exec);  /* 触发 SIGABRT */
<!-- 提供尽可能多的信息描述如何重现该缺陷 -->

####  四、预期结果 (可选)
<!-- 描述预期的行为应该是什么样子的 -->


💡 备注(选填)

likedislike
wuaowuaoCollaborators
Oct 9 Added label: bug-report
wuao
wuaoCollaborators
Oct 9 Comments:

修复建议:

在计算 sliceNum 前对 step 做保护,或使用安全除法:

int64_t sliceNum;
if (step >= end - start) {
sliceNum = (end > start) ? 1 : 0;
} else {
sliceNum = (end - start + step - 1) / step;
}

或更简单地,提前 clamp step:

int64_t range = end - start;
int64_t sliceNum = (range <= 0) ? 0 : (range + step - 1) / step;
// 并在 step > range 时直接取 1,避免溢出

likedislike
wuaowuaoCollaborators
Oct 9 Associated pull request
陈思
陈思Collaborators
Oct 9 Comments:

/assign @wow5523

likedislike
CANN-robotCANN-robotCollaborators
Oct 9 Assign wow5523 as responsible person
CANN-robotCANN-robotCollaborators
Oct 12 Close issue
CANN-robotCANN-robotCollaborators
Oct 12 Added label: resolved