已合并
优化多个文件中的代码风格 #1295
yuantao创建于 2月24日
优化多个文件中的代码风格 #1295
已合并
yuantao创建于 2月24日
yuantao
yuantao
2月24日

描述

多个文件中的代码风格可以进行改进:

文件路径 代码片段 问题描述 行号
conversion/concat_d/op_api/concat_d.cpp if (tail_dim * type_size[promoteType] % 32 != 0) { 避免魔法数字 (32) 54
conversion/depth_to_space/examples/test_geir_depth_to_space.cpp add1.update_output_desc_##outputName(outputName##outputIndex##_desc); 宏定义无需分号 68
conversion/depth_to_space/examples/test_geir_depth_to_space.cpp inputs.push_back(placeholder##intputIndex); 宏定义无需分号 60
conversion/depth_to_space/examples/test_geir_depth_to_space.cpp char *endptr; 使用std::string替代char* 202
conversion/strided_slice_grad/examples/test_geir_strided_slice_grad.cpp pData[i] = value + (i % 3) * 0.4f; // 让数据更有意义 避免魔法数字 (3) 126
conversion/strided_slice_grad/examples/test_geir_strided_slice_grad.cpp return 2; 避免魔法数字 (2) 109
conversion/strided_slice_grad/examples/test_geir_strided_slice_grad.cpp return 4; 避免魔法数字 (4) 107
conversion/concat_d/op_api/concat_d.cpp if (inputs->Size() > 512 || inputs->Size() < 33) { 避免魔法数字 (512) 45
conversion/concat_d/op_api/concat_d.cpp catMaxInputSize = 512; 避免魔法数字 (512) 92
conversion/depth_to_space/examples/test_geir_depth_to_space.cpp FILE *fp; 变量应在使用时声明初始化 153
conversion/depth_to_space/examples/test_geir_depth_to_space.cpp add1.set_attr_##attrName(attrValue); 宏定义无需分号 63
random/dsa_random_uniform/op_host/op_api/aclnn_multinomial.cpp auto randomUniform = GetRandomUniformNoReplaceMent(selfContiguous, randomParams, uniqueExecutor.get()); 数组参数应传递长度 (randomParams) 377
conversion/squeezev2/op_host/squeezev2_infershape.cpp return SqueezeWithAxes(x_shape, squeeze_dims, y_shape); 数组参数应传递长度 (squeeze_dims) 114
conversion/concat_dv2/op_host/concat_dv2_tiling.cpp tiling.set_endTensorIdx(endTensorIdx); 数组参数应传递长度 (endTensorIdx) 143
conversion/squeezev3/op_host/squeezev3_infershape.cpp return SqueezeWithAxes(x_shape, squeeze_dims, y_shape); 数组参数应传递长度 (squeeze_dims) 117
conversion/concat_dv2/op_host/concat_dv2_tiling.cpp tiling.set_endTensorOffset(endTensorOffset); 数组参数应传递长度 (endTensorOffset) 144
conversion/squeezev2/op_host/squeezev2_infershape.cpp if (!IsAxesRangeValid(squeeze_dims, static_cast<int64_t>(x_shape->GetDimNum()), axes)) { 数组参数应传递长度 (squeeze_dims) 108
random/sim_thread_exponential/op_kernel/sim_thread_exponential.h AscendC::And(..., mask, len / SHIFT_LEFT_32, { 1, 1, 1, 8, 数组参数应传递长度 (mask) 567
random/dsa_gen_bit_mask/examples/test_dropout_gen_mask.cpp std::vector<float> outHostData(8, 0); 避免魔法数字 (8) 89
conversion/diag_v2/examples/test_geir_diag_v2.cpp char *endptr; 使用std::string替代char* 220
random/dsa_gen_bit_mask/examples/test_dropout_gen_mask.cpp std::vector<uint8_t> maskOutHostData(16, 0); 避免魔法数字 (16) 90
conversion/diag_v2/examples/test_geir_diag_v2.cpp FILE *fp; 变量应在使用时声明初始化 177
conversion/diag_v2/examples/test_geir_diag_v2.cpp add1.set_attr_##attrName(attrValue); 宏定义无需分号 63
conversion/diag_v2/examples/test_geir_diag_v2.cpp inputs.push_back(placeholder##intputIndex); 宏定义无需分号 60
conversion/diag_v2/examples/test_geir_diag_v2.cpp add1.update_output_desc_##outputName(outputName##outputIndex##_desc); 宏定义无需分号 92
conversion/unfold_grad/op_kernel/unfold_grad_final_axe_big_size.h (空行) 代码块末尾不应有空行 56
random/dsa_gen_bit_mask/examples/test_aclnn_dropout_gen_mask_v2_tensor.cpp std::vector<uint8_t> outHostData(16, 0); 避免魔法数字 (16) 93
random/dsa_gen_bit_mask/examples/test_dropout.cpp std::vector<uint8_t> maskOutHostData(16, 0); 避免魔法数字 (16) 90
random/dsa_gen_bit_mask/examples/test_dropout.cpp std::vector<float> outHostData(8, 0); 避免魔法数字 (8) 89
conversion/concat_dv2/op_host/concat_dv2_def.cpp 0 代码块末尾不应有空行 45
conversion/concat_d/op_api/aclnn_cat.cpp catMaxInputs = 512; 避免魔法数字 (512) 337
conversion/clip_by_value_v2/examples/test_aclnn_clamp_max.cpp std::vector<int8_t> outHostData(8, 0); 避免魔法数字 (8) 80
random/dsa_gen_bit_mask/examples/test_dropout_gen_mask_v2.cpp std::vector<uint8_t> outHostData(16, 0); 避免魔法数字 (16) 86
conversion/broadcast_to/examples/test_geir_broadcast_to.cpp inputs.push_back(placeholder##intputIndex); 宏定义无需分号 89
random/dsa_gen_bit_mask/examples/test_aclnn_bernoulli.cpp std::vector<float> outHostData(16, 0); 避免魔法数字 (16) 89
conversion/confusion_transpose_d/examples/test_aclnn_confusion_transpose.cpp std::vector<float> outHostData(8, 1); 避免魔法数字 (8) 116
conversion/clip_by_value_v2/examples/test_aclnn_clamp_max_tensor.cpp std::vector<double> outHostData(8, 0); 避免魔法数字 (8) 82

关联的Issue

测试

文档更新

类型标签

likedislike
Pull Request已成功合入, 合并人@CANN-robot
(感谢 yuantao 的贡献)
yuantaoyuantao
2月24日 创建了 pull request,commit b257f404
CANN-robot
CANN-robot成员
2月24日 评论:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here
You can get sig-info at here


PR Approval Progress

Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
*/*/op_host/*_def.cpp rxtfeng, zhou-qilong, wangyongguang (3/2) wangyongguang (1/1)
*/*/op_host/op_api/*.h rxtfeng, zhou-qilong, wangyongguang (3/2) wangyongguang (1/1)
conversion/as_strided zhou-qilong, rxtfeng, zhangyuxiang0119 (3/2) zhangyuxiang0119, zhou-qilong (2/1)
conversion/broadcast_to zhangyuxiang0119, zhou-qilong, rxtfeng (3/2) zhangyuxiang0119, zhou-qilong (2/1)
conversion/clip_by_value_v2 zhangyuxiang0119, zhou-qilong, rxtfeng (3/2) zhou-qilong, zhangyuxiang0119 (2/1)
conversion/flatten zhou-qilong, rxtfeng, zhangyuxiang0119 (3/2) zhangyuxiang0119, zhou-qilong (2/1)
conversion/im2col zhangyuxiang0119, zhou-qilong, rxtfeng (3/2) zhangyuxiang0119, zhou-qilong (2/1)
conversion/pack rxtfeng, zhangyuxiang0119, zhou-qilong (3/2) zhangyuxiang0119, zhou-qilong (2/1)
conversion/squeeze zhangyuxiang0119, zhou-qilong, rxtfeng (3/2) zhangyuxiang0119, zhou-qilong (2/1)
conversion/strided_slice_v3 zhangyuxiang0119, zhou-qilong, rxtfeng (3/2) zhangyuxiang0119, zhou-qilong (2/1)
conversion/unfold_grad zhangyuxiang0119, zhou-qilong, rxtfeng (3/2) zhangyuxiang0119, zhou-qilong (2/1)
repo-cann/ops-math zhou-qilong, rxtfeng (2/2) zhou-qilong (1/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)
likedislike
CANN-robotCANN-robot成员
2月24日 将FelixTang7,zhou-qilong,wangrui_,rxtfeng,loov1,songkai111,zhangyuxiang0119,llimwang,gubaocheng设为评审人
CANN-robotCANN-robot成员
2月24日 将FelixTang7,zhou-qilong,wangrui_,rxtfeng,loov1,songkai111,zhangyuxiang0119,llimwang,gubaocheng设为审查人
CANN-robotCANN-robot成员
2月24日 添加了label:cann-cla/yes
此处折叠了165条消息 查看更多
rxtfeng成员
2月28日 评论:

/lgtm

likedislike
CANN-robotCANN-robot成员
2月28日 添加了label:lgtm
CANN-robot
CANN-robot成员
2月28日 评论:

Review Guide

This pull-request passes review.
Committers who wrote a comment of /approve are: zhangyuxiang0119, zhou-qilong, wangyongguang.
Reviewers who wrote a comment of /lgtm are: zhangyuxiang0119, zhou-qilong, rxtfeng, wangyongguang.

likedislike
CANN-robotCANN-robot成员
2月28日 关闭了关联的issue
CANN-robotCANN-robot成员
2月28日 合入了pull request