clean code-ops-math-AtomGit

已合并

clean code #1496

clean code #1496

已合并

yuanbin_22创建于 3月5日

3月5日

描述

类的成员变量必须显式初始化

（感谢 yuanbin_22 的贡献）

3月5日创建了 pull request，commit fb58f925

3月5日关联了issue：[Bug-Report|缺陷反馈]: 修改 Vector one group算子 Code Check 告警

3月5日评论：

Thanks for your pull-request.
The full list of commands accepted by me can be found at here。
You can get sig-info at here

✅ Congratulations! All modules have met the lgtm and approve requirements.

module	lgtm status	approve status
math/abs	✅ zhou-qilong, su-yueming, songkai111 (3/2)	✅ songkai111 (1/1)
math/ceil	✅ zhou-qilong, songkai111, su-yueming (3/2)	✅ songkai111 (1/1)
math/cos	✅ songkai111, su-yueming, zhou-qilong (3/2)	✅ songkai111 (1/1)
math/exp	✅ songkai111, su-yueming, zhou-qilong (3/2)	✅ songkai111 (1/1)
math/floor	✅ zhou-qilong, songkai111 (2/2)	✅ songkai111 (1/1)
math/is_neg_inf	✅ songkai111, zhou-qilong, su-yueming (3/2)	✅ songkai111 (1/1)
math/is_pos_inf	✅ su-yueming, songkai111, zhou-qilong (3/2)	✅ songkai111 (1/1)
math/log	✅ songkai111, su-yueming, zhou-qilong (3/2)	✅ songkai111 (1/1)
math/neg	✅ su-yueming, zhou-qilong, songkai111 (3/2)	✅ songkai111 (1/1)
math/reciprocal	✅ zhou-qilong, songkai111, su-yueming (3/2)	✅ songkai111 (1/1)
math/round	✅ su-yueming, songkai111, zhou-qilong (3/2)	✅ songkai111 (1/1)
math/rsqrt	✅ songkai111, su-yueming, zhou-qilong (3/2)	✅ songkai111 (1/1)
math/sin	✅ su-yueming, zhou-qilong, songkai111 (3/2)	✅ songkai111 (1/1)
math/sqrt	✅ songkai111, zhou-qilong, su-yueming (3/2)	✅ songkai111 (1/1)
math/square	✅ songkai111, zhou-qilong (2/2)	✅ songkai111 (1/1)
math/tanh	✅ songkai111, su-yueming, zhou-qilong (3/2)	✅ songkai111 (1/1)
math/trunc	✅ songkai111, zhou-qilong (2/2)	✅ songkai111 (1/1)
repo-cann/ops-math	✅ songkai111, zhou-qilong (2/2)	✅ songkai111 (1/1)

💡 Tip:

Committer can comment /approve or /lgtm

Commenting /approve implies both code review (lgtm) and intent to merge (approve)

3月5日将FelixTang7,zhou-qilong,wangrui_,su-yueming,rxtfeng,loov1,songkai111,zhangyuxiang0119,llimwang,gubaocheng设为评审人

3月5日将FelixTang7,zhou-qilong,wangrui_,su-yueming,rxtfeng,loov1,songkai111,zhangyuxiang0119,llimwang,gubaocheng设为审查人

此处折叠了68条消息查看更多

3月7日修改标题为 “clean code”，原标题为“clean code、0”

3月7日修改了pull request 的描述

3月7日解决了最后一个问题

3月7日评论：

This pull-request passes review.
Committers who wrote a comment of /approve are: songkai111.
Reviewers who wrote a comment of /lgtm are: songkai111, su-yueming, zhou-qilong.

3月7日合入了pull request