已合并
算子中存在使用内部的asc api接口,需要切换为对外的api接口 #4954
hw-zhangpanpan创建于 16 天前
算子中存在使用内部的asc api接口,需要切换为对外的api接口 #4954
已合并
hw-zhangpanpan创建于 16 天前
16 天前

描述

算子中存在使用内部的asc api接口,需要切换为对外的api接口

关联的Issue

https://gitcode.com/cann/ops-math/issues/2958

测试

切换接口前后二进制文件一致

文档更新

不涉及

类型标签

likedislike
Pull Request已成功合入, 合并人@CANN-robot
(感谢 hw-zhangpanpan 的贡献)
Hhw-zhangpanpan
16 天前 创建了 pull request,commit 2766c5c6
atomgit-bot
atomgit-bot
16 天前 评论:

变更摘要

该 PR(标题"asc接口替换")是一次面向 arch35 内核的接口替换/重命名改动,不涉及业务逻辑变更:将算子内核中旧的 AscendC::Reg 寄存器指令接口、NDMA 搬运参数类型以及 UB 指针限定符统一迁移到新命名规范。改动覆盖 conversionmath 目录下的多个算子(as_stridedconcatdynamic_partitionsplit_vstrided_slice_gradtriucumsumeyepower),全部位于 arch35 内核文件中。

主要改动

  • 寄存器指令接口重命名: 将 Reg::DataCopy 按语义拆分为 Reg::LoadAlign/Reg::StoreAlignReg::DataCopyGatherReg::GatherReg::DataCopyScatterReg::ScatterReg::DataCopyUnAlign*Reg::LoadUnAlign*/Reg::StoreUnAlign*Reg::CopyReg::MoveReg::CompareScalarReg::ComparesReg::ReduceSumReg::Reduce<Reg::ReduceType::SUM>Reg::GatherMaskReg::SqueezeReg::MaskUnPackReg::UnPack,涉及 as_strided_gather.hconcat_base.hdynamic_partition_base.hsplit_v_ub_split.hcumsum_4_int.h 等文件。
  • 指针限定符替换: 将内核中 UB 缓冲区地址的 __local_mem__ 指针统一替换为 __ubuf__,覆盖 as_strideddynamic_partitiontriucumsumstrided_slice_grad 等多个算子的地址转换与函数形参声明。
  • NDMA 配置/参数类型重命名: 将 MultiCopyConfigNdDmaConfigMultiCopyParamsNdDmaParamsMultiCopyLoopInfoNdDmaLoopInfo,应用于 as_strided.hdynamic_partition_with_h_mc_small_w.hsplit_all_axis_nddma.hsplit_front_axis_nddma.hcumsum_core_sklansky.h 等文件。
  • 非对齐寄存器类型拆分与 MicroAPI 迁移: 将 UnalignReg 按用途拆分为 UnalignRegForLoad(加载)与 UnalignRegForStore(存储);并在 cumsum_core_sklansky.hcumsum_oneway_sklansky.h 中将未限定的 DataCopy 调用改为 MicroAPI::LoadAlign/MicroAPI::StoreAlign,保持原有搬运语义不变。
likedislike
不准确?
atomgit-bot
atomgit-bot
16 天前 评论:

代码审查

✅ 未发现问题

likedislike
不准确?
CANN-robotCANN-robot成员
16 天前 添加了label:cann-cla/yes
CANN-robot
CANN-robot成员
16 天前 评论:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.


PR Approval Progress

Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
conversion/as_strided zhanw_coding, 宋恺 (2/2) zhanw_coding (1/1)
conversion/concat 宋恺, zhanw_coding (2/2) zhanw_coding (1/1)
conversion/split_v zhanw_coding, 宋恺 (2/2) zhanw_coding (1/1)
conversion/view_copy zhanw_coding, 宋恺 (2/2) zhanw_coding (1/1)
math/cumsum zhanw_coding, 宋恺 (2/2) zhanw_coding (1/1)
math/eye 宋恺, zhanw_coding (2/2) zhanw_coding (1/1)
repo-cann/ops-math zhanw_coding, 宋恺 (2/2) zhanw_coding (1/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)

CLA Signature Pass

hw-zhangpanpan, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
此处折叠了53条消息 查看更多
CANN-robot
CANN-robot成员
9 天前 评论:

The MR can not be merged, because of this MR is work in process.

If you want to solve this problem, you can click here to do it in the FAQs.

likedislike
Hhw-zhangpanpan
7 天前 取消了草稿状态
hw-zhangpanpan
7 天前 评论:

/check-pr

likedislike
CANN-robotCANN-robot成员
7 天前 关闭了关联的issue
CANN-robotCANN-robot成员
7 天前 合入了pull request