当前Pull Request已关闭, 关闭人@马琦钧
变更摘要
本 PR 仅修改 conversion/weight_quant_preprocess/op_host/op_api/weight_quant_preprocess_registry.cpp 中的错误日志文案:删除了 OP_LOGE_FOR_INVALID_SHAPESIZE_WITH_REASON、OP_LOGE_FOR_INVALID_SHAPES_WITH_REASON 等日志宏 reason 字符串末尾多余的句号(共 25 处),使其符合 ErrMsg 规范(reason 不以标点结尾),并顺带按 clang-format 整理了 OP_CHECK 宏的换行格式;纯日志文案调整,无逻辑变化。
主要改动
- 删除 reason 末尾多余句号:将各校验函数中
(std::string(...) + QuantDataFlowToString(ctx.dataFlow) + ".")形式的 reason 拼接改为去掉结尾的".",覆盖CheckWeightPackingDimEven、CheckWeightScaleMx、CheckOutWeightTransNz、CheckOutWeightScaleStorageShapeSame、CheckOutWeightOffsetOptionalDtypeSame等共 25 处错误日志。 - 格式化
OP_CHECK换行:按 clang-format 调整CheckWeightNotEmpty、CheckOutWeightNotNullEmpty两处OP_CHECK宏的换行排版,仅涉及代码格式,不影响行为。 - 无接口与行为变更:
aclnnStatus返回值、校验逻辑、QuantContext数据结构均未改动,仅调整错误日志输出文案。


Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.
PR Approval Progress
⚠️ This PR does not yet meet the following requirements:lgtm (requires ≥ 2 person(s) per module)、approve (requires ≥ 1 person(s) per module)
Module Approval Details
| module | lgtm status | approve status |
|---|---|---|
| repo-cann/ops-math | ❌ (0/2)(You can also ask: 王林木, zhangzijie, 冯彤, 周奇龙, jia0liang) | ❌ (0/1)(You can also ask: jia0liang, xuejinghui, 顾宝成, 汤平川, yue-ma) |
💡 Tip:
- Committer can comment
/approveor/lgtm- Commenting
/approveimplies both code review (lgtm) and intent to merge (approve)
CLA Signature Pass
maqijun, thanks for your pull request. All authors of the commits have signed the CLA. 👍


本 PR 内容已合并进 https://gitcode.com/cann/ops-math/pull/5241 ,此处关闭。


描述
weight_quant_preprocess_registry.cpp 中 OP_LOGE_FOR_*_WITH_REASON 的 reason 字符串末尾拼接了多余的 ".",不符合 ErrMsg 规范(reason 不带结尾标点),本次删除共 25 处;另按 clang-format 整理两处 OP_CHECK 换行。
改动范围
测试
纯错误日志文案修改,不影响功能逻辑。