Merged
refactor: move kth_value, median and nan_median to ops-nn #5550
黄晓彬Add on Sep 10
refactor: move kth_value, median and nan_median to ops-nn #5550
Merged
黄晓彬Add on Sep 10
黄晓彬Collaborators
Sep 10

描述

将 kth_value、median、nan_median 从 ops-math 迁至 ops-nn/index,本 PR 完成源仓清理。

  • 删除 math/kth_value、math/median、math/nan_median 下的 Host、Kernel、L0 API 和测试,共 61 个文件、9381 行删除。
  • 清理对应 classify_rule 和编译配置。原 simplified_key.ini 均为 default=0,目标仓采用等价的 SIMPLIFIED_KEY=0 默认值。
  • ops-math 的 Sort 保持原状;三个算子需要的 Sort 公共代码由目标仓承接。本 PR 不新增或重设计算法。

配套承接 PR:https://gitcode.com/cann/ops-nn/merge_requests/10222

关联的Issue

https://gitcode.com/cann/ops-math/issues/3141

测试

  • 5个aclnn接口各自500+ torch用例通过
  • 3个算子总共500+ST用例通过

文档更新

三个算子的 README、算子清单和 ACLNN 文档由配套 ops-nn PR 补齐,本仓随实现移除原目录内容。

类型标签

likedislike
Pull Request has been successfully merged by CANN-robot.
(Thank you for 黄晓彬's contribution.)
黄黄晓彬Collaborators
Sep 10 Created pull request, commit ca938aa0
atomgit-bot
atomgit-bot
Sep 10 Comments:

🤖 正在生成合并请求摘要,请稍候…

likedislike
Incorrect?
atomgit-bot
atomgit-bot
Sep 10 Comments:

🤖 AI 代码检视正在进行中,请稍候…

likedislike
Incorrect?
CANN-robotCANN-robotCollaborators
Sep 10 Added label: cann-cla/yes
CANN-robot
CANN-robotCollaborators
Sep 10 Comments:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.


PR Approval Progress

✅ Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
*/*/op_api/*.h ✅ 王瑞, 宋恺, 汤磊, 王永光 (4/2) ✅ 汤磊, 王永光 (2/1)
*/*/op_host/*_def.cpp ✅ 宋恺, 汤磊, 王永光, 王瑞 (4/2) ✅ 汤磊, 王永光 (2/1)
repo-cann/ops-math ✅ 王瑞, 宋恺 (2/2) ✅ 王瑞 (1/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)

CLA Signature Pass

ConanHuang, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
CANN-robotCANN-robotCollaborators
Sep 10 Set yue-ma,zhou-qilong,wangrui_,rxtfeng,loov1,tang-lei01,zhangzijie,jia0liang,zl_hw,songkai111,chenxingyu18,pingchuantang,llimwang,gubaocheng,andong_hw,wangyongguang,xuejinghui,zhanw_coding as approver
CANN-robotCANN-robotCollaborators
Sep 10 Set yue-ma,zhou-qilong,wangrui_,rxtfeng,loov1,tang-lei01,zhangzijie,jia0liang,zl_hw,songkai111,chenxingyu18,pingchuantang,llimwang,gubaocheng,andong_hw,wangyongguang,xuejinghui,zhanw_coding as approver
黄晓彬Collaborators
Sep 10 Comments:

compile

likedislike
黄黄晓彬Collaborators
Sep 10 Pre merge succeeded (commit_id: 9bdb6eae5369541ece03b58936dabc3a5cd5f339)
CANN-robot
CANN-robotCollaborators
Sep 10 Comments:
🚀 CI 流水线已启动
📋 执行详情: 点击查看流水线
likedislike
CANN-robotCANN-robotCollaborators
Sep 10 Added label: ci-pipeline-running
CANN-robotCANN-robotCollaborators
Sep 10 Removed label: ci-pipeline-running
CANN-robotCANN-robotCollaborators
Sep 10 Added label: ci-pipeline-passed
atomgit-bot
atomgit-bot
Sep 10 Comments:

⚠️ 本次变更过大(61 个可审文件、9381 行,预估需 8 轮分片审查),已超出 AI 代码评审的处理范围,本次跳过。建议拆分为更小的 PR 以获得有效评审。

likedislike
Incorrect?
atomgit-bot
atomgit-bot
Sep 10 Comments:

⚠️ 本次变更过大(61 个可审文件、9381 行,预估需 8 轮分片审查),已超出 AI 代码评审的处理范围,本次跳过。建议拆分为更小的 PR 以获得有效评审。

likedislike
Incorrect?
黄黄晓彬Collaborators
Sep 10 Modify description of pull request
黄黄晓彬Collaborators
Sep 10 Modify description of pull request
sunchunCollaborators
Sep 11 Comments:

您好,PR已满足合入指标,请尽快联系Committer进行合入。如暂时不需要合入,请在PR标题前加[WIP]

likedislike
黄黄晓彬Collaborators
Sep 11 Pre merge succeeded (commit_id: 291df2cfdfd2aaacc6baa28748bb326bc76e83f0)
黄黄晓彬Collaborators
Sep 11 Force-pushed 19 commits:df5efedb-18 commits from branch master,261d89c0-refactor: move kth_value, median and nan_median to ops-nn
黄黄晓彬Collaborators
Sep 11 Pre merge succeeded (commit_id: b2ae70023f33d9bee484085bd136b6f9d5fb7a94)
CANN-robotCANN-robotCollaborators
Sep 11 Removed label: cann-cla/yes
CANN-robotCANN-robotCollaborators
Sep 11 Removed label: ci-pipeline-passed
CANN-robot
CANN-robotCollaborators
Sep 11 Comments:

Notification

This pull request has been changed(code update) or closed, so removes the following label(s): ci-pipeline-passed.

likedislike
CANN-robotCANN-robotCollaborators
Sep 11 Added label: cann-cla/yes
黄晓彬Collaborators
Sep 11 Comments:

compile

likedislike
黄黄晓彬Collaborators
Sep 11 Pre merge succeeded (commit_id: 923512f3a29fd2a8c489582586b2c0001a89b40d)
CANN-robot
CANN-robotCollaborators
Sep 11 Comments:
🚀 CI 流水线已启动
📋 执行详情: 点击查看流水线
likedislike
CANN-robotCANN-robotCollaborators
Sep 11 Added label: ci-pipeline-running
CANN-robotCANN-robotCollaborators
Sep 11 Removed label: ci-pipeline-running
CANN-robotCANN-robotCollaborators
Sep 11 Added label: ci-pipeline-passed
黄黄晓彬Collaborators
Sep 11 Modify description of pull request
tang-lei01Collaborators
Sep 11 Comments:

/approve

likedislike
wangyongguangCollaborators
Sep 11 Comments:

/approve

likedislike
RuiWang_Collaborators
Sep 11 Comments:

/lgtm
/approve

likedislike
CANN-robotCANN-robotCollaborators
Sep 11 Added label: approved
songkai111Collaborators
Sep 11 Comments:

/lgtm

likedislike
CANN-robotCANN-robotCollaborators
Sep 11 Added label: lgtm
CANN-robotCANN-robotCollaborators
Sep 11 Closed associated issue
CANN-robotCANN-robotCollaborators
Sep 11 Merged pull request