Merged
refactor(segsum/exp_segsum_grad): 重命名op_kernel头文件区分arch22/arch35 #5615
songkai111Add on Sep 12
refactor(segsum/exp_segsum_grad): 重命名op_kernel头文件区分arch22/arch35 #5615
Merged
songkai111Add on Sep 12
songkai111Collaborators
Sep 12

描述

将 segsum、exp_segsum_grad 两个算子的 op_kernel 头文件按架构重命名,明确区分 arch22 与 arch35,避免不同架构同名头文件在编译期产生歧义;并同步更新引用该头文件的 kernel 入口。

具体改动:

  • exp_segsum_grad/op_kernel/exp_segsum_grad.h → exp_segsum_grad_arch22.h,同步更新 exp_segsum_grad.cpp 的 include。
  • exp_segsum_grad/op_kernel/arch35/exp_segsum_grad.h → exp_segsum_grad_arch35.h,同步更新 arch35/exp_segsum_grad.cpp 的 include。
  • segsum/op_kernel/segsum.h → segsum_arch22.h,同步更新 segsum.cpp 的 include。
  • 同步更新 include guard(SEGSUM → SEGSUM_ARCH22_H、EXP_SEGSUM_GRAD_H → EXP_SEGSUM_GRAD_ARCH22_H)及文件头注释。
  • 顺带修正文件头 License 描述、代码格式与文件末尾缺失换行。

关联的Issue

测试

本改动为头文件重命名与 include 调整,通过编译验证两个算子的 kernel 可正常构建。

文档更新

无

类型标签

likedislike
Pull Request has been successfully merged by CANN-robot.
(Thank you for songkai111's contribution.)
Ssongkai111Collaborators
Sep 12 Created pull request, commit fcc3afa3
CANN-robotCANN-robotCollaborators
Sep 12 Added label: cann-cla/yes
CANN-robot
CANN-robotCollaborators
Sep 12 Comments:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.


PR Approval Progress

✅ Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
math/segsum ✅ 汤平川, zhanw_coding (2/2) ✅ 汤平川 (1/1)
repo-cann/ops-math ✅ 汤平川, zhanw_coding (2/2) ✅ 汤平川 (1/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)

CLA Signature Pass

songkai111, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
CANN-robotCANN-robotCollaborators
Sep 12 Set FelixTang7,yue-ma,zhou-qilong,wangrui_,renruhai,rxtfeng,luowen203_gg123,loov1,zhangzijie,jia0liang,zl_hw,chenxingyu18,liujie12345678,demoauguste,pingchuantang,llimwang,gubaocheng,andong_hw,xuejinghui,zhanw_coding as approver
CANN-robotCANN-robotCollaborators
Sep 12 Set FelixTang7,yue-ma,zhou-qilong,wangrui_,renruhai,rxtfeng,luowen203_gg123,loov1,zhangzijie,jia0liang,zl_hw,chenxingyu18,liujie12345678,demoauguste,pingchuantang,llimwang,gubaocheng,andong_hw,xuejinghui,zhanw_coding as approver
songkai111Collaborators
Sep 12 Comments:

compile

likedislike
Ssongkai111Collaborators
Sep 12 Pre merge succeeded (commit_id: 3f5e751f6502228ea1327a983a6770ee9e436eea)
CANN-robot
CANN-robotCollaborators
Sep 12 Comments:
🚀 CI 流水线已启动
📋 执行详情: 点击查看流水线
likedislike
CANN-robotCANN-robotCollaborators
Sep 12 Added label: ci-pipeline-running
6 event messages are collapsed here。 See more
CANN-robotCANN-robotCollaborators
Sep 12 Added label: cann-cla/yes
songkai111Collaborators
Sep 12 Comments:

compile

likedislike
Ssongkai111Collaborators
Sep 12 Pre merge succeeded (commit_id: f70ab1dbfb6c671abccd92d5b99603b9a41a7e48)
CANN-robot
CANN-robotCollaborators
Sep 12 Comments:
🚀 CI 流水线已启动
📋 执行详情: 点击查看流水线
likedislike
CANN-robotCANN-robotCollaborators
Sep 12 Removed label: ci-pipeline-failed
CANN-robotCANN-robotCollaborators
Sep 12 Added label: ci-pipeline-running
Ssongkai111Collaborators
Sep 12 Change title to "refactor(segsum/exp_segsum_grad): 重命名op_kernel头文件区分arch22/arch35", originally titled "refactor(segsum/exp_segsum_grad): 重命名op_kernel头文件区分arch22与arch35".
Ssongkai111Collaborators
Sep 12 Modify description of pull request
CANN-robotCANN-robotCollaborators
Sep 12 Removed label: ci-pipeline-running
CANN-robotCANN-robotCollaborators
Sep 12 Added label: ci-pipeline-passed
sunchunCollaborators
Sep 13 Comments:

您好,PR已满足合入指标,请尽快联系Committer进行合入。如暂时不需要合入,请在PR标题前加[WIP]

likedislike
TangPC
TangPCCollaborators
Sep 14 Comments:

/lgtm
/approve

likedislike
CANN-robotCANN-robotCollaborators
Sep 14 Added label: approved
zhanw_coding
zhanw_codingCollaborators
Sep 14 Comments:

/lgtm

likedislike
CANN-robotCANN-robotCollaborators
Sep 14 Added label: lgtm
CANN-robotCANN-robotCollaborators
Sep 14 Closed associated issue
CANN-robotCANN-robotCollaborators
Sep 14 Merged pull request