Merged
feat: arg_max_v2/arg_max_with_value/arg_min/arg_min_with_value 适配 ascend960dt #5787
jzj007Add on Sep 18
feat: arg_max_v2/arg_max_with_value/arg_min/arg_min_with_value 适配 ascend960dt #5787
Merged
Merged fromjzj007/ops-mathv121intocann/ops-mathmaster
Pull Request has been successfully merged by CANN-robot.
(Thank you for jzj007's contribution.)Sep 18 Added label: cann-cla/yes
CANN-robot
Sep 18 Comments:
Sep 18 Comments:
Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.
PR Approval Progress
✅ Congratulations! All modules have met the lgtm and approve requirements.
Module Approval Details
| module | lgtm status | approve status |
|---|---|---|
| */*/op_host/*_def.cpp | ✅ 汤磊, 汤平川, 王瑞 (3/2) | ✅ 汤磊 (1/1) |
| math/arg_max_v2 | ✅ 汤平川, 王瑞 (2/2) | ✅ 汤平川, 王瑞 (2/1) |
| math/arg_max_with_value | ✅ 王瑞, 汤平川 (2/2) | ✅ 王瑞, 汤平川 (2/1) |
| math/arg_min | ✅ 汤平川, 王瑞 (2/2) | ✅ 汤平川, 王瑞 (2/1) |
| math/arg_min_with_value | ✅ 汤平川, 王瑞 (2/2) | ✅ 汤平川, 王瑞 (2/1) |
| repo-cann/ops-math | ✅ 汤平川, 王瑞 (2/2) | ✅ 汤平川, 王瑞 (2/1) |
💡 Tip:
- Committer can comment
/approveor/lgtm- Commenting
/approveimplies both code review (lgtm) and intent to merge (approve)
CLA Signature Pass
jzj007, thanks for your pull request. All authors of the commits have signed the CLA. 👍


Sep 18 Set FelixTang7,yue-ma,zhou-qilong,wangrui_,rxtfeng,loov1,tang-lei01,zhangzijie,jia0liang,zl_hw,songkai111,chenxingyu18,pingchuantang,llimwang,gubaocheng,andong_hw,wangyongguang,xuejinghui,zhanw_coding as approver
Sep 18 Set FelixTang7,yue-ma,zhou-qilong,wangrui_,rxtfeng,loov1,tang-lei01,zhangzijie,jia0liang,zl_hw,songkai111,chenxingyu18,pingchuantang,llimwang,gubaocheng,andong_hw,wangyongguang,xuejinghui,zhanw_coding as approver
Sep 18 Set FelixTang7,yue-ma,zhou-qilong,wangrui_,rxtfeng,loov1,tang-lei01,zhangzijie,jia0liang,zl_hw,songkai111,chenxingyu18,pingchuantang,llimwang,gubaocheng,andong_hw,wangyongguang,xuejinghui,zhanw_coding as approver
Sep 18 Set FelixTang7,yue-ma,zhou-qilong,wangrui_,rxtfeng,loov1,tang-lei01,zhangzijie,jia0liang,zl_hw,songkai111,chenxingyu18,pingchuantang,llimwang,gubaocheng,andong_hw,wangyongguang,xuejinghui,zhanw_coding as approver
131 messages are collapsed here。 See more
19 days ago Added label: approved
CANN-robot
19 days ago Comments:
19 days ago Comments:
The MR can not be merged, because of CodeReview discussion not resolved
If you want to solve this problem, you can click here to do it in the FAQs.


19 days ago Resolved final issue
19 days ago Closed associated issue
19 days ago Merged pull request
描述
为 diag、arg_max_v2、arg_max_with_value、arg_min、arg_min_with_value 五个算子新增 ascend960dt 芯片平台适配,使其可在 ascend960dt(arch35)上完成算子定义注册、tiling 编译与二进制 kernel 配置生成。
改动原因
算子 v121 分支合入主线,并为上述 5 个算子补齐 ascend960dt 平台支持。
改动方法
变更文件
关联的Issue
测试
本次改动为芯片平台适配(CMake 编译配置、算子定义注册、binary/simplified_key 配置),未修改 kernel 计算逻辑,复用 arch35 tiling 与 kernel 实现。需在 ascend960dt 环境完成编译及算子泛化、二级冒烟验证。
文档更新
无
类型标签