Merged
docs: 修复注释与文档不一致(原型头文件拼写与 axes 说明) #6480
docs: 修复注释与文档不一致(原型头文件拼写与 axes 说明) #6480
Merged
TangPCAdd on 19 days ago
TangPC
TangPCCollaborators
19 days ago

描述

修复原型头文件注释:

  • common/inc/op_graph/op_math_proto_extend.h:specifed -> specified,intput -> input。
  • conversion/strided_slice_assign_v2/op_graph/strided_slice_assign_v2_proto.h:Supoort -> Support;axes 输入说明由 stride 改为 axes。

同时包含文件末尾换行的 pre-commit 修复。

关联的Issue

测试

  • pre-commit(含 OAT):通过
  • Markdown 链接/图片检查:无新增失效项
  • Markdown 代码围栏检查:通过
  • 全部 26 个分支合并验证:无冲突

文档更新

  • common/inc/op_graph/op_math_proto_extend.h
  • conversion/strided_slice_assign_v2/op_graph/strided_slice_assign_v2_proto.h

类型标签

likedislike
Pull Request has been successfully merged by CANN-robot.
(Thank you for TangPC's contribution.)
TangPCTangPCCollaborators
19 days ago Created pull request, commit 31456563
atomgit-bot
atomgit-bot
19 days ago Comments:

变更摘要

本 PR 为纯文档/注释修复,主要针对原型头文件中的拼写错误与输入说明不一致进行更正,属于文档更新类型,不涉及任何接口行为或逻辑变更。改动集中在 common/inc/op_graph/op_math_proto_extend.h 与 conversion/strided_slice_assign_v2/op_graph/strided_slice_assign_v2_proto.h 两个文件的注释内容,同时包含文件末尾换行的 pre-commit 修复。

主要改动

  • 拼写错误修正: 在 op_math_proto_extend.h 中将注释里的 specifed 改为 specified、intput 改为 input,修正属性说明文本。
  • 拼写错误批量修正: 在 strided_slice_assign_v2_proto.h 中将各输入项格式说明中的 Supoort 统一改为 Support。
  • axes 输入说明修正: 将 strided_slice_assign_v2_proto.h 中 axes 输入由原来的「Specifies the stride to select.」更正为「Specifies the axes to select.」,使说明与输入语义一致。
  • 文件末尾换行修复: 为 strided_slice_assign_v2_proto.h 末尾的 #endif 补充换行,符合 pre-commit 规范。

🧩 本次 Review 已使用自定义 Skill:

likedislike
Incorrect?
atomgit-bot
atomgit-bot
19 days ago Comments:

代码审查

✅ 未发现问题


🧩 本次 Review 已使用自定义 Skill:

likedislike
Incorrect?
CANN-robotCANN-robotCollaborators
19 days ago Added label: cann-cla/yes
CANN-robot
CANN-robotCollaborators
19 days ago Comments:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.


PR Approval Progress

✅ Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
*/*/op_graph/*_proto.h ✅ 王永光, 王林木, 顾宝成 (3/2) ✅ 王永光 (1/1)
*/*/op_graph/*_proto_extend.h ✅ 王永光, 王林木, 顾宝成 (3/2) ✅ 王永光 (1/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)

CLA Signature Pass

pingchuantang, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
CANN-robotCANN-robotCollaborators
19 days ago Set FelixTang7,yue-ma,zhou-qilong,wangrui_,rxtfeng,loov1,tang-lei01,zhangzijie,jia0liang,zl_hw,songkai111,chenxingyu18,llimwang,gubaocheng,andong_hw,wangyongguang,xuejinghui,zhanw_coding,clinglai0517 as approver
CANN-robotCANN-robotCollaborators
19 days ago Set tang-lei01,wangyongguang as approver
TangPC
TangPCCollaborators
19 days ago Comments:

compile

likedislike
TangPCTangPCCollaborators
19 days ago Pre merge succeeded (commit_id: b820d303393dc831ddeb110eedd4c8d855716d4e)
CANN-robot
CANN-robotCollaborators
19 days ago Comments:
🚀 CI 流水线已启动
📋 执行详情: 点击查看流水线
likedislike
CANN-robotCANN-robotCollaborators
19 days ago Added label: ci-pipeline-running
TangPCTangPCCollaborators
19 days ago Modify description of pull request
CANN-robotCANN-robotCollaborators
19 days ago Removed label: ci-pipeline-running
CANN-robotCANN-robotCollaborators
19 days ago Added label: ci-pipeline-passed
llimwangCollaborators
19 days ago Comments:

/lgtm
/approve

likedislike
gubaochengCollaborators
19 days ago Comments:

/lgtm
/approve
by agent

likedislike
CANN-robotCANN-robotCollaborators
19 days ago Added label: lgtm
wangyongguangCollaborators
19 days ago Comments:

/approve

likedislike
CANN-robot
CANN-robotCollaborators
19 days ago Comments:

The following users do not have permission to comment /lgtm or /approve on any module in this PR:
/approve: 王林木, 顾宝成

likedislike
CANN-robotCANN-robotCollaborators
19 days ago Added label: approved
CANN-robotCANN-robotCollaborators
19 days ago Closed associated issue
CANN-robotCANN-robotCollaborators
19 days ago Merged pull request