Merged
docs: 修复注释与代码不一致(原型文件头文件名) #6495
docs: 修复注释与代码不一致(原型文件头文件名) #6495
Merged
TangPCAdd on 22 days ago
TangPC
TangPCCollaborators
22 days ago

描述

修正 \file 注释为实际文件名:

  • math/histogram_v2/op_graph/histogram_v2_proto.h:hans_encode_proto.h -> histogram_v2_proto.h。
  • conversion/space_to_depth/op_graph/space_to_depth_proto.h:transpose_proto.h -> space_to_depth_proto.h。

关联的Issue

测试

  • pre-commit(含 OAT):通过
  • Markdown 链接/图片检查:无新增失效项
  • Markdown 代码围栏检查:通过
  • 全部 26 个分支合并验证:无冲突

文档更新

  • conversion/space_to_depth/op_graph/space_to_depth_proto.h
  • math/histogram_v2/op_graph/histogram_v2_proto.h

类型标签

likedislike
Pull Request has been successfully merged by CANN-robot.
(Thank you for TangPC's contribution.)
TangPCTangPCCollaborators
22 days ago Created pull request, commit 63d40ee8
atomgit-bot
atomgit-bot
22 days ago Comments:

变更摘要

本 PR 为文档/注释一致性修复,主要将两个原型头文件中的 \file 注释改为与所在文件实际名称一致,并对 math/histogram_v2/op_graph/histogram_v2_proto.h 的收尾格式做了整理。涉及 conversion/space_to_depth/op_graph/space_to_depth_proto.h 与 math/histogram_v2/op_graph/histogram_v2_proto.h 两个文件,不改变接口、数据结构或外部行为。

主要改动

  • 修正 space_to_depth_proto.h 的文件头注释: 将 \file 注释由 transpose_proto.h 改为 space_to_depth_proto.h,使文档注释与文件实际名称一致。
  • 修正 histogram_v2_proto.h 的文件头注释: 将 \file 注释由 hans_encode_proto.h 改为 histogram_v2_proto.h,使文档注释与文件实际名称一致。
  • 整理 histogram_v2_proto.h 的格式: 调整 } // namespace ge 的空格写法,并规范文件末尾的 #endif 注释格式(原文件缺少行尾换行),该改动不影响代码逻辑。

🧩 本次 Review 已使用自定义 Skill:

likedislike
Incorrect?
atomgit-bot
atomgit-bot
22 days ago Comments:

代码审查

✅ 未发现问题


🧩 本次 Review 已使用自定义 Skill:

likedislike
Incorrect?
CANN-robotCANN-robotCollaborators
22 days ago Added label: cann-cla/yes
CANN-robot
CANN-robotCollaborators
22 days ago Comments:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.


PR Approval Progress

✅ Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
*/*/op_graph/*_proto.h ✅ 王永光, 王林木 (2/2) ✅ 王永光 (1/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)

CLA Signature Pass

pingchuantang, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
CANN-robotCANN-robotCollaborators
22 days ago Set FelixTang7,yue-ma,zhou-qilong,wangrui_,rxtfeng,loov1,tang-lei01,zhangzijie,jia0liang,zl_hw,songkai111,chenxingyu18,llimwang,gubaocheng,andong_hw,wangyongguang,xuejinghui,zhanw_coding,clinglai0517 as approver
CANN-robotCANN-robotCollaborators
22 days ago Set tang-lei01,wangyongguang as approver
TangPC
TangPCCollaborators
19 days ago Comments:

compile

likedislike
TangPCTangPCCollaborators
19 days ago Pre merge succeeded (commit_id: 2e385964182c659ea0e83cd28046c5dbdfc9879f)
CANN-robot
CANN-robotCollaborators
19 days ago Comments:
🚀 CI 流水线已启动
📋 执行详情: 点击查看流水线
likedislike
CANN-robotCANN-robotCollaborators
19 days ago Added label: ci-pipeline-running
CANN-robotCANN-robotCollaborators
19 days ago Removed label: ci-pipeline-running
CANN-robotCANN-robotCollaborators
19 days ago Added label: ci-pipeline-passed
TangPCTangPCCollaborators
19 days ago Modify description of pull request
llimwangCollaborators
19 days ago Comments:

/lgtm
/approve

likedislike
wangyongguangCollaborators
19 days ago Comments:

/approve

likedislike
CANN-robot
CANN-robotCollaborators
19 days ago Comments:

The following users do not have permission to comment /lgtm or /approve on any module in this PR:
/approve: 王林木

likedislike
CANN-robotCANN-robotCollaborators
19 days ago Added label: lgtmapproved
CANN-robotCANN-robotCollaborators
19 days ago Closed associated issue
CANN-robotCANN-robotCollaborators
19 days ago Merged pull request