Merged
docs: 修复注释与代码不一致(失效 TODO 与头文件保护注释) #6497
TangPCAdd on 25 days ago
docs: 修复注释与代码不一致(失效 TODO 与头文件保护注释) #6497
Merged
Pull Request has been successfully merged by CANN-robot.
(Thank you for TangPC's contribution.)atomgit-bot
25 days ago Comments:
25 days ago Comments:
变更摘要
本 PR 属于文档/注释清理类型,主要修正 confusion_transpose_d 算子相关文件中的注释与代码不一致问题:删除了 confusion_transpose_d_graph_infer.cpp 中已失效的“头文件不存在”TODO 注释,并将 confusion_transpose_d_tiling_arch35.h 中 #endif 的注释更正为实际的头文件保护宏名 CONFUSION_TRANSPOSE_D_TILING_ARCH35_H_。同时顺带调整了该 .cpp 文件的部分代码格式。
主要改动
- 删除失效 TODO 注释: 移除
conversion/confusion_transpose_d/op_graph/confusion_transpose_d_graph_infer.cpp中//todo:这些头文件都没有啊一行,消除与实际#include头文件不符的过时说明。 - 修正头文件保护宏注释: 将
conversion/confusion_transpose_d/op_host/arch35/confusion_transpose_d_tiling_arch35.h末尾#endif后的注释由CONFUSION_TRANSPOSE_D_TILING_H_改为实际 guard 名CONFUSION_TRANSPOSE_D_TILING_ARCH35_H_,使注释与宏定义一致。 - 格式规范化: 在同一
.cpp文件中将namespace ops的花括号、InferDataType4ConfusionTransposeD函数定义的花括号调整为统一风格,并在文件末尾补上缺失的换行符。
🧩 本次 Review 已使用自定义 Skill:


Incorrect?
atomgit-bot
25 days ago Comments:
25 days ago Comments:


Incorrect?
25 days ago Added label: cann-cla/yes
CANN-robot
25 days ago Comments:
25 days ago Comments:
Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.
PR Approval Progress
✅ Congratulations! All modules have met the lgtm and approve requirements.
Module Approval Details
| module | lgtm status | approve status |
|---|---|---|
| repo-cann/ops-math | ✅ 王林木, 张磊 (2/2) | ✅ 张磊, 王林木 (2/1) |
💡 Tip:
- Committer can comment
/approveor/lgtm- Commenting
/approveimplies both code review (lgtm) and intent to merge (approve)


CANN-robot
25 days ago Comments:
25 days ago Comments:
25 days ago Set yue-ma,zhou-qilong,wangrui_,rxtfeng,loov1,zhangzijie,jia0liang,zl_hw,songkai111,chenxingyu18,llimwang,gubaocheng,andong_hw,xuejinghui,zhanw_coding,clinglai0517 as approver
25 days ago Set yue-ma,zhou-qilong,wangrui_,rxtfeng,loov1,zhangzijie,jia0liang,zl_hw,songkai111,chenxingyu18,llimwang,gubaocheng,andong_hw,xuejinghui,zhanw_coding,clinglai0517 as approver
25 days ago Set yue-ma,zhou-qilong,wangrui_,rxtfeng,loov1,zhangzijie,jia0liang,zl_hw,songkai111,chenxingyu18,llimwang,gubaocheng,andong_hw,xuejinghui,zhanw_coding,clinglai0517 as approver
25 days ago Set yue-ma,zhou-qilong,wangrui_,rxtfeng,loov1,zhangzijie,jia0liang,zl_hw,songkai111,chenxingyu18,llimwang,gubaocheng,andong_hw,xuejinghui,zhanw_coding,clinglai0517 as approver
TangPC
22 days ago Comments:
22 days ago Comments:
compile


22 days ago Pre merge succeeded (commit_id: 2cb11d69837bc9bd149f3480e3822f625e318715)
CANN-robot
22 days ago Comments:
22 days ago Comments:
| 🚀 CI 流水线已启动 |
|---|
| 📋 执行详情: 点击查看流水线 |


22 days ago Added label: ci-pipeline-running
22 days ago Removed label: ci-pipeline-running
22 days ago Added label: ci-pipeline-passed
22 days ago Modify description of pull request
22 days ago Added label: approved
22 days ago Added label: lgtm
22 days ago Closed associated issue
22 days ago Merged pull request
描述
conversion/confusion_transpose_d/op_graph/confusion_transpose_d_graph_infer.cpp:删除已失效的“头文件不存在”TODO。conversion/confusion_transpose_d/op_host/arch35/confusion_transpose_d_tiling_arch35.h:#endif注释改为实际 guard 名CONFUSION_TRANSPOSE_D_TILING_ARCH35_H_。关联的Issue
测试
文档更新
conversion/confusion_transpose_d/op_graph/confusion_transpose_d_graph_infer.cppconversion/confusion_transpose_d/op_host/arch35/confusion_transpose_d_tiling_arch35.h类型标签