Merged
docs: 修复注释与代码不一致(失效 TODO 与头文件保护注释) #6497
docs: 修复注释与代码不一致(失效 TODO 与头文件保护注释) #6497
Merged
TangPCAdd on 25 days ago
TangPC
TangPCCollaborators
25 days ago

描述

  • conversion/confusion_transpose_d/op_graph/confusion_transpose_d_graph_infer.cpp:删除已失效的“头文件不存在”TODO。
  • conversion/confusion_transpose_d/op_host/arch35/confusion_transpose_d_tiling_arch35.h:#endif 注释改为实际 guard 名 CONFUSION_TRANSPOSE_D_TILING_ARCH35_H_。

关联的Issue

测试

  • pre-commit(含 OAT):通过
  • Markdown 链接/图片检查:无新增失效项
  • Markdown 代码围栏检查:通过
  • 全部 26 个分支合并验证:无冲突

文档更新

  • conversion/confusion_transpose_d/op_graph/confusion_transpose_d_graph_infer.cpp
  • conversion/confusion_transpose_d/op_host/arch35/confusion_transpose_d_tiling_arch35.h

类型标签

likedislike
Pull Request has been successfully merged by CANN-robot.
(Thank you for TangPC's contribution.)
TangPCTangPCCollaborators
25 days ago Created pull request, commit cdb97c33
atomgit-bot
atomgit-bot
25 days ago Comments:

变更摘要

本 PR 属于文档/注释清理类型,主要修正 confusion_transpose_d 算子相关文件中的注释与代码不一致问题:删除了 confusion_transpose_d_graph_infer.cpp 中已失效的“头文件不存在”TODO 注释,并将 confusion_transpose_d_tiling_arch35.h 中 #endif 的注释更正为实际的头文件保护宏名 CONFUSION_TRANSPOSE_D_TILING_ARCH35_H_。同时顺带调整了该 .cpp 文件的部分代码格式。

主要改动

  • 删除失效 TODO 注释: 移除 conversion/confusion_transpose_d/op_graph/confusion_transpose_d_graph_infer.cpp 中 //todo:这些头文件都没有啊 一行,消除与实际 #include 头文件不符的过时说明。
  • 修正头文件保护宏注释: 将 conversion/confusion_transpose_d/op_host/arch35/confusion_transpose_d_tiling_arch35.h 末尾 #endif 后的注释由 CONFUSION_TRANSPOSE_D_TILING_H_ 改为实际 guard 名 CONFUSION_TRANSPOSE_D_TILING_ARCH35_H_,使注释与宏定义一致。
  • 格式规范化: 在同一 .cpp 文件中将 namespace ops 的花括号、InferDataType4ConfusionTransposeD 函数定义的花括号调整为统一风格,并在文件末尾补上缺失的换行符。

🧩 本次 Review 已使用自定义 Skill:

likedislike
Incorrect?
atomgit-bot
atomgit-bot
25 days ago Comments:

代码审查

✅ 未发现问题


🧩 本次 Review 已使用自定义 Skill:

likedislike
Incorrect?
CANN-robotCANN-robotCollaborators
25 days ago Added label: cann-cla/yes
CANN-robot
CANN-robotCollaborators
25 days ago Comments:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.


PR Approval Progress

✅ Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
repo-cann/ops-math ✅ 王林木, 张磊 (2/2) ✅ 张磊, 王林木 (2/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)
likedislike
CANN-robot
CANN-robotCollaborators
25 days ago Comments:

CLA Signature Pass

pingchuantang, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
CANN-robotCANN-robotCollaborators
25 days ago Set yue-ma,zhou-qilong,wangrui_,rxtfeng,loov1,zhangzijie,jia0liang,zl_hw,songkai111,chenxingyu18,llimwang,gubaocheng,andong_hw,xuejinghui,zhanw_coding,clinglai0517 as approver
CANN-robotCANN-robotCollaborators
25 days ago Set yue-ma,zhou-qilong,wangrui_,rxtfeng,loov1,zhangzijie,jia0liang,zl_hw,songkai111,chenxingyu18,llimwang,gubaocheng,andong_hw,xuejinghui,zhanw_coding,clinglai0517 as approver
TangPC
TangPCCollaborators
22 days ago Comments:

compile

likedislike
TangPCTangPCCollaborators
22 days ago Pre merge succeeded (commit_id: 2cb11d69837bc9bd149f3480e3822f625e318715)
CANN-robot
CANN-robotCollaborators
22 days ago Comments:
🚀 CI 流水线已启动
📋 执行详情: 点击查看流水线
likedislike
CANN-robotCANN-robotCollaborators
22 days ago Added label: ci-pipeline-running
CANN-robotCANN-robotCollaborators
22 days ago Removed label: ci-pipeline-running
CANN-robotCANN-robotCollaborators
22 days ago Added label: ci-pipeline-passed
TangPCTangPCCollaborators
22 days ago Modify description of pull request
llimwangCollaborators
22 days ago Comments:

/lgtm
/approve

likedislike
CANN-robotCANN-robotCollaborators
22 days ago Added label: approved
zl_hwCollaborators
22 days ago Comments:

/lgtm
/approve

likedislike
CANN-robotCANN-robotCollaborators
22 days ago Added label: lgtm
CANN-robotCANN-robotCollaborators
22 days ago Closed associated issue
CANN-robotCANN-robotCollaborators
22 days ago Merged pull request