Merged
docs: 修复注释与代码不一致(DropOutDoMask 头文件保护注释) #6498
docs: 修复注释与代码不一致(DropOutDoMask 头文件保护注释) #6498
Merged
TangPCAdd on 22 days ago
TangPC
TangPCCollaborators
22 days ago

描述

修正 #endif 尾注释为各自实际 guard 名:

  • random/drop_out_do_mask_v3/op_host/arch35/drop_out_do_mask_v3_tiling_arch35.h
  • random/drop_out_do_mask_v3_d/op_host/arch35/drop_out_do_mask_v3_d_tiling_arch35.h

关联的Issue

测试

  • pre-commit(含 OAT):通过
  • Markdown 链接/图片检查:无新增失效项
  • Markdown 代码围栏检查:通过
  • 全部 26 个分支合并验证:无冲突

文档更新

  • random/drop_out_do_mask_v3/op_host/arch35/drop_out_do_mask_v3_tiling_arch35.h
  • random/drop_out_do_mask_v3_d/op_host/arch35/drop_out_do_mask_v3_d_tiling_arch35.h

类型标签

likedislike
Pull Request has been successfully merged by CANN-robot.
(Thank you for TangPC's contribution.)
TangPCTangPCCollaborators
22 days ago Created pull request, commit 939e53f3
atomgit-bot
atomgit-bot
22 days ago Comments:

变更摘要

这是一次纯注释修正的文档更新,目的是让头文件中 #endif 的尾注释与实际的头文件保护宏(guard 名)保持一致。改动仅涉及两个 tiling 头文件的注释文本,不改变任何代码逻辑、接口、数据结构或配置。

主要改动

  • 修正 drop_out_do_mask_v3 头文件保护注释: 将 random/drop_out_do_mask_v3/op_host/arch35/drop_out_do_mask_v3_tiling_arch35.h 中 #endif 的尾注释由 RANDOM_UNIFORM_V2_TILING_ARCH35_H 更正为 DROP_OUT_DO_MASK_V3_TILING_ARCH35_H,使其与该文件实际使用的 guard 名对应。
  • 修正 drop_out_do_mask_v3_d 头文件保护注释: 将 random/drop_out_do_mask_v3_d/op_host/arch35/drop_out_do_mask_v3_d_tiling_arch35.h 中 #endif 的尾注释由 RANDOM_UNIFORM_V2_TILING_ARCH35_H 更正为 DROP_OUT_DO_MASK_V3_D_TILING_ARCH35_H,消除从其他头文件复制遗留的错误注释。
  • 改动范围与性质: 两处修改均为 +1 -1 的注释文本替换,未触及 optiling 命名空间内的类定义或函数实现,不影响编译产物与运行行为。

🧩 本次 Review 已使用自定义 Skill:

likedislike
Incorrect?
atomgit-bot
atomgit-bot
22 days ago Comments:

代码审查

✅ 未发现问题


🧩 本次 Review 已使用自定义 Skill:

likedislike
Incorrect?
CANN-robotCANN-robotCollaborators
22 days ago Added label: cann-cla/yes
CANN-robot
CANN-robotCollaborators
22 days ago Comments:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.


PR Approval Progress

✅ Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
repo-cann/ops-math ✅ 王林木, 张磊 (2/2) ✅ 王林木, 张磊 (2/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)
likedislike
CANN-robot
CANN-robotCollaborators
22 days ago Comments:

CLA Signature Pass

pingchuantang, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
CANN-robotCANN-robotCollaborators
22 days ago Set yue-ma,zhou-qilong,wangrui_,rxtfeng,loov1,zhangzijie,jia0liang,zl_hw,songkai111,chenxingyu18,llimwang,gubaocheng,andong_hw,xuejinghui,zhanw_coding,clinglai0517 as approver
CANN-robotCANN-robotCollaborators
22 days ago Set yue-ma,zhou-qilong,wangrui_,rxtfeng,loov1,zhangzijie,jia0liang,zl_hw,songkai111,chenxingyu18,llimwang,gubaocheng,andong_hw,xuejinghui,zhanw_coding,clinglai0517 as approver
TangPC
TangPCCollaborators
19 days ago Comments:

compile

likedislike
TangPCTangPCCollaborators
19 days ago Pre merge succeeded (commit_id: ed07eb6984bd73a196cc06e7d4a6791d8f854366)
CANN-robot
CANN-robotCollaborators
19 days ago Comments:
🚀 CI 流水线已启动
📋 执行详情: 点击查看流水线
likedislike
CANN-robotCANN-robotCollaborators
19 days ago Added label: ci-pipeline-running
CANN-robotCANN-robotCollaborators
19 days ago Removed label: ci-pipeline-running
CANN-robotCANN-robotCollaborators
19 days ago Added label: ci-pipeline-passed
TangPCTangPCCollaborators
19 days ago Modify description of pull request
llimwangCollaborators
19 days ago Comments:

/lgtm
/approve

likedislike
CANN-robotCANN-robotCollaborators
19 days ago Added label: approved
zl_hwCollaborators
19 days ago Comments:

/lgtm
/approve

likedislike
CANN-robotCANN-robotCollaborators
19 days ago Added label: lgtm
CANN-robotCANN-robotCollaborators
19 days ago Closed associated issue
CANN-robotCANN-robotCollaborators
19 days ago Merged pull request