Merged
docs: 修复注释与代码不一致（AddLora ySliceSize 取值范围） #6500
TangPCAdd on 25 days ago
docs: 修复注释与代码不一致（AddLora ySliceSize 取值范围） #6500
Merged
Pull Request has been successfully merged by CANN-robot.
（Thank you for TangPC's contribution.）
atomgit-bot
25 days ago Comments：
25 days ago Comments：
变更摘要
本 PR 为文档修正，针对 math/add_lora/README.md 中 ySliceSize 参数的约束说明进行更新：将其取值范围由“值需要小于 y 的第二个维度 H3”改为“值需要小于等于 y 的第二个维度 H3”，使文档描述与 API 文档及实现允许等值的行为保持一致。
主要改动
- 修正
ySliceSize取值范围描述: 在math/add_lora/README.md的属性表中，将ySliceSize的约束由“小于 y 的第二个维度H3”改为“小于等于 y 的第二个维度H3”，允许取值等于H3。 - 统一文档与实现语义: 更新后的说明与 API 文档及实现中允许取等值的处理保持一致，避免使用者因文档表述产生误解。
🧩 本次 Review 已使用自定义 Skill：
Incorrect?
atomgit-bot
25 days ago Comments：
25 days ago Comments：
Incorrect?
25 days ago Added label: cann-cla/yes
CANN-robot
25 days ago Comments：
25 days ago Comments：
Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.
PR Approval Progress
✅ Congratulations! All modules have met the lgtm and approve requirements.
Module Approval Details
| module | lgtm status | approve status |
|---|---|---|
| */*/README.md | ✅ 陈娇, 王林木 (2/2) | ✅ 陈娇 (1/1) |
💡 Tip:
- Committer can comment
/approveor/lgtm- Commenting
/approveimplies both code review (lgtm) and intent to merge (approve)
CLA Signature Pass
pingchuantang, thanks for your pull request. All authors of the commits have signed the CLA. 👍
CANN-robot25 days ago Set FelixTang7,yue-ma,zhou-qilong,gitee-duhuiping,wangrui_,zhajianqing123,rxtfeng,luowen203_gg123,loov1,zhangzijie,jia0liang,zl_hw,songkai111,gitcode-chenjiao,chenxingyu18,demoauguste,llimwang,gubaocheng,andong_hw,fengying555682,xuejinghui,zhanw_coding,clinglai0517,caiwenwen,yanglu-1 as approver
25 days ago Set FelixTang7,yue-ma,zhou-qilong,gitee-duhuiping,wangrui_,zhajianqing123,rxtfeng,luowen203_gg123,loov1,zhangzijie,jia0liang,zl_hw,songkai111,gitcode-chenjiao,chenxingyu18,demoauguste,llimwang,gubaocheng,andong_hw,fengying555682,xuejinghui,zhanw_coding,clinglai0517,caiwenwen,yanglu-1 as approver
CANN-robot25 days ago Set gitee-duhuiping,gitcode-chenjiao,fengying555682,caiwenwen,yanglu-1 as approver
25 days ago Set gitee-duhuiping,gitcode-chenjiao,fengying555682,caiwenwen,yanglu-1 as approver
TangPC
22 days ago Comments：
22 days ago Comments：
compile
22 days ago Pre merge succeeded (commit_id: 44e9b171a4475d178cba88190a731848ddfcd6cb)
CANN-robot
22 days ago Comments：
22 days ago Comments：
| 🚀 CI 流水线已启动 |
|---|
| 📋 执行详情: 点击查看流水线 |
22 days ago Added label: ci-pipeline-running
22 days ago Removed label: ci-pipeline-running
22 days ago Added label: ci-pipeline-passed
22 days ago Modify description of pull request
CANN-robot
22 days ago Comments：
22 days ago Comments：
The following users do not have permission to comment /lgtm or /approve on any module in this PR:
/approve: 王林木
22 days ago Added label: lgtmapproved
22 days ago Closed associated issue
22 days ago Merged pull request
描述
math/add_lora/README.md：ySliceSize的约束由“小于 y 的第二个维度 H3”改为“小于等于 H3”，与 API 文档及实现允许等值的情况一致。关联的Issue
测试
文档更新
math/add_lora/README.md类型标签