Merged
【unfold_grad】修复issue问题 aclnn接口输入为空指针时使用ACLNN_ERR_PARAM_NULLPTR错误码 & 修正正确的dim值域 #6650
tangkaidiAdd on 18 days ago
【unfold_grad】修复issue问题 aclnn接口输入为空指针时使用ACLNN_ERR_PARAM_NULLPTR错误码 & 修正正确的dim值域 #6650
Merged
Merged fromtangkaidi/ops-math-solve-issuemasterintocann/ops-mathmaster
Pull Request has been successfully merged by CANN-robot.
（Thank you for tangkaidi's contribution.）18 days ago Added label: cann-cla/yes
CANN-robot
18 days ago Comments：
18 days ago Comments：
Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.
PR Approval Progress
✅ Congratulations! All modules have met the lgtm and approve requirements.
Module Approval Details
| module | lgtm status | approve status |
|---|---|---|
| */*/README.md | ✅ 蔡雯雯, 汤平川 (2/2) | ✅ 蔡雯雯 (1/1) |
| */*/docs/acl*.md | ✅ 蔡雯雯, 汤平川 (2/2) | ✅ 蔡雯雯 (1/1) |
| conversion/unfold_grad | ✅ 汤平川, 宋恺 (2/2) | ✅ 汤平川, 宋恺 (2/1) |
💡 Tip:
- Committer can comment
/approveor/lgtm- Commenting
/approveimplies both code review (lgtm) and intent to merge (approve)
CLA Signature Pass
tangkaidi, thanks for your pull request. All authors of the commits have signed the CLA. 👍
CANN-robot18 days ago Set FelixTang7,yue-ma,zhou-qilong,gitee-duhuiping,wangrui_,rxtfeng,loov1,zhangzijie,jia0liang,zl_hw,songkai111,gitcode-chenjiao,chenxingyu18,pingchuantang,llimwang,gubaocheng,andong_hw,fengying555682,xuejinghui,onanfield,zhanw_coding,clinglai0517,caiwenwen,yanglu-1 as approver
18 days ago Set FelixTang7,yue-ma,zhou-qilong,gitee-duhuiping,wangrui_,rxtfeng,loov1,zhangzijie,jia0liang,zl_hw,songkai111,gitcode-chenjiao,chenxingyu18,pingchuantang,llimwang,gubaocheng,andong_hw,fengying555682,xuejinghui,onanfield,zhanw_coding,clinglai0517,caiwenwen,yanglu-1 as approver
CANN-robot18 days ago Set FelixTang7,yue-ma,zhou-qilong,gitee-duhuiping,wangrui_,rxtfeng,loov1,zhangzijie,zl_hw,songkai111,gitcode-chenjiao,chenxingyu18,pingchuantang,llimwang,gubaocheng,andong_hw,fengying555682,xuejinghui,onanfield,zhanw_coding,clinglai0517,caiwenwen,yanglu-1 as approver
18 days ago Set FelixTang7,yue-ma,zhou-qilong,gitee-duhuiping,wangrui_,rxtfeng,loov1,zhangzijie,zl_hw,songkai111,gitcode-chenjiao,chenxingyu18,pingchuantang,llimwang,gubaocheng,andong_hw,fengying555682,xuejinghui,onanfield,zhanw_coding,clinglai0517,caiwenwen,yanglu-1 as approver
CANN-robot
18 days ago Comments：
18 days ago Comments：
| 🚀 CI 流水线已启动 |
|---|
| 📋 执行详情: 点击查看流水线 |
18 days ago Added label: ci-pipeline-running
6 event messages are collapsed here。 See more
18 days ago Removed label: ci-pipeline-passed
CANN-robot
18 days ago Comments：
18 days ago Comments：
18 days ago Added label: cann-cla/yes
CANN-robot
18 days ago Comments：
18 days ago Comments：
| 🚀 CI 流水线已启动 |
|---|
| 📋 执行详情: 点击查看流水线 |
18 days ago Added label: ci-pipeline-running
18 days ago Removed label: ci-pipeline-running
18 days ago Added label: ci-pipeline-passed
chenyifeng
17 days ago Comments：
17 days ago Comments：
您好，PR已满足合入指标，请尽快联系Committer进行合入。如暂时不需要合入，请在PR标题前加[WIP]
CANN-robot
16 days ago Comments：
16 days ago Comments：
| 🚀 CI 流水线已启动 |
|---|
| 📋 执行详情: 点击查看流水线 |
16 days ago Removed label: ci-pipeline-passed
16 days ago Added label: ci-pipeline-running
16 days ago Removed label: ci-pipeline-running
16 days ago Added label: ci-pipeline-passed
TangPC
16 days ago Comments：
16 days ago Comments：
/lgtm
/approve
songkai111
16 days ago Comments：
16 days ago Comments：
/approve
16 days ago Added label: lgtmapproved
16 days ago Closed associated issue
16 days ago Merged pull request
描述
修复issue问题
1：aclnn阶段校验参数时，如果gradOut、intputSizes、gradIn三个必须传入的参数为空指针，错误码由ACLNN_ERR_INNER_NULLPTR改为ACLNN_ERR_PARAM_NULLPTR。
2：原本资料内对dim参数的支持范围描述不正确，修改为dim大于等于0且小于len(inputSizes)。
关联的Issue
[Bug-Report|缺陷反馈]: aclnnUnfoldGrad 空指针返回 561103 而非文档承诺的 161001，且 len(inputSizes)=3 时 dim=0 未被拒绝 #3795
测试
调用aclnn二段式接口，传入gradOut为nullptr。
修改前：
修改后：
新增三个UT用例来校验gradOut、intputSizes、gradIn为nullptr时返回的错误码是否正确，全部通过且返回错误码符合预期。
ATK泛化dim维度（dim大于等于0且小于len(inputSizes)），生成15000用例，全部通过。
文档更新
conversion/unfold_grad/docs/aclnnUnfoldGrad.md
conversion/unfold_grad/README.md
类型标签