Merged
fix(circular_pad): 统一2d/3d为单一GEIR算子,加固负padding与索引位宽处理 #6780
wuyanAdd on 19 days ago
fix(circular_pad): 统一2d/3d为单一GEIR算子,加固负padding与索引位宽处理 #6780
Merged
Merged fromrrely11/ops-math_1016masterintocann/ops-mathmaster
Pull Request has been successfully merged by CANN-robot.
(Thank you for wuyan's contribution.)19 days ago Added label: cann-cla/no
CANN-robot
19 days ago Comments:
19 days ago Comments:
Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.
PR Approval Progress
✅ Congratulations! All modules have met the lgtm and approve requirements.
Module Approval Details
| module | lgtm status | approve status |
|---|---|---|
| */*/README.md | ✅ 陈娇, zhanw_coding (2/2) | ✅ 陈娇 (1/1) |
| */*/docs/acl*.md | ✅ zhanw_coding, 陈娇 (2/2) | ✅ 陈娇 (1/1) |
| */*/op_api/*.h | ✅ 汤磊, zhanw_coding (2/2) | ✅ 汤磊 (1/1) |
| */*/op_graph/*_proto.h | ✅ 汤磊, zhanw_coding (2/2) | ✅ 汤磊 (1/1) |
| conversion/circular_pad | ✅ zhanw_coding, andong_hw (2/2) | ✅ zhanw_coding, andong_hw (2/1) |
💡 Tip:
- Committer can comment
/approveor/lgtm- Commenting
/approveimplies both code review (lgtm) and intent to merge (approve)
CLA Signature Pass
rrely11, thanks for your pull request. All authors of the commits have signed the CLA. 👍


19 days ago Set FelixTang7,yue-ma,zhou-qilong,gitee-duhuiping,wangrui_,rxtfeng,loov1,tang-lei01,zhangzijie,jia0liang,zl_hw,songkai111,gitcode-chenjiao,chenxingyu18,pingchuantang,llimwang,gubaocheng,andong_hw,wangyongguang,fengying555682,xuejinghui,onanfield,zhanw_coding,clinglai0517,caiwenwen,yanglu-1 as approver
19 days ago Set FelixTang7,yue-ma,zhou-qilong,gitee-duhuiping,wangrui_,rxtfeng,loov1,tang-lei01,zhangzijie,jia0liang,zl_hw,songkai111,gitcode-chenjiao,chenxingyu18,pingchuantang,llimwang,gubaocheng,andong_hw,wangyongguang,fengying555682,xuejinghui,onanfield,zhanw_coding,clinglai0517,caiwenwen,yanglu-1 as approver
19 days ago Set FelixTang7,yue-ma,zhou-qilong,gitee-duhuiping,wangrui_,rxtfeng,loov1,tang-lei01,zhangzijie,zl_hw,songkai111,gitcode-chenjiao,chenxingyu18,pingchuantang,llimwang,gubaocheng,andong_hw,wangyongguang,fengying555682,xuejinghui,onanfield,zhanw_coding,clinglai0517,caiwenwen,yanglu-1 as approver
19 days ago Set FelixTang7,yue-ma,zhou-qilong,gitee-duhuiping,wangrui_,rxtfeng,loov1,tang-lei01,zhangzijie,zl_hw,songkai111,gitcode-chenjiao,chenxingyu18,pingchuantang,llimwang,gubaocheng,andong_hw,wangyongguang,fengying555682,xuejinghui,onanfield,zhanw_coding,clinglai0517,caiwenwen,yanglu-1 as approver
139 messages are collapsed here。 See more
tang-lei01
13 days ago Comments:
13 days ago Comments:
/approve


13 days ago Added label: lgtmapproved
13 days ago Closed associated issue
13 days ago Merged pull request
描述
本次 PR 将 CircularPad2d/CircularPad3d 统一为单一 GEIR 算子并加固边界处理,具体如下:
1. 统一 2d/3d 为单一 GEIR 算子
circular_pad,通过paddings长度(4 为 2d、6 为 3d)区分模式。x(输入,shape 3–5 维)、paddings(长度 4/6)、y(输出);同步更新 README 与 aclnnCircularPad2d/3d 文档、op_graph/circular_pad_proto.h、op_api头文件。2. 加固负 padding 与索引位宽处理
infer shape/tiling增加 int64 溢出与每侧越界校验。circular_pad_simt.h、circular_pad_tiling_data.h)修复 SIMT 索引位宽(uint32/uint64)切换路径。test_aclnn_circular_pad.cpp中 executor 重复释放导致的 double free。3. 修正 golden 浮点精度为位级精确比对
tests/assets/golden.py的 float32/float16/bfloat16 比对标准由cross_check(L1)改为binary_equal,对齐 spec 的bitwise_equal(rtol=0/atol=0)。4. 补充 ST 用例
tests/st/{kernel,aclnn})。关联的Issue
测试
test_circular_pad_tiling_arch35.cpp覆盖负 padding 与索引位宽切分。文档更新
conversion/circular_pad/README.mdconversion/circular_pad/docs/aclnnCircularPad2d.mdconversion/circular_pad/docs/aclnnCircularPad3d.md类型标签