已关闭
posembedding目录中存在多处使用__has_include,需整改 #4948
jiang-lirui创建于  23 天前关闭于  13 天前
jiang-lirui成员
23 天前 创建

与Issue #4407类似,posembedding目录中存在多处使用__has_include。当前路径问题已解决,不需要通过__has_include区分,只需include真实头文件路径即可,请参考PR_11037整改

~/ops-transformer/posembedding/apply_rotary_pos_emb_grad/op_kernel/arch35/apply_rotary_pos_emb_grad_common.h:
  23  // 复用原有 apply_rotary_pos_emb 常量定义
  24: #if __has_include("../../apply_rotary_pos_emb/arch35/apply_rotary_pos_emb_common.h")
  25  #include "../../apply_rotary_pos_emb/arch35/apply_rotary_pos_emb_common.h"

~/ops-transformer/posembedding/rotary_position_embedding/op_kernel/arch35/rotary_position_embedding_a_and_b.h:
  18  #include "op_kernel/math_util.h"
  19: #if __has_include("../../apply_rotary_pos_emb/arch35/apply_rotary_pos_emb_common.h")
  20  #include "../../apply_rotary_pos_emb/arch35/apply_rotary_pos_emb_common.h"

~/ops-transformer/posembedding/rotary_position_embedding/op_kernel/arch35/rotary_position_embedding_ab.h:
  20  #include "op_kernel/load_store_utils.h"
  21: #if __has_include("../../apply_rotary_pos_emb/arch35/apply_rotary_pos_emb_common.h")
  22  #include "../../apply_rotary_pos_emb/arch35/apply_rotary_pos_emb_common.h"

~/ops-transformer/posembedding/rotary_position_embedding/op_kernel/arch35/rotary_position_embedding_aba_and_ba.h:
  18  #include "op_kernel/math_util.h"
  19: #if __has_include("../../apply_rotary_pos_emb/arch35/apply_rotary_pos_emb_common.h")
  20  #include "../../apply_rotary_pos_emb/arch35/apply_rotary_pos_emb_common.h"

~/ops-transformer/posembedding/rotary_position_embedding/op_kernel/arch35/rotary_position_embedding_bab.h:
  19  #include "op_kernel/math_util.h"
  20: #if __has_include("../../apply_rotary_pos_emb/arch35/apply_rotary_pos_emb_common.h")
  21  #include "../../apply_rotary_pos_emb/arch35/apply_rotary_pos_emb_common.h"

~/ops-transformer/posembedding/rotary_position_embedding_grad/op_kernel/arch35/rotary_position_embedding_grad_common.h:
  19  #include "op_kernel/load_store_utils.h"
  20: #if __has_include("../../apply_rotary_pos_emb/arch35/apply_rotary_pos_emb_common.h")
  21  #include "../../apply_rotary_pos_emb/arch35/apply_rotary_pos_emb_common.h"
likedislike
Jjiang-lirui成员
23 天前 修改标题为 “posembedding目录中存在多处使用__has_include,需整改”,原标题为“posembedding目录中存在大量使用__has_include,需整改”
Jjiang-lirui成员
23 天前 修改了issue 的描述
游震成员
23 天前 评论:

/assign @luwei_1104

likedislike
CANN-robotCANN-robot成员
23 天前 将 luwei_1104 设为负责人
AlfengYuan
AlfengYuan成员
23 天前 评论:

/assign

likedislike
CANN-robotCANN-robot成员
23 天前 将 alfengyuan 设为负责人,移除负责人 luwei_1104
AlfengYuanAlfengYuan成员
13 天前 关联了pull request:refactor(posembedding): 移除op_kernel头文件的__has_include守卫, 统一include真实头文件路径
CANN-robotCANN-robot成员
13 天前 关闭了 issue
AlfengYuanAlfengYuan成员
13 天前 issue状态由 进行中 改变为 已完成
CANN-robotCANN-robot成员
13 天前 添加了label:resolved